Skip to contentSkip to conversation

NFSv4 callback: too many open connections, consider increasing the number of threads.

PATCH NeilBrown 1 participant 1 message Jul 12, 2012

Subsystems (2)
lore
Share & tools
lore

NeilBrown

author
#0 lore raw

Hi Trond et al.

we have a customer who reports getting the message:

        [10879512.275305] NFSv4 callback: too many open  connections, consider increasing the number of threads.
        [10879512.275315] NFSv4 callback: too many open  connections, consider increasing the number of threads.
        [10879517.276133] __ratelimit: 133011 callbacks suppressed

Of course you cannot increase the number of threads handling callbacks.

The patch below will get rid of the message - which is presumably mostly just noise - or possibly change it to
NFSv4 callback: too many open connections, consider increasing the max number of connections
if the number of connections gets too high.

This isn't much good as this patch doesn't allow the max number to be increased.
Do we want to make the max number of callback connections configurable, or should we find a way to silence that message.
(For lockd that message is valid as there is a sysctl to change the max number of connections for lockd).

Thanks,
NeilBrown

fs/nfs/callback.c +4 -0
index 23ff18f..1129c42 100644
@@ -265,6 +265,10 @@ int nfs_callback_up(u32 minorversion, struct rpc_xprt *xprt)
 		ret = -ENOMEM;
 		goto out_err;
 	}
+	/* As there is only one thread so we need to over-ride the
+	 * default maximum of 80 connections
+	 */
+	serv->sv_maxconn = 1024;
 
 	ret = svc_bind(serv, net);
 	if (ret < 0) {