beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3
PATCH 1/1 beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3
From: Peter Meerwald <[email protected]>
--- board/ti/beagle/beagle.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
board/ti/beagle/beagle.c +4 -0
@@ -245,6 +245,7 @@ unsigned int get_expansion_id(void)return expansion_config.device_vendor; } +#ifdef CONFIG_VIDEO_OMAP3 /* * Configure DSS to display background color on DVID * Configure VENC to display color bar on S-Video
@@ -299,6 +300,7 @@ static void beagle_dvi_pup(void) break; } } +#endif /* * Routine: misc_init_r
@@ -483,9 +485,11 @@ int misc_init_r(void)dieid_num_r (); +#ifdef CONFIG_VIDEO_OMAP3 beagle_dvi_pup ();beagle_display_init ();omap3_dss_enable (); +#endif return 0 ; }
Signature · 1 line
1.7.5.4
PATCH 1/1 beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3
Quoted 3 lines · Peter Meerwald
From: Peter Meerwald <[email protected]>
Signed-off-by Peter Meerwald <[email protected]>
So, why? Are you doing custom builds for beagleboard, but with the dss stuff removed? To try and make beagle an easier starting point for custom hardware? Thanks!
Signature · 1 line
Tom
PATCH 1/1 beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3
Quoted 4 lines
So, why? Are you doing custom builds for beagleboard, but with the dss stuff removed? To try and make beagle an easier starting point for custom hardware? Thanks!
I consider a CONFIG #define which only works when defined a bug
thx, p.
Signature · 2 lines
Peter Meerwald +43-664-2444418 (mobile)
PATCH 1/1 beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3
Hi Peter,
Quoted 6 lines · Peter Meerwald
Quoted 4 lines
So, why? Are you doing custom builds for beagleboard, but with the dss stuff removed? To try and make beagle an easier starting point for custom hardware? Thanks!
I consider a CONFIG #define which only works when defined a bug
Trying to understand here. So the problem you are addressing is that even when CONFIG_VIDEO_OMAP3 is not defined, some video code still gets compiled?
Quoted 2 lines
thx, p.
Amicalement,
Signature · 1 line
Albert.
PATCH 1/1 beagle: only call DSS code when #defined CONFIG_VIDEO_OMAP3
Quoted 4 lines · Albert ARIBAUD
Hi Peter,
Quoted 1 line · Peter Meerwald
Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
So, why? Are you doing custom builds for beagleboard, but with the dss stuff removed? To try and make beagle an easier starting point for custom hardware? Thanks!
I consider a CONFIG #define which only works when defined a bug
Trying to understand here. So the problem you are addressing is that even when
CONFIG_VIDEO_OMAP3is not defined, some video code still gets compiled?
Right. I've taken this into my next branch (I hadn't announced yet since I can't go run boot tests right now) since it's a logical fix.
Signature · 1 line
Tom