Skip to contentSkip to conversation

drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable 'error'

PATCH In review Fengguang Wu 2 participants 2 messages Jul 13, 2012

Subsystems (2)
Kernel janitors HID
lore
Share & tools
lore

Fengguang Wu

author
#0 lore raw

PATCH 43/45 drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable 'error'

Hi Sourav,

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
head:   7545a8052565aa68eeb4dfb59c1fb5d21a6867e7
commit: 3dad34659e6646ab578d82b75a023cc4640fe322 [43/45] Input: omap4-keypad - add device tree support

All warnings:

drivers/input/keyboard/omap4-keypad.c: In function 'omap4_keypad_parse_dt':
drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable 'error' [-Wunused-variable]

vim +218 drivers/input/keyboard/omap4-keypad.c
215 struct omap4_keypad *keypad_data)
216 {
217 struct device_node *np = dev->of_node;

Quoted 1 line

218 int error;

219
220 if (!np) {
221 dev_err(dev, "missing DT data");

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#1 lore raw
Quoted 17 lines · Fengguang Wu

Hi Sourav,

There are new compile warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
head:   7545a8052565aa68eeb4dfb59c1fb5d21a6867e7
commit: 3dad34659e6646ab578d82b75a023cc4640fe322 [43/45] Input: omap4-keypad

- add device tree support

All warnings:

drivers/input/keyboard/omap4-keypad.c: In function 'omap4_keypad_parse_dt':
drivers/input/keyboard/omap4-keypad.c:218:6: warning: unused variable 'error' [-Wunused-variable]

vim +218 drivers/input/keyboard/omap4-keypad.c
215 struct omap4_keypad *keypad_data)

Quoted 8 lines
   216	{
   217		struct device_node *np = dev->of_node;
Quoted 1 line

218 int error;

   219
   220		if (!np) {
   221			dev_err(dev, "missing DT data");

Hmm, must be me; I'll zap it later tonight.

Signature · 1 line
Dmitry