Remove -fPIC on x86_64
PATCH v3 1/1 Remove -fPIC on x86_64
The -fPIC breaks the purgatory of kexec (= the code that passes command-line arguments to the kernel): kexec doesn't know how to handle the GOT and PLT relocation entries.
There is also no reason at all to pass -fPIC. Shared libraries that require it will add it to their local Makefiles, and normal executables have no business with -fPIC (plus it adds overhead...).
The -fPIC was added by Bernhard Reutner-Fischer <[email protected]> in commit 8027784c. That commit adds sysroot parameters to CFLAGS. There is no explanation why -fPIC is also added for x86_64.
---
Build-tested with Sourcery toolchain and full-featured internal toolchain on a x86_64 host with allyesconfig (but without the packages that fail to build in the first place).
v3:
- Rebase on master (v2 was accidentally diffed against the rejected libgcrypt-config patch)
- Remove CCACHE_DISABLE again (I couldn't reproduce it on clean rebuild of the allyesconfig)
v2:
- Add CCACHE_DISABLE to TARGET_CONFIGURE_ARGS
- Test with allyesconfig
package/Makefile.in | 6 ------ 1 file changed, 6 deletions(-)
package/Makefile.in +0 -6
@@ -87,12 +87,6 @@ endif TARGET_CFLAGS=$(TARGET_ABI) $(TARGET_OPTIMIZATION) $(TARGET_DEBUGGING) -ifneq ($(BR2_PREFER_STATIC_LIB),y) -ifeq ($(BR2_x86_64),y) -TARGET_CFLAGS+=-fPIC -DPIC -endif # PIC for dynamic objects on x86_64 -endif - ifeq ($(findstring yy,$(BR2_mips)$(BR2_MIPS_ABI64)),yy) TARGET_CFLAGS+=-fno-pic -mno-abicalls endif
Signature · 1 line
tg: (9546394..) t/remove-pic (depends on: t/force-cross)
Thomas Petazzoni
AppliedPATCH v3 1/1 Remove -fPIC on x86_64
Le Wed, 11 Jul 2012 14:57:18 +0200,
"Arnout Vandecappelle (Essensium/Mind)" <[email protected]> a ?crit :
Quoted 8 lines
The -fPIC breaks the purgatory of kexec (= the code that passes command-line arguments to the kernel): kexec doesn't know how to handle the GOT and PLT relocation entries.
There is also no reason at all to pass -fPIC. Shared libraries that require it will add it to their local Makefiles, and normal executables have no business with -fPIC (plus it adds overhead...).
Quoted 5 lines
The -fPIC was added by Bernhard Reutner-Fischer <[email protected]> in commit
8027784c. That commit adds sysroot parameters to CFLAGS. There is no explanation why -fPIC is also added forx86_64.
Applied, thanks.
Thomas
Signature · 4 lines
Thomas Petazzoni, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com