Skip to contentSkip to conversation

fs/block-dev.c:fix performance regression in O_DIRECT writes to md block devices

PATCH New majianpeng 1 participant 1 message Jul 17, 2012

Subsystems (2)
VFS MD RAID
lore
Share & tools
lore

majianpeng

author
#0 lore raw

PATCH 1/2 fs/block-dev.c:fix performance regression in O_DIRECT writes to md block devices

For regular file, write operaion used blk_plug function.But for block file,write operation did not use blk_plug.
This patch is also for write-cache mode for block-device.

Signed-off-by Jianpeng Ma <[email protected]>
---
 fs/block_dev.c |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)
fs/block_dev.c +3 -0
index c2bbe1f..cf10778 100644
@@ -1579,9 +1579,11 @@ ssize_t blkdev_aio_write(struct kiocb *iocb, const struct iovec *iov,
 {
  struct file *file = iocb->ki_filp;
  ssize_t ret;
+ struct blk_plug plug;
 
  BUG_ON(iocb->ki_pos != pos);
 
+ blk_start_plug(&plug);
  ret = __generic_file_aio_write(iocb, iov, nr_segs, &iocb->ki_pos);
  if (ret > 0 || ret == -EIOCBQUEUED) {
  ssize_t err;

@@ -1590,6 +1592,7 @@ ssize_t blkdev_aio_write(struct kiocb *iocb, const struct iovec *iov,
  if (err < 0 && ret > 0)
  ret = err;
  }
+ blk_finish_plug(&plug);
  return ret;
 }
 EXPORT_SYMBOL_GPL(blkdev_aio_write);
Signature · 1 line
1.7.5.4