Skip to contentSkip to conversation

Andreas Müller : systemd.bbclass: add *-systemd packages to RRECOMMENDS

oe-commits In review Martin Jansa 3 participants 11 messages Jul 16, 2012 – Aug 16, 2012 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20120716074256.12AC410334@opal

#1 lore raw
Quoted 9 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:
Module: meta-openembedded.git
Branch: master
Commit: 264e5a44e1111f939b43c11bb9514a0b435918db
URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db
Author: Andreas Müller <[email protected]>
Date:   Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot
image.
busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and
it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something like that, but by default it doesn't work very well in this use-case.

Cheers,

Quoted 61 lines

---

 meta-systemd/classes/systemd.bbclass |   26 ++++++++++++++++++++++----
 1 files changed, 22 insertions(+), 4 deletions(-)
meta-systemd/classes/systemd.bbclass +22 -4
index 2e585c3..fce314d 100644
@@ -180,8 +180,21 @@ python populate_packages_prepend () {
 					raise bb.build.FuncFailed, "\n\nFor package %s SYSTEMD_SERVICE-entry %s does not exist" % \
 						(pkg_systemd, service)
 
-	# *-systemd packages get RDEPENDS to systemd and their base package
-	def systemd_add_rdepends(pkg_systemd):
+	"""     Setup rdepends / rrecommmends as:
+
+                -----------------------------
+                |  pkg_systemd_base: 'foo'  |
+                -----------------------------
+                           |    ^
+                           |    |                 --------------
+               rrecommends |    | rdepends        | 'systemd'  |
+                           |    |               ->--------------
+                           V    |              / rdepends
+                ------------------------------/
+                | pkg_systemd: 'foo-systemd' |
+                ------------------------------
+	"""
+	def systemd_add_rdepends_rrecommends(pkg_systemd):
 		# RDEPENDS_${pkg_systemd} += pkg_systemd_base systemd
 		rdepends = d.getVar('RDEPENDS_' + pkg_systemd, 1) or ""
 		rdepends_arr = rdepends.split()
@@ -195,13 +208,18 @@ python populate_packages_prepend () {
 		if len(rdepends_arr) == 0 and pkg_systemd != '${PN}' and not pkg_systemd_base in rdepends:
 			rdepends = '%s %s' % (rdepends, pkg_systemd_base)
 		d.setVar('RDEPENDS_' + pkg_systemd, rdepends)
-
+		# RRECOMMENDS_${pkg_systemd_base} += pkg_systemd systemd
+		rrecommends = d.getVar('RRECOMMENDS_' + pkg_systemd_base, 1) or ""
+		# not rrecommending myself AND avoid double entries
+		if pkg_systemd != pkg_systemd_base and not pkg_systemd in rrecommends.split():
+			rrecommends = '%s %s' % (rrecommends, pkg_systemd)
+		d.setVar('RRECOMMENDS_' + pkg_systemd_base, rrecommends)
 
 	# run all modifications once when creating package
 	if os.path.exists('${D}'):
 		for pkg_systemd in d.getVar('SYSTEMD_PACKAGES', 1).split():
 			if get_package_var(d, 'SYSTEMD_SERVICE', pkg_systemd) != "":
 				systemd_generate_package_scripts(pkg_systemd)
-				systemd_add_rdepends(pkg_systemd)
+				systemd_add_rdepends_rrecommends(pkg_systemd)
 		systemd_check_services()
 }

_______________________________________________
Openembedded-commits mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 16 lines · Martin Jansa
Quoted 9 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:
Module: meta-openembedded.git
Branch: master
Commit: 264e5a44e1111f939b43c11bb9514a0b435918db
URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db
Author: Andreas Müller <[email protected]>
Date:   Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot
image.
busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and
it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

Quoted 7 lines

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something like that, but by default it doesn't work very well in this use-case.

Cheers,

I think the image specific BAD_RECOMMENDATION is not that easy to implement and to handle by user. I am 'dreaming' of of a distro layer blacklist. So in your case the distro could mask out whole meta-systemd. Could you live with that?

Andreas

#3 lore raw
Quoted 22 lines · Andreas Müller
Quoted 21 lines · Martin Jansa
Quoted 9 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:
Module: meta-openembedded.git
Branch: master
Commit: 264e5a44e1111f939b43c11bb9514a0b435918db
URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db
Author: Andreas Müller <[email protected]>
Date:   Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot
image.
busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and
it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something like that, but by default it doesn't work very well in this use-case.

Quoted 6 lines
Quoted 2 lines

Cheers,

I think the image specific BAD_RECOMMENDATION is not that easy to implement and to handle by user. I am 'dreaming' of of a distro layer blacklist. So in your case the distro could mask out whole meta-systemd. Could you live with that?

No, as the same distro is used to create full images with systemd and this chroot-image is just small initramfs for kernel (where systemd+friends is really not needed/expected).

Cheers,

Quoted 7 lines

Andreas

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#4 lore raw

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 17-07-12 11:18, Martin Jansa schreef:

Quoted 11 lines · Andreas Müller
Quoted 10 lines
Quoted 8 lines · Martin Jansa
Quoted 6 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:

Module: meta-openembedded.git Branch: master Commit:
264e5a44e1111f939b43c11bb9514a0b435918db URL:
http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db

Author: Andreas Müller <[email protected]>

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines

Date: Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot image. busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something

Quoted 5 lines
Quoted 5 lines
Quoted 5 lines

like that, but by default it doesn't work very well in this use-case.

Cheers,

Quoted 8 lines
Quoted 4 lines

I think the image specific BAD_RECOMMENDATION is not that easy to implement and to handle by user. I am 'dreaming' of of a distro layer blacklist. So in your case the distro could mask out whole meta-systemd. Could you live with that?

No, as the same distro is used to create full images with systemd and this chroot-image is just small initramfs for kernel (where systemd+friends is really not needed/expected).

I think the easiest solution is to remove 'inherit systemd' from busybox. -----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQBS8fMkyGM64RGpERAlJGAKC4n4q1daBZUi9ltRWaY5jW4GKEcQCfeOxE amLnSb79qfeIuA1HExCF2M0=
=ypGT
-----END PGP SIGNATURE-----

#5 lore raw
Quoted 41 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 17-07-12 11:18, Martin Jansa schreef:

Quoted 11 lines · Andreas Müller
Quoted 10 lines
Quoted 8 lines · Martin Jansa
Quoted 6 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:

Module: meta-openembedded.git Branch: master Commit:
264e5a44e1111f939b43c11bb9514a0b435918db URL:
http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db

Author: Andreas Müller <[email protected]>

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines

Date: Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot image. busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something

Quoted 10 lines
Quoted 9 lines
Quoted 5 lines

like that, but by default it doesn't work very well in this use-case.

Cheers,

I think the image specific BAD_RECOMMENDATION is not that easy to implement and to handle by user. I am 'dreaming' of of a distro layer blacklist. So in your case the distro could mask out whole meta-systemd. Could you live with that?

Quoted 5 lines
Quoted 3 lines

No, as the same distro is used to create full images with systemd and this chroot-image is just small initramfs for kernel (where systemd+friends is really not needed/expected).

I think the easiest solution is to remove 'inherit systemd' from busybox.

I have similar problem with gpsd/fso-gpsd and gpsd-systemd too.. On some devices I would like to include gpsd-systemd in image (e.g. with systemd-machine-units or through some machine specific task), but on others (e.g. om-gta02) I need only fso-gpsd.service to provide gpsd (gpsd-systemd locks gpsd port).

So maybe I didn't understand Andreas right.. I can put all *-systemd packages to BAD_RECOMMENDATIONs and then include only needed in tasks/images like I did before..

Cheers,

Quoted 14 lines

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)
Comment: GPGTools - http://gpgtools.org

iD8DBQFQBS8fMkyGM64RGpERAlJGAKC4n4q1daBZUi9ltRWaY5jW4GKEcQCfeOxE amLnSb79qfeIuA1HExCF2M0=
=ypGT
-----END PGP SIGNATURE-----

_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#6 lore raw
Quoted 54 lines · Martin Jansa
Quoted 41 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 17-07-12 11:18, Martin Jansa schreef:

Quoted 11 lines · Andreas Müller
Quoted 10 lines
Quoted 8 lines · Martin Jansa
Quoted 6 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:

Module: meta-openembedded.git Branch: master Commit:
264e5a44e1111f939b43c11bb9514a0b435918db URL:
http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db

Author: Andreas Müller <[email protected]>

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines

Date: Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot image. busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something

Quoted 10 lines
Quoted 9 lines
Quoted 5 lines

like that, but by default it doesn't work very well in this use-case.

Cheers,

I think the image specific BAD_RECOMMENDATION is not that easy to implement and to handle by user. I am 'dreaming' of of a distro layer blacklist. So in your case the distro could mask out whole meta-systemd. Could you live with that?

Quoted 5 lines
Quoted 3 lines

No, as the same distro is used to create full images with systemd and this chroot-image is just small initramfs for kernel (where systemd+friends is really not needed/expected).

I think the easiest solution is to remove 'inherit systemd' from busybox.

I have similar problem with gpsd/fso-gpsd and gpsd-systemd too.. On some devices I would like to include gpsd-systemd in image (e.g. with systemd-machine-units or through some machine specific task), but on others (e.g. om-gta02) I need only fso-gpsd.service to provide gpsd (gpsd-systemd locks gpsd port).

Quoted 4 lines

So maybe I didn't understand Andreas right.. I can put all *-systemd packages to BAD_RECOMMENDATIONs and then include only needed in tasks/images like I did before..

Martin,

Correct me if I go wrong but I think you are mixing up two issues:

issue 1. busybox: automatic redepending drags in things you don't want. issue 2. gpsd: If I understand you right: there are two services shipped and auto-enabled and that is leading to a conflict.

My suggestions:
issue 1. Similar as Koen suggested but I would add an additional variable - something like SYSTEMD_NO_RRECOMMENDS_{PN}. If this is set to "1", the automatic rrecommends are not appended.
issue 2. The conflict could be resolved by SYSTEMD_AUTO_ENABLE = "disable".

Andreas

#7 lore raw
Quoted 55 lines · Andreas Müller
Quoted 54 lines · Martin Jansa
Quoted 41 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 17-07-12 11:18, Martin Jansa schreef:

Quoted 11 lines · Andreas Müller
Quoted 10 lines
Quoted 8 lines · Martin Jansa
Quoted 6 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:

Module: meta-openembedded.git Branch: master Commit:
264e5a44e1111f939b43c11bb9514a0b435918db URL:
http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db

Author: Andreas Müller <[email protected]>

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines

Date: Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot image. busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something

Quoted 10 lines
Quoted 9 lines
Quoted 5 lines

like that, but by default it doesn't work very well in this use-case.

Cheers,

I think the image specific BAD_RECOMMENDATION is not that easy to implement and to handle by user. I am 'dreaming' of of a distro layer blacklist. So in your case the distro could mask out whole meta-systemd. Could you live with that?

Quoted 5 lines
Quoted 3 lines

No, as the same distro is used to create full images with systemd and this chroot-image is just small initramfs for kernel (where systemd+friends is really not needed/expected).

I think the easiest solution is to remove 'inherit systemd' from busybox.

I have similar problem with gpsd/fso-gpsd and gpsd-systemd too.. On some devices I would like to include gpsd-systemd in image (e.g. with systemd-machine-units or through some machine specific task), but on others (e.g. om-gta02) I need only fso-gpsd.service to provide gpsd (gpsd-systemd locks gpsd port).

Quoted 7 lines
Quoted 4 lines

So maybe I didn't understand Andreas right.. I can put all *-systemd packages to BAD_RECOMMENDATIONs and then include only needed in tasks/images like I did before..

Martin,

Correct me if I go wrong but I think you are mixing up two issues:

yes but slightly related, see bellow

Quoted 4 lines

issue 1. busybox: automatic redepending drags in things you don't want. issue 2. gpsd: If I understand you right: there are two services shipped and auto-enabled and that is leading to a conflict.

Yes, but sofar having gpsd installed was fine, because it didn't pull gpsd-systemd too (so user was able to start gpsd manually if needed).

Now with PN-systemd pulled by PN I need to be more carefull with images having both gpsd/fso-gpsd.

Quoted 5 lines

My suggestions:
issue 1. Similar as Koen suggested but I would add an additional variable - something like SYSTEMD_NO_RRECOMMENDS_{PN}. If this is set to "1", the automatic rrecommends are not appended.
issue 2. The conflict could be resolved by SYSTEMD_AUTO_ENABLE = "disable".

I'm trying BAD_RECOMMENDATIONS to resolve this:
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=679453cdbc2c58b6558c8ede8e6e17826dbb7b3d
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=fe8a92f123ef3137a9e08e6419315f97f4a663fb
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=1afdd57475bd3ce586e622bfe6baeb3906bedc2f
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=af74fe87eeb606b167697453d515a269e2280eb6

but it needs more testing (other builds still running) and for some reason opkg refuses to remove gpsd-systemd:

SHRZ root@zjama ~ $ opkg remove gpsd-systemd
No packages removed.
Collected errors:
* print_dependents_warning: Package gpsd-systemd is depended upon by packages:
* print_dependents_warning: task-shr-systemd
* print_dependents_warning: gpsd
* print_dependents_warning: These might cease to work if package gpsd-systemd is removed.

* print_dependents_warning: Force removal of this package with --force-depends.
* print_dependents_warning: Force removal of this package and its dependents
* print_dependents_warning: with --force-removal-of-dependent-packages.
SHRZ root@zjama ~ $ opkg info gpsd
Package: gpsd
Version: 3.4-r7
Depends: libgps20 (>= 3.4), update-rc.d, gpsd-gpsctl, libgpsd20 (>= 3.4), bluez4 (>= 4.101), libusb-1.0-0 (>= 1.0.8), libc6 (>= 2.16)
Recommends: gpsd-conf, gpsd-systemd

even when it's only in gpsd's Recommends..

will check buildhistory after image build if it works there..

Cheers,

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#8 lore raw
Quoted 108 lines · Martin Jansa
Quoted 55 lines · Andreas Müller
Quoted 54 lines · Martin Jansa
Quoted 41 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 17-07-12 11:18, Martin Jansa schreef:

Quoted 11 lines · Andreas Müller
Quoted 10 lines
Quoted 8 lines · Martin Jansa
Quoted 6 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:

Module: meta-openembedded.git Branch: master Commit:
264e5a44e1111f939b43c11bb9514a0b435918db URL:
http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db

Author: Andreas Müller <[email protected]>

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines

Date: Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot image. busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something

Quoted 10 lines
Quoted 9 lines
Quoted 5 lines

like that, but by default it doesn't work very well in this use-case.

Cheers,

I think the image specific BAD_RECOMMENDATION is not that easy to implement and to handle by user. I am 'dreaming' of of a distro layer blacklist. So in your case the distro could mask out whole meta-systemd. Could you live with that?

Quoted 5 lines
Quoted 3 lines

No, as the same distro is used to create full images with systemd and this chroot-image is just small initramfs for kernel (where systemd+friends is really not needed/expected).

I think the easiest solution is to remove 'inherit systemd' from busybox.

I have similar problem with gpsd/fso-gpsd and gpsd-systemd too.. On some devices I would like to include gpsd-systemd in image (e.g. with systemd-machine-units or through some machine specific task), but on others (e.g. om-gta02) I need only fso-gpsd.service to provide gpsd (gpsd-systemd locks gpsd port).

Quoted 7 lines
Quoted 4 lines

So maybe I didn't understand Andreas right.. I can put all *-systemd packages to BAD_RECOMMENDATIONs and then include only needed in tasks/images like I did before..

Martin,

Correct me if I go wrong but I think you are mixing up two issues:

yes but slightly related, see bellow

Quoted 4 lines

issue 1. busybox: automatic redepending drags in things you don't want. issue 2. gpsd: If I understand you right: there are two services shipped and auto-enabled and that is leading to a conflict.

Yes, but sofar having gpsd installed was fine, because it didn't pull gpsd-systemd too (so user was able to start gpsd manually if needed).

Now with PN-systemd pulled by PN I need to be more carefull with images having both gpsd/fso-gpsd.

Quoted 5 lines

My suggestions:
issue 1. Similar as Koen suggested but I would add an additional variable - something like SYSTEMD_NO_RRECOMMENDS_{PN}. If this is set to "1", the automatic rrecommends are not appended.
issue 2. The conflict could be resolved by SYSTEMD_AUTO_ENABLE = "disable".

I'm trying BAD_RECOMMENDATIONS to resolve this:
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=679453cdbc2c58b6558c8ede8e6e17826dbb7b3d
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=fe8a92f123ef3137a9e08e6419315f97f4a663fb
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=1afdd57475bd3ce586e622bfe6baeb3906bedc2f
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=af74fe87eeb606b167697453d515a269e2280eb6

but it needs more testing (other builds still running) and for some reason opkg refuses to remove gpsd-systemd:

SHRZ root@zjama ~ $ opkg remove gpsd-systemd
No packages removed.
Collected errors:
* print_dependents_warning: Package gpsd-systemd is depended upon by packages:
* print_dependents_warning: task-shr-systemd
* print_dependents_warning: gpsd
* print_dependents_warning: These might cease to work if package gpsd-systemd is removed.

* print_dependents_warning: Force removal of this package with --force-depends.
* print_dependents_warning: Force removal of this package and its dependents
* print_dependents_warning: with --force-removal-of-dependent-packages.
SHRZ root@zjama ~ $ opkg info gpsd
Package: gpsd
Version: 3.4-r7
Depends: libgps20 (>= 3.4), update-rc.d, gpsd-gpsctl, libgpsd20 (>= 3.4), bluez4 (>= 4.101), libusb-1.0-0 (>= 1.0.8), libc6 (>= 2.16)
Recommends: gpsd-conf, gpsd-systemd

Quoted 4 lines

even when it's only in gpsd's Recommends..

will check buildhistory after image build if it works there..

As far as I remember, opkg treats rrecommends same as rdepends.

To remove there is some force-dependency param in opkg.

Andreas

#9 lore raw
Quoted 109 lines · Andreas Müller
Quoted 108 lines · Martin Jansa
Quoted 55 lines · Andreas Müller
Quoted 54 lines · Martin Jansa
Quoted 41 lines · Koen Kooi

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Op 17-07-12 11:18, Martin Jansa schreef:

Quoted 11 lines · Andreas Müller
Quoted 10 lines
Quoted 8 lines · Martin Jansa
Quoted 6 lines · On Mon, Jul 16, 2012 at 07:42:56AM +0000, [email protected] wrote:

Module: meta-openembedded.git Branch: master Commit:
264e5a44e1111f939b43c11bb9514a0b435918db URL:
http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=264e5a44e1111f939b43c11bb9514a0b435918db

Author: Andreas Müller <[email protected]>

Quoted 10 lines
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines

Date: Wed Jul 11 20:46:07 2012 +0200

systemd.bbclass: add *-systemd packages to RRECOMMENDS

This is a bit unfortunate e.g. when busybox is used in small chroot image. busybox pulls busybox-syslog, which now adds busybox-syslog-systemd and it ends with systemd/dbus/udev/shadow/pam/util-linux/kmod being added to previously small image, see:

Quoted 4 lines
Quoted 4 lines
Quoted 4 lines

http://git.shr-project.org/git/?p=buildhistory.git;a=blobdiff;f=images/crespo/eglibc/chroot-image/installed-package-names.txt;h=07187b9e51bd0199910152a8019d117ed41cc2db;hp=8f401e657dd449e30fe8183dc86a791d09614d9f;hb=ac04304bb15221b49e5af6838068f158e7d628ed;hpb=4c0555e7fa689c3c20902c7fc1ec8e525769723f

So it could be solved by image specific BAD_RECOMMENDATIONs or something

Quoted 10 lines
Quoted 9 lines
Quoted 5 lines

like that, but by default it doesn't work very well in this use-case.

Cheers,

I think the image specific BAD_RECOMMENDATION is not that easy to implement and to handle by user. I am 'dreaming' of of a distro layer blacklist. So in your case the distro could mask out whole meta-systemd. Could you live with that?

Quoted 5 lines
Quoted 3 lines

No, as the same distro is used to create full images with systemd and this chroot-image is just small initramfs for kernel (where systemd+friends is really not needed/expected).

I think the easiest solution is to remove 'inherit systemd' from busybox.

I have similar problem with gpsd/fso-gpsd and gpsd-systemd too.. On some devices I would like to include gpsd-systemd in image (e.g. with systemd-machine-units or through some machine specific task), but on others (e.g. om-gta02) I need only fso-gpsd.service to provide gpsd (gpsd-systemd locks gpsd port).

Quoted 7 lines
Quoted 4 lines

So maybe I didn't understand Andreas right.. I can put all *-systemd packages to BAD_RECOMMENDATIONs and then include only needed in tasks/images like I did before..

Martin,

Correct me if I go wrong but I think you are mixing up two issues:

yes but slightly related, see bellow

Quoted 4 lines

issue 1. busybox: automatic redepending drags in things you don't want. issue 2. gpsd: If I understand you right: there are two services shipped and auto-enabled and that is leading to a conflict.

Yes, but sofar having gpsd installed was fine, because it didn't pull gpsd-systemd too (so user was able to start gpsd manually if needed).

Now with PN-systemd pulled by PN I need to be more carefull with images having both gpsd/fso-gpsd.

Quoted 5 lines

My suggestions:
issue 1. Similar as Koen suggested but I would add an additional variable - something like SYSTEMD_NO_RRECOMMENDS_{PN}. If this is set to "1", the automatic rrecommends are not appended.
issue 2. The conflict could be resolved by SYSTEMD_AUTO_ENABLE = "disable".

I'm trying BAD_RECOMMENDATIONS to resolve this:
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=679453cdbc2c58b6558c8ede8e6e17826dbb7b3d
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=fe8a92f123ef3137a9e08e6419315f97f4a663fb
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=1afdd57475bd3ce586e622bfe6baeb3906bedc2f
http://git.shr-project.org/git/?p=meta-smartphone.git;a=commit;h=af74fe87eeb606b167697453d515a269e2280eb6

but it needs more testing (other builds still running) and for some reason opkg refuses to remove gpsd-systemd:

SHRZ root@zjama ~ $ opkg remove gpsd-systemd
No packages removed.
Collected errors:
* print_dependents_warning: Package gpsd-systemd is depended upon by packages:
* print_dependents_warning: task-shr-systemd
* print_dependents_warning: gpsd
* print_dependents_warning: These might cease to work if package gpsd-systemd is removed.

* print_dependents_warning: Force removal of this package with --force-depends.
* print_dependents_warning: Force removal of this package and its dependents
* print_dependents_warning: with --force-removal-of-dependent-packages.
SHRZ root@zjama ~ $ opkg info gpsd
Package: gpsd
Version: 3.4-r7
Depends: libgps20 (>= 3.4), update-rc.d, gpsd-gpsctl, libgpsd20 (>= 3.4), bluez4 (>= 4.101), libusb-1.0-0 (>= 1.0.8), libc6 (>= 2.16)
Recommends: gpsd-conf, gpsd-systemd

Quoted 7 lines
Quoted 4 lines

even when it's only in gpsd's Recommends..

will check buildhistory after image build if it works there..

As far as I remember, opkg treats rrecommends same as rdepends.

To remove there is some force-dependency param in opkg.

At least with older opkg I was able to remove recommended deps without -force-depends..

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#10 lore raw

PATCH 1/1 systemd.bbclass: add option to disable automatic RRECOMMENDS pkg-systemd_base -> pkg-systemd

In reply to Martin Jansa
---
 meta-systemd/classes/systemd.bbclass |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)
meta-systemd/classes/systemd.bbclass +10 -6
index 4036f91..96d7f8f 100644
@@ -2,6 +2,8 @@ DEPENDS_append = " systemd-systemctl-native"
 
 SYSTEMD_AUTO_ENABLE ??= "enable"
 
+SYSTEMD_AUTO_RRECOMMENDS ??= "enable"
+
 systemd_postinst() {
 OPTS=""
 
@@ -208,12 +210,14 @@ python populate_packages_prepend () {
         if len(rdepends_arr) == 0 and pkg_systemd != '${PN}' and not pkg_systemd_base in rdepends:
             rdepends = '%s %s' % (rdepends, pkg_systemd_base)
         d.setVar('RDEPENDS_' + pkg_systemd, rdepends)
-        # RRECOMMENDS_${pkg_systemd_base} += pkg_systemd systemd
-        rrecommends = d.getVar('RRECOMMENDS_' + pkg_systemd_base, 1) or ""
-        # not rrecommending myself AND avoid double entries
-        if pkg_systemd != pkg_systemd_base and not pkg_systemd in rrecommends.split():
-            rrecommends = '%s %s' % (rrecommends, pkg_systemd)
-        d.setVar('RRECOMMENDS_' + pkg_systemd_base, rrecommends)
+        auto_rrecommends = d.getVar('SYSTEMD_AUTO_RRECOMMENDS', 1) or 'enable'
+        if auto_rrecommends == 'enable':
+            # RRECOMMENDS_${pkg_systemd_base} += pkg_systemd systemd
+            rrecommends = d.getVar('RRECOMMENDS_' + pkg_systemd_base, 1) or ""
+            # not rrecommending myself AND avoid double entries
+            if pkg_systemd != pkg_systemd_base and not pkg_systemd in rrecommends.split():
+                rrecommends = '%s %s' % (rrecommends, pkg_systemd)
+            d.setVar('RRECOMMENDS_' + pkg_systemd_base, rrecommends)
 
     # run all modifications once when creating package
     if os.path.exists('${D}'):
Signature · 1 line
1.7.8.6
Acked-by on v1 1/1
#11 lore raw

Re: [meta-oe][meta-systemd][PATCH] systemd.bbclass: add option to disable automatic RRECOMMENDS pkg-systemd_base -> pkg-systemd

Quoted 40 lines · Martin Jansa
---
 meta-systemd/classes/systemd.bbclass |   16 ++++++++++------
 1 files changed, 10 insertions(+), 6 deletions(-)
meta-systemd/classes/systemd.bbclass +10 -7
index 4036f91..96d7f8f 100644
@@ -2,6 +2,8 @@ DEPENDS_append = " systemd-systemctl-native"
 
 SYSTEMD_AUTO_ENABLE ??= "enable"
 
+SYSTEMD_AUTO_RRECOMMENDS ??= "enable"
+
 systemd_postinst() {
 OPTS=""
 
@@ -208,12 +210,14 @@ python populate_packages_prepend () {
         if len(rdepends_arr) == 0 and pkg_systemd != '${PN}' and not pkg_systemd_base in rdepends:
             rdepends = '%s %s' % (rdepends, pkg_systemd_base)
         d.setVar('RDEPENDS_' + pkg_systemd, rdepends)
-        # RRECOMMENDS_${pkg_systemd_base} += pkg_systemd systemd
-        rrecommends = d.getVar('RRECOMMENDS_' + pkg_systemd_base, 1) or ""
-        # not rrecommending myself AND avoid double entries
-        if pkg_systemd != pkg_systemd_base and not pkg_systemd in rrecommends.split():
-            rrecommends = '%s %s' % (rrecommends, pkg_systemd)
-        d.setVar('RRECOMMENDS_' + pkg_systemd_base, rrecommends)
+        auto_rrecommends = d.getVar('SYSTEMD_AUTO_RRECOMMENDS', 1) or 'enable'
+        if auto_rrecommends == 'enable':
+            # RRECOMMENDS_${pkg_systemd_base} += pkg_systemd systemd
+            rrecommends = d.getVar('RRECOMMENDS_' + pkg_systemd_base, 1) or ""
+            # not rrecommending myself AND avoid double entries
+            if pkg_systemd != pkg_systemd_base and not pkg_systemd in rrecommends.split():
+                rrecommends = '%s %s' % (rrecommends, pkg_systemd)
+            d.setVar('RRECOMMENDS_' + pkg_systemd_base, rrecommends)
 
     # run all modifications once when creating package
     if os.path.exists('${D}'):
--
Quoted 3 lines

1.7.8.6

Although I don't have this use case - I like this one. Off topic: We should think of documentation for the systemd variables...