staging: comedi: cb_pcidas64: cleanup "find pci device" code
PATCH 40/90 staging: comedi: cb_pcidas64: cleanup "find pci device" code
Add a couple local variables to make the tests more concise. Reorder the tests to make the for() loop checking for a matching boardtype quicker.
Drop the dev_dbg for a match. It's just add noise. Reword the dev_err when no match is found.
Signed-off-by H Hartley Sweeten <[email protected]>
Cc Ian Abbott <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>
--- drivers/staging/comedi/drivers/cb_pcidas64.c | 34 ++++++++++++---------------- 1 file changed, 15 insertions(+), 19 deletions(-)
drivers/staging/comedi/drivers/cb_pcidas64.c +15 -19
@@ -1654,33 +1654,29 @@ static struct pci_dev *cb_pcidas64_find_pci_dev(struct comedi_device *dev, struct comedi_devconfig *it) {struct pci_dev *pcidev =NULL ; -int index; +int bus = it->options[0 ]; +int slot = it->options[1 ]; +int i;for_each_pci_dev (pcidev) { -/* is it not a computer boards card? */ +if (bus || slot) { +if (bus != pcidev->bus->number || + slot !=PCI_SLOT (pcidev->devfn)) +continue ; + }if (pcidev->vendor !=PCI_VENDOR_ID_COMPUTERBOARDS )continue ; -/* loop through cards supported by this driver */ -for (index =0 ; index <ARRAY_SIZE (pcidas64_boards); index++) { -if (pcidas64_boards[index].device_id != pcidev->device) + +for (i =0 ; i <ARRAY_SIZE (pcidas64_boards); i++) { +if (pcidas64_boards[i].device_id != pcidev->device)continue ; -/* was a particular bus/slot requested? */ -if (it->options[0 ] || it->options[1 ]) { -/* are we on the wrong bus/slot? */ -if (pcidev->bus->number != it->options[0 ] || -PCI_SLOT (pcidev->devfn) != it->options[1 ]) { -continue ; - } - } - dev->board_ptr = pcidas64_boards + index; -dev_dbg (dev->class_dev,"Found %s on bus %i, slot %i\n" , -board (dev)->name, - pcidev->bus->number,PCI_SLOT (pcidev->devfn)); + dev->board_ptr = pcidas64_boards + i;return pcidev; } } - -printk ("No supported ComputerBoards/MeasurementComputing card found\n" ); +dev_err (dev->class_dev, +"No supported board found! (req. bus %d, slot %d)\n" , + bus, slot);return NULL ; }
Signature · 1 line
1.7.11