NFSd: simplify locking in nfsd_recall_delegations()
Subsystems (2)
PATCH v2 1/1 NFSd: simplify locking in nfsd_recall_delegations()
v2: rebased on 3.5-rc3 kernel
Holding of client_mutex looks redundant here - recall_lock looks enough.
Signed-off-by Stanislav Kinsbursky <[email protected]>
--- fs/nfsd/nfs4state.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)
fs/nfsd/nfs4state.c +0 -2
@@ -4622,7 +4622,6 @@ void nfsd_recall_delegations(u64 num)LIST_HEAD (victims);struct nfs4_delegation *dp, *dnext; -nfs4_lock_state ();spin_lock (&recall_lock); count =nfsd_process_n_delegations (num, &victims);list_for_each_entry_safe (dp, dnext, &victims, dl_recall_lru) {
@@ -4630,7 +4629,6 @@ void nfsd_recall_delegations(u64 num)nfsd_break_one_deleg (dp); }spin_unlock (&recall_lock); -nfs4_unlock_state ();printk (KERN_INFO "NFSD: Recalled %d delegations" , count); }
Quoted 3 lines · Stanislav Kinsbursky
v2: rebased on 3.5-rc3 kernel
Holding of
client_mutexlooks redundant here -recall_locklooks enough.
Yep, thanks.--b.
Quoted 27 lines
Signed-off-by Stanislav Kinsbursky <[email protected]>--- fs/nfsd/nfs4state.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-)fs/nfsd/nfs4state.c +0
-2@@ -4622,7 +4622,6 @@ void nfsd_recall_delegations(u64 num)LIST_HEAD (victims);struct nfs4_delegation *dp, *dnext; -nfs4_lock_state ();spin_lock (&recall_lock); count =nfsd_process_n_delegations (num, &victims);list_for_each_entry_safe (dp, dnext, &victims, dl_recall_lru) {@@ -4630,7 +4629,6 @@ void nfsd_recall_delegations(u64 num)nfsd_break_one_deleg (dp); }spin_unlock (&recall_lock); -nfs4_unlock_state ();printk (KERN_INFO "NFSD: Recalled %d delegations" , count); }