net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (diff

PATCH In review Fengguang Wu 2 participants 3 messages Jul 19, 2012 Kernel janitors

lore

Share & tools

lore

Fengguang Wu

author

2012-07-19 03:12 UTC #0 lore raw

PATCH 87/99 net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (diff

Hi Saurabh,

There are new sparse warnings show up in

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git for-davem
head:   ddbe503203855939946430e39bae58de11b70b69
commit: 1181412c1a671ed4e8fb1736f17e6ec617c68059 [87/99] net/ipv4: VTI support new module for ip_vti.

All sparse warnings:

+ net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (different address spaces)
net/ipv4/ip_vti.c:193:17: expected struct ip_tunnel [noderef] <asn:4>**tp
net/ipv4/ip_vti.c:193:17: got struct ip_tunnel **
+ net/ipv4/ip_vti.c:205:49: sparse: incorrect type in initializer (different address spaces)
net/ipv4/ip_vti.c:205:49: expected struct ip_tunnel [noderef] <asn:4>**tp
net/ipv4/ip_vti.c:205:49: got struct ip_tunnel **
net/ipv4/ip_vti.c:223:17: sparse: incorrect type in assignment (different address spaces)
net/ipv4/ip_vti.c:223:17: expected struct ip_tunnel [noderef] <asn:4>**tp
net/ipv4/ip_vti.c:223:17: got struct ip_tunnel **
+ net/ipv4/ip_vti.c:693:29: sparse: incompatible types in comparison expression (different address spaces)

vim +193 net/ipv4/ip_vti.c
190 struct ip_tunnel __rcu **tp;
191 struct ip_tunnel *iter;
192

Quoted 1 line

193 for (tp = vti_bucket(ipn, t);

194 (iter = rtnl_dereference(*tp)) != NULL;
195 tp = &iter->next) {
196 if (t = iter) {

Which can be fixed by adding some rcu_*() accessors to the RCU protected pointers.

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

Saurabh Mohan

2012-07-19 05:06 UTC #1 lore raw

Re: [wireless-next:for-davem 87/99] net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (

----- Original Message -----

Quoted 35 lines

Hi Saurabh,
There are new sparse warnings show up in
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git
for-davem
head:   ddbe503203855939946430e39bae58de11b70b69
commit: 1181412c1a671ed4e8fb1736f17e6ec617c68059 [87/99] net/ipv4:
VTI support new module for ip_vti.
All sparse warnings:
+ net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (different address spaces)
net/ipv4/ip_vti.c:193:17: expected struct ip_tunnel [noderef]
<asn:4>**tp
net/ipv4/ip_vti.c:193:17: got struct ip_tunnel **
+ net/ipv4/ip_vti.c:205:49: sparse: incorrect type in initializer (different address spaces)
net/ipv4/ip_vti.c:205:49: expected struct ip_tunnel [noderef]
<asn:4>**tp
net/ipv4/ip_vti.c:205:49: got struct ip_tunnel **
net/ipv4/ip_vti.c:223:17: sparse: incorrect type in assignment (different address spaces)
net/ipv4/ip_vti.c:223:17: expected struct ip_tunnel [noderef]
<asn:4>**tp
net/ipv4/ip_vti.c:223:17: got struct ip_tunnel **
+ net/ipv4/ip_vti.c:693:29: sparse: incompatible types in comparison expression (different address spaces)
vim +193 net/ipv4/ip_vti.c
   190		struct ip_tunnel __rcu **tp;
   191		struct ip_tunnel *iter;
   192

Quoted 8 lines

Quoted 1 line
193 for (tp = vti_bucket(ipn, t);
   194		     (iter = rtnl_dereference(*tp)) != NULL;
   195		     tp = &iter->next) {
   196			if (t = iter) {
Which can be fixed by adding some rcu_*() accessors to the RCU protected pointers.

Thanks for catching this. I assume I submit the fix to net-next and you will take it from there?

Fengguang Wu

author

2012-07-19 05:38 UTC #2 lore raw

Re: [wireless-next:for-davem 87/99] net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (

In reply to Fengguang Wu

Quoted 42 lines · Saurabh Mohan

----- Original Message -----
Quoted 40 lines
Hi Saurabh,
There are new sparse warnings show up in
tree:
git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless-next.git
for-davem
head:   ddbe503203855939946430e39bae58de11b70b69
commit: 1181412c1a671ed4e8fb1736f17e6ec617c68059 [87/99] net/ipv4:
VTI support new module for ip_vti.
All sparse warnings:
+ net/ipv4/ip_vti.c:193:17: sparse: incorrect type in assignment (different address spaces)
net/ipv4/ip_vti.c:193:17: expected struct ip_tunnel [noderef]
<asn:4>**tp
net/ipv4/ip_vti.c:193:17: got struct ip_tunnel **
+ net/ipv4/ip_vti.c:205:49: sparse: incorrect type in initializer (different address spaces)
net/ipv4/ip_vti.c:205:49: expected struct ip_tunnel [noderef]
<asn:4>**tp
net/ipv4/ip_vti.c:205:49: got struct ip_tunnel **
net/ipv4/ip_vti.c:223:17: sparse: incorrect type in assignment (different address spaces)
net/ipv4/ip_vti.c:223:17: expected struct ip_tunnel [noderef]
<asn:4>**tp
net/ipv4/ip_vti.c:223:17: got struct ip_tunnel **
+ net/ipv4/ip_vti.c:693:29: sparse: incompatible types in comparison expression (different address spaces)
vim +193 net/ipv4/ip_vti.c
   190		struct ip_tunnel __rcu **tp;
   191		struct ip_tunnel *iter;
   192
Quoted 1 line
193 for (tp = vti_bucket(ipn, t);
   194		     (iter = rtnl_dereference(*tp)) != NULL;
   195		     tp = &iter->next) {
   196			if (t = iter) {

Quoted 6 lines

Quoted 3 lines
Which can be fixed by adding some rcu_*() accessors to the RCU protected pointers.
Thanks for catching this. I assume I submit the fix to net-next and you will take it from there?

Yeah it works: new net-next commits will be auto build tested :)

Thanks,
Fengguang