Skip to contentSkip to conversation

lua: ensure that host-lua does not depend on host-readline and host-ncurses

PATCH New Thomas Petazzoni 1 participant 2 messages Jul 20, 2012

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 lua: ensure that host-lua does not depend on host-readline and host-ncurses

Commit ad6af5819f88bac9ca7f50e565c4fc68d3e408cc removed the HOST_LUA_DEPENDENCIES assignement to the empty variable, so from that commit, the dependencies of host-lua are automatically computed from the dependencies of lua. Since lua can depend on readline and ncurses, it means that host-lua can depend on host-readline and host-ncurses, and the host-readline package does not exist in Buildroot. Since there is no reason to build host-lua with readline/ncurses support, just re-add the HOST_LUA_DEPENDENCIES variable.

---
 package/lua/lua.mk |    3 +++
 1 file changed, 3 insertions(+)
package/lua/lua.mk +3 -0
index 8f71fc2..074b9ad 100644
@@ -23,6 +23,9 @@ else
 	LUA_CFLAGS += -DLUA_USE_POSIX -DLUA_USE_DLOPEN
 endif
 
+# We never want to have host-readline and host-ncurses as dependencies
+# of host-lua.
+HOST_LUA_DEPENDENCIES =
 HOST_LUA_CFLAGS = -Wall -fPIC -DLUA_USE_DLOPEN -DLUA_USE_POSIX
 HOST_LUA_MYLIBS = -ldl
 
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 lua: ensure that host-lua does not depend on host-readline and host-ncurses

Le Fri, 20 Jul 2012 14:42:36 +0200,
Thomas Petazzoni <[email protected]> a ?crit :

Quoted 11 lines

Commit ad6af5819f88bac9ca7f50e565c4fc68d3e408cc removed the HOST_LUA_DEPENDENCIES assignement to the empty variable, so from that commit, the dependencies of host-lua are automatically computed from the dependencies of lua. Since lua can depend on readline and ncurses, it means that host-lua can depend on host-readline and host-ncurses, and the host-readline package does not exist in Buildroot. Since there is no reason to build host-lua with readline/ncurses support, just re-add the HOST_LUA_DEPENDENCIES variable.

Applied, as well as two other fixes to make lua build with gcc 4.6, and to make host-lua install properly when it is the first host package to be built.

Thomas

Signature · 4 lines
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com