Skip to contentSkip to conversation

NVMe: Set request queue logical block size

PATCH New Busch, Keith 2 participants 2 messages Jul 24, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 NVMe: Set request queue logical block size

Sets the request queue logical block size with the block size of the namespace.

Signed-off-by Keith Busch <keith.busch at intel.com>

---
drivers/block/nvme.c | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)
drivers/block/nvme.c +1 -1
index f4996b0..38b9c73 100644
@@ -1344,6 +1344,7 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, int nsid,
     ns->disk = disk;
     lbaf = id->flbas & 0xf;
     ns->lba_shift = id->lbaf[lbaf].ds;
+     blk_queue_logical_block_size(ns->queue, 1 << ns->lba_shift);
      disk->major = nvme_major;
     disk->minors = NVME_MINORS;
--

1.7.0.4

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://merlin.infradead.org/pipermail/linux-nvme/attachments/20120724/cf1a7436/attachment.html>

#1 lore raw

PATCH 1/1 NVMe: Set request queue logical block size

Quoted 1 line · Keith

Sets the request queue logical block size with the block size of the namespace.

No objection to the patch itself, but it looks like you used Outlook to send it. Outlook has a nasty habit of corrupting patches, even if you attach them. Can you resend with a different MUA?

Quoted 24 lines
Signed-off-by Keith Busch <keith.busch at intel.com>

---
drivers/block/nvme.c | 1 +

1 files changed, 1 insertions(+), 0 deletions(-)
drivers/block/nvme.c +1 -1
index f4996b0..38b9c73 100644
@@ -1344,6 +1344,7 @@ static struct nvme_ns *nvme_alloc_ns(struct nvme_dev *dev, int nsid,
     ns->disk = disk;
     lbaf = id->flbas & 0xf;
     ns->lba_shift = id->lbaf[lbaf].ds;
+     blk_queue_logical_block_size(ns->queue, 1 << ns->lba_shift);
      disk->major = nvme_major;
     disk->minors = NVME_MINORS;
--

1.7.0.4

_______________________________________________
Linux-nvme mailing list
Linux-nvme at lists.infradead.org
http://merlin.infradead.org/mailman/listinfo/linux-nvme