ia64: rename platform_name to ia64_platform_name
PATCH 1/1 ia64: rename platform_name to ia64_platform_name
The macro name is too generic and conflicts with snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors.
---
(not sure if the previous sent was successful, so resend)
arch/ia64/include/asm/machvec.h | 2 +- arch/ia64/include/asm/machvec_dig.h | 2 +- arch/ia64/include/asm/machvec_dig_vtd.h | 2 +- arch/ia64/include/asm/machvec_hpsim.h | 2 +- arch/ia64/include/asm/machvec_hpzx1.h | 2 +- arch/ia64/include/asm/machvec_hpzx1_swiotlb.h | 2 +- arch/ia64/include/asm/machvec_sn2.h | 2 +- arch/ia64/include/asm/machvec_uv.h | 2 +- arch/ia64/include/asm/machvec_xen.h | 2 +- arch/ia64/include/asm/processor.h | 2 +- arch/ia64/pci/fixup.c | 4 ++-- 11 files changed, 12 insertions(+), 12 deletions(-)
arch/ia64/include/asm/machvec.h +1 -1
@@ -120,7 +120,7 @@ extern void machvec_tlb_migrate_finish (struct mm_struct *);# ifdef MACHVEC_PLATFORM_HEADER # include MACHVEC_PLATFORM_HEADER # else -# define platform_name ia64_mv.name +# define ia64_platform_name ia64_mv.name# define platform_setup ia64_mv.setup# define platform_cpu_init ia64_mv.cpu_init# define platform_irq_init ia64_mv.irq_init
arch/ia64/include/asm/machvec_dig.h +1 -1
@@ -10,7 +10,7 @@ extern ia64_mv_setup_t dig_setup;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "dig" +#define ia64_platform_name "dig"#define platform_setup dig_setup#endif /* _ASM_IA64_MACHVEC_DIG_h */
arch/ia64/include/asm/machvec_dig_vtd.h +1 -1
@@ -11,7 +11,7 @@ extern ia64_mv_dma_init pci_iommu_alloc;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "dig_vtd" +#define ia64_platform_name "dig_vtd"#define platform_setup dig_setup#define platform_dma_init pci_iommu_alloc
arch/ia64/include/asm/machvec_hpsim.h +1 -1
@@ -11,7 +11,7 @@ extern ia64_mv_irq_init_t hpsim_irq_init;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "hpsim" +#define ia64_platform_name "hpsim"#define platform_setup hpsim_setup#define platform_irq_init hpsim_irq_init
arch/ia64/include/asm/machvec_hpzx1.h +1 -1
@@ -11,7 +11,7 @@ extern ia64_mv_dma_init sba_dma_init;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "hpzx1" +#define ia64_platform_name "hpzx1"#define platform_setup dig_setup#define platform_dma_init sba_dma_init
arch/ia64/include/asm/machvec_hpzx1_swiotlb.h +1 -1
@@ -11,7 +11,7 @@ extern ia64_mv_dma_get_ops hwsw_dma_get_ops;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "hpzx1_swiotlb" +#define ia64_platform_name "hpzx1_swiotlb"#define platform_setup dig_setup#define platform_dma_init machvec_noop#define platform_dma_get_ops hwsw_dma_get_ops
arch/ia64/include/asm/machvec_sn2.h +1 -1
@@ -71,7 +71,7 @@ extern ia64_mv_pci_fixup_bus_t sn_pci_fixup_bus;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "sn2" +#define ia64_platform_name "sn2"#define platform_setup sn_setup#define platform_cpu_init sn_cpu_init#define platform_irq_init sn_irq_init
arch/ia64/include/asm/machvec_uv.h +1 -1
@@ -20,7 +20,7 @@ extern ia64_mv_setup_t uv_setup;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "uv" +#define ia64_platform_name "uv"#define platform_setup uv_setup#endif /* _ASM_IA64_MACHVEC_UV_H */
arch/ia64/include/asm/machvec_xen.h +1 -1
@@ -13,7 +13,7 @@ extern ia64_mv_send_ipi_t xen_platform_send_ipi;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "xen" +#define ia64_platform_name "xen"#define platform_setup dig_setup#define platform_cpu_init xen_cpu_init#define platform_irq_init xen_irq_init
arch/ia64/include/asm/processor.h +1 -1
@@ -719,7 +719,7 @@ enum idle_boot_override {IDLE_NO_OVERRIDE=0, IDLE_HALT, IDLE_FORCE_MWAIT,void default_idle (void ); -#define ia64_platform_is (x) (strcmp(x, platform_name) = 0) +#define ia64_platform_is (x) (strcmp(x, ia64_platform_name) = 0)#endif /* !__ASSEMBLY__ */
arch/ia64/pci/fixup.c +2 -2
@@ -30,8 +30,8 @@ static void __devinit pci_fixup_video(struct pci_dev *pdev)struct pci_bus *bus;u16 config; -if ((strcmp (platform_name,"dig" ) !=0 ) - && (strcmp (platform_name,"hpzx1" ) !=0 )) +if ((strcmp (ia64_platform_name,"dig" ) !=0 ) + && (strcmp (ia64_platform_name,"hpzx1" ) !=0 ))return ;/* Maybe, this machine supports legacy memory map. */
Signature · 1 line
1.7.10
Quoted 2 lines · Fengguang Wu
The macro name is too generic and conflicts with snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors.
Is platform_name particularly special?
Perhaps it's be better to rename all the other
platform_<foo> uses to ia64_platform_<foo>
[]
arch/ia64/include/asm/machvec.h
Quoted 1 line
arch/ia64/include/asm/machvec.h +0
-0
[]
arch/ia64/include/asm/machvec.h extern void machvec_tlb_migrate_finish (struct mm_struct *); · line 126
Quoted 9 lines
arch/ia64/include/asm/machvec.h +1
-1@@ -120,7 +120,7 @@ extern void machvec_tlb_migrate_finish (struct mm_struct *);# ifdef MACHVEC_PLATFORM_HEADER # include MACHVEC_PLATFORM_HEADER # else -# define platform_name ia64_mv.name +# define ia64_platform_name ia64_mv.name# define platform_setup ia64_mv.setup# define platform_cpu_init ia64_mv.cpu_init# define platform_irq_init ia64_mv.irq_init
Maybe something like:
$ git ls-files arch/ia64 | \ xargs sed -r -i 's/\bplatform_([a-z_]+)\b/ia64_platform_\1/g'
PATCH 1/1 ia64: rename platform_* to ia64_platform_*
Quoted 8 lines · Joe Perches
Quoted 2 lines · Fengguang Wu
The macro name is too generic and conflicts with snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors.
Is
platform_nameparticularly special?Perhaps it's be better to rename all the other
platform_<foo> uses to ia64_platform_<foo>
That's good point in general, oh well I just wanted to make the minimal change..
Quoted 16 lines
[]
arch/ia64/include/asm/machvec.h
Quoted 1 line
arch/ia64/include/asm/machvec.h +0
-0[]
arch/ia64/include/asm/machvec.h extern void machvec_tlb_migrate_finish (struct mm_struct *); · line 126
Quoted 9 lines
arch/ia64/include/asm/machvec.h +1
-1@@ -120,7 +120,7 @@ extern void machvec_tlb_migrate_finish (struct mm_struct *);# ifdef MACHVEC_PLATFORM_HEADER # include MACHVEC_PLATFORM_HEADER # else -# define platform_name ia64_mv.name +# define ia64_platform_name ia64_mv.name# define platform_setup ia64_mv.setup# define platform_cpu_init ia64_mv.cpu_init# define platform_irq_init ia64_mv.irq_initMaybe something like:
Quoted 2 lines
$ git ls-files arch/ia64 | \ xargs sed -r -i 's/\bplatform_([a-z_]+)\b/ia64_platform_\1/g'
Thanks! To avoid some undesired changes, I ended up with the below script :)
Thanks,
Fengguang
---
Quoted 1 line
From
a099f447c2718ee9416dbdb24dd18789ebabfc5cMon Sep 17 00:00:00 2001
From: Fengguang Wu <[email protected]>
Date: Wed, 25 Jul 2012 20:24:28 +0800
Subject: [PATCH] ia64: rename platform_* to ia64_platform_*
The macro names are a bit too generic. In particular, platform_name conflicts with snd_soc_dai_link.platform_name, which triggers lots of ALSA build errors.
Generated by script, manual fixed indents and compile tested.
sed -r -i 's/\b(platform_name|platform_pci_fixup|platform_setup|platform_cpu_init|platform_irq_init|platform_send_ipi|platform_timer_interrupt|platform_global_tlb_purge|platform_tlb_migrate_finish|platform_dma_init|platform_dma_get_required_mask|platform_dma_get_ops|platform_irq_to_vector|platform_local_vector_to_irq|platform_pci_get_legacy_mem|platform_pci_legacy_read|platform_pci_legacy_write|platform_inb|platform_inw|platform_inl|platform_outb|platform_outw|platform_outl|platform_mmiowb|platform_readb|platform_readw|platform_readl|platform_readq|platform_readb_relaxed|platform_readw_relaxed|platform_readl_relaxed|platform_readq_relaxed|platform_migrate|platform_setup_msi_irq|platform_teardown_msi_irq|platform_pci_fixup_bus|platform_kernel_launch_event)\b/ia64_\1/g' $(grep -r --files-wit
h-matches '\<platform_' arch/ia64)
--- arch/ia64/include/asm/dma-mapping.h | 10 +- arch/ia64/include/asm/hw_irq.h | 6 +- arch/ia64/include/asm/io.h | 42 ++-- arch/ia64/include/asm/machvec.h | 282 ++++++++++++------------- arch/ia64/include/asm/machvec_dig.h | 4 +- arch/ia64/include/asm/machvec_dig_vtd.h | 6 +- arch/ia64/include/asm/machvec_hpsim.h | 10 +- arch/ia64/include/asm/machvec_hpzx1.h | 6 +- arch/ia64/include/asm/machvec_hpzx1_swiotlb.h | 12 +- arch/ia64/include/asm/machvec_sn2.h | 128 +++++------ arch/ia64/include/asm/machvec_uv.h | 6 +- arch/ia64/include/asm/machvec_xen.h | 10 +- arch/ia64/include/asm/pci.h | 6 +- arch/ia64/include/asm/processor.h | 2 +- arch/ia64/include/asm/switch_to.h | 2 +- arch/ia64/include/asm/tlb.h | 2 +- arch/ia64/kernel/iosapic.c | 6 +- arch/ia64/kernel/irq_ia64.c | 7 +- arch/ia64/kernel/machine_kexec.c | 2 +- arch/ia64/kernel/mca.c | 12 +- arch/ia64/kernel/msi_ia64.c | 8 +- arch/ia64/kernel/sal.c | 2 +- arch/ia64/kernel/setup.c | 4 +- arch/ia64/kernel/smp.c | 10 +- arch/ia64/kernel/smpboot.c | 2 +- arch/ia64/kernel/time.c | 2 +- arch/ia64/mm/discontig.c | 2 +- arch/ia64/mm/init.c | 2 +- arch/ia64/mm/tlb.c | 2 +- arch/ia64/pci/fixup.c | 4 +- arch/ia64/pci/pci.c | 4 +- arch/ia64/sn/kernel/setup.c | 2 +- 32 files changed, 304 insertions(+), 301 deletions(-)
arch/ia64/include/asm/dma-mapping.h +5 -5
@@ -29,7 +29,7 @@ static inline void *dma_alloc_attrs(struct device *dev, size_t size, dma_addr_t *daddr, gfp_t gfp, struct dma_attrs *attrs) { - struct dma_map_ops *ops = platform_dma_get_ops(dev); + const struct dma_map_ops *ops = ia64_platform_dma_get_ops(dev);void *caddr; caddr = ops->alloc (dev, size, daddr, gfp, attrs);
@@ -43,7 +43,7 @@ static inline void dma_free_attrs(struct device *dev, size_t size, void *caddr, dma_addr_t daddr, struct dma_attrs *attrs) { - struct dma_map_ops *ops = platform_dma_get_ops(dev); + const struct dma_map_ops *ops = ia64_platform_dma_get_ops(dev);debug_dma_free_coherent (dev, size, caddr, daddr); ops->free (dev, size, caddr, daddr, attrs); }
@@ -51,19 +51,19 @@ static inline void dma_free_attrs(struct device *dev, size_t size,#define dma_alloc_noncoherent (d, s, h, f) dma_alloc_coherent(d, s, h, f)#define dma_free_noncoherent (d, s, v, h) dma_free_coherent(d, s, v, h) -#define get_dma_ops (dev) platform_dma_get_ops(dev) +#define get_dma_ops (dev) ia64_platform_dma_get_ops(dev)#include <asm-generic/dma-mapping-common.h> static inline int dma_mapping_error (struct device *dev,dma_addr_t daddr) { -struct dma_map_ops *ops =platform_dma_get_ops (dev); +const struct dma_map_ops *ops =ia64_platform_dma_get_ops (dev);return ops->mapping_error (dev, daddr); }static inline int dma_supported (struct device *dev,u64 mask) { -struct dma_map_ops *ops =platform_dma_get_ops (dev); +const struct dma_map_ops *ops =ia64_platform_dma_get_ops (dev);return ops->dma_supported (dev, mask); }
arch/ia64/include/asm/hw_irq.h +3 -3
@@ -145,7 +145,7 @@ static inline void irq_complete_move(unsigned int irq) {}static inline void ia64_native_resend_irq (unsigned int vector) { -platform_send_ipi (smp_processor_id (), vector,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (smp_processor_id (), vector,IA64_IPI_DM_INT ,0 ); }/*
@@ -178,7 +178,7 @@ __ia64_local_vector_to_irq (ia64_vector vec)static inline ia64_vector irq_to_vector (int irq) { -return platform_irq_to_vector (irq); +return ia64_platform_irq_to_vector (irq); }/*
@@ -189,7 +189,7 @@ irq_to_vector (int irq)static inline unsigned int local_vector_to_irq (ia64_vector vec) { -return platform_local_vector_to_irq (vec); +return ia64_platform_local_vector_to_irq (vec); }#endif /* _ASM_IA64_HW_IRQ_H */
arch/ia64/include/asm/io.h +21 -21
90 lines not on this page · raw message
arch/ia64/include/asm/machvec.h +141 -141
337 lines not on this page · raw message
arch/ia64/include/asm/machvec_dig.h +2 -2
@@ -10,7 +10,7 @@ extern ia64_mv_setup_t dig_setup;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "dig" -#define platform_setup dig_setup +#define ia64_platform_name "dig" +#define ia64_platform_setup dig_setup#endif /* _ASM_IA64_MACHVEC_DIG_h */
arch/ia64/include/asm/machvec_dig_vtd.h +3 -3
@@ -11,8 +11,8 @@ extern ia64_mv_dma_init pci_iommu_alloc;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "dig_vtd" -#define platform_setup dig_setup -#define platform_dma_init pci_iommu_alloc +#define ia64_platform_name "dig_vtd" +#define ia64_platform_setup dig_setup +#define ia64_platform_dma_init pci_iommu_alloc#endif /* _ASM_IA64_MACHVEC_DIG_VTD_h */
arch/ia64/include/asm/machvec_hpsim.h +5 -5
@@ -1,8 +1,8 @@#ifndef _ASM_IA64_MACHVEC_HPSIM_h#define _ASM_IA64_MACHVEC_HPSIM_h -extern ia64_mv_setup_t hpsim_setup; -extern ia64_mv_irq_init_t hpsim_irq_init; +extern ia64_mv_setup_t hpsim_setup; +extern ia64_mv_irq_init_t hpsim_irq_init;/* * This stuff has dual use!
@@ -11,8 +11,8 @@ extern ia64_mv_irq_init_t hpsim_irq_init;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "hpsim" -#define platform_setup hpsim_setup -#define platform_irq_init hpsim_irq_init +#define ia64_platform_name "hpsim" +#define ia64_platform_setup hpsim_setup +#define ia64_platform_irq_init hpsim_irq_init#endif /* _ASM_IA64_MACHVEC_HPSIM_h */
arch/ia64/include/asm/machvec_hpzx1.h +3 -3
@@ -11,8 +11,8 @@ extern ia64_mv_dma_init sba_dma_init;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "hpzx1" -#define platform_setup dig_setup -#define platform_dma_init sba_dma_init +#define ia64_platform_name "hpzx1" +#define ia64_platform_setup dig_setup +#define ia64_platform_dma_init sba_dma_init#endif /* _ASM_IA64_MACHVEC_HPZX1_h */
arch/ia64/include/asm/machvec_hpzx1_swiotlb.h +6 -6
@@ -1,8 +1,8 @@#ifndef _ASM_IA64_MACHVEC_HPZX1_SWIOTLB_h#define _ASM_IA64_MACHVEC_HPZX1_SWIOTLB_h -extern ia64_mv_setup_t dig_setup; -extern ia64_mv_dma_get_ops hwsw_dma_get_ops; +extern ia64_mv_setup_t dig_setup; +extern ia64_mv_dma_get_ops hwsw_dma_get_ops;/* * This stuff has dual use!
@@ -11,9 +11,9 @@ extern ia64_mv_dma_get_ops hwsw_dma_get_ops;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "hpzx1_swiotlb" -#define platform_setup dig_setup -#define platform_dma_init machvec_noop -#define platform_dma_get_ops hwsw_dma_get_ops +#define ia64_platform_name "hpzx1_swiotlb" +#define ia64_platform_setup dig_setup +#define ia64_platform_dma_init machvec_noop +#define ia64_platform_dma_get_ops hwsw_dma_get_ops#endif /* _ASM_IA64_MACHVEC_HPZX1_SWIOTLB_h */
arch/ia64/include/asm/machvec_sn2.h +64 -64
144 lines not on this page · raw message
arch/ia64/include/asm/machvec_uv.h +3 -3
@@ -11,7 +11,7 @@#ifndef _ASM_IA64_MACHVEC_UV_H#define _ASM_IA64_MACHVEC_UV_H -extern ia64_mv_setup_t uv_setup; +extern ia64_mv_setup_t uv_setup;/* * This stuff has dual use!
@@ -20,7 +20,7 @@ extern ia64_mv_setup_t uv_setup;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "uv" -#define platform_setup uv_setup +#define ia64_platform_name "uv" +#define ia64_platform_setup uv_setup#endif /* _ASM_IA64_MACHVEC_UV_H */
arch/ia64/include/asm/machvec_xen.h +5 -5
@@ -13,10 +13,10 @@ extern ia64_mv_send_ipi_t xen_platform_send_ipi;* platform's machvec structure. When compiling a non-generic kernel, * the macros are used directly. */ -#define platform_name "xen" -#define platform_setup dig_setup -#define platform_cpu_init xen_cpu_init -#define platform_irq_init xen_irq_init -#define platform_send_ipi xen_platform_send_ipi +#define ia64_platform_name "xen" +#define ia64_platform_setup dig_setup +#define ia64_platform_cpu_init xen_cpu_init +#define ia64_platform_irq_init xen_irq_init +#define ia64_platform_send_ipi xen_platform_send_ipi#endif /* _ASM_IA64_MACHVEC_XEN_h */
arch/ia64/include/asm/pci.h +3 -3
@@ -85,9 +85,9 @@ extern int pci_mmap_legacy_page_range(struct pci_bus *bus,struct vm_area_struct *vma, enum pci_mmap_state mmap_state); -#define pci_get_legacy_mem platform_pci_get_legacy_mem -#define pci_legacy_read platform_pci_legacy_read -#define pci_legacy_write platform_pci_legacy_write +#define pci_get_legacy_mem ia64_platform_pci_get_legacy_mem +#define pci_legacy_read ia64_platform_pci_legacy_read +#define pci_legacy_write ia64_platform_pci_legacy_writestruct pci_window {struct resource resource;
arch/ia64/include/asm/processor.h +1 -1
@@ -719,7 +719,7 @@ enum idle_boot_override {IDLE_NO_OVERRIDE=0, IDLE_HALT, IDLE_FORCE_MWAIT,void default_idle (void ); -#define ia64_platform_is (x) (strcmp(x, platform_name) == 0) +#define ia64_platform_is (x) (strcmp(x, ia64_platform_name) == 0)#endif /* !__ASSEMBLY__ */
arch/ia64/include/asm/switch_to.h +1 -1
@@ -76,7 +76,7 @@ extern void ia64_account_on_switch (struct task_struct *prev, struct task_structif (unlikely ((current->thread.flags &IA64_THREAD_MIGRATION ) && \ (task_cpu (current) != \task_thread_info (current)->last_cpu))) { \ -platform_migrate (current); \ +ia64_platform_migrate (current); \task_thread_info (current)->last_cpu =task_cpu (current); \ } \ }while (0 )
arch/ia64/include/asm/tlb.h +1 -1
@@ -251,7 +251,7 @@ __tlb_remove_tlb_entry (struct mmu_gather *tlb, pte_t *ptep, unsigned long addre tlb->end_addr = address +PAGE_SIZE ; } -#define tlb_migrate_finish (mm) platform_tlb_migrate_finish(mm) +#define tlb_migrate_finish (mm) ia64_platform_tlb_migrate_finish(mm)#define tlb_start_vma (tlb, vma) do { } while (0)#define tlb_end_vma (tlb, vma) do { } while (0)
arch/ia64/kernel/iosapic.c +3 -3
@@ -67,9 +67,9 @@* As an IRQ is a number, we have to have * IA-64 interrupt vector number <-> IRQ number mapping. On smaller * systems, we use one-to-one mapping between IA-64 vector and IRQ. A -* platform can implement platform_irq_to_vector(irq) and -* platform_local_vector_to_irq(vector) APIs to differentiate the mapping. -* Please see also arch/ia64/include/asm/hw_irq.h for those APIs. +* platform can implement ia64_platform_irq_to_vector(irq) and +* ia64_platform_local_vector_to_irq(vector) APIs to differentiate the +* mapping. Please see also arch/ia64/include/asm/hw_irq.h for those APIs. * * To sum up, there are three levels of mappings involved: *
arch/ia64/kernel/irq_ia64.c +4 -3
@@ -53,7 +53,7 @@#define IRQ_USED (1)#define IRQ_RSVD (2) -/* These can be overridden in platform_irq_init */ +/* These can be overridden in ia64_platform_irq_init */ int ia64_first_device_vector =IA64_DEF_FIRST_DEVICE_VECTOR ;int ia64_last_device_vector =IA64_DEF_LAST_DEVICE_VECTOR ;
@@ -324,7 +324,8 @@ void irq_complete_move(unsigned irq)cpumask_and (&cleanup_mask, &cfg->old_domain, cpu_online_mask); cfg->move_cleanup_count =cpus_weight (cleanup_mask);for_each_cpu_mask (i, cleanup_mask) -platform_send_ipi (i,IA64_IRQ_MOVE_VECTOR ,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (i,IA64_IRQ_MOVE_VECTOR , +IA64_IPI_DM_INT ,0 ); cfg->move_in_progress =0 ; }
@@ -665,7 +666,7 @@ init_IRQ (void)#ifdef CONFIG_PERFMON pfm_init_percpu ();#endif -platform_irq_init (); +ia64_platform_irq_init (); }void
arch/ia64/kernel/machine_kexec.c +1 -1
@@ -128,7 +128,7 @@ static void ia64_machine_kexec(struct unw_frame_info *info, void *arg)ia64_srlz_d ();while (ia64_get_ivr () !=IA64_SPURIOUS_INT_VECTOR )ia64_eoi (); -platform_kernel_launch_event (); +ia64_platform_kernel_launch_event (); rnk = (relocate_new_kernel_t)&code_addr; (*rnk)(image->head, image->start, ia64_boot_param,GRANULEROUNDDOWN ((unsigned long ) pal_addr));
arch/ia64/kernel/mca.c +7 -5
@@ -735,7 +735,7 @@ ia64_mca_cmc_vector_enable_keventd(struct work_struct *unused)static void ia64_mca_wakeup (int cpu) { -platform_send_ipi (cpu,IA64_MCA_WAKEUP_VECTOR ,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (cpu,IA64_MCA_WAKEUP_VECTOR ,IA64_IPI_DM_INT ,0 ); }/*
@@ -1481,7 +1481,8 @@ ia64_mca_cmc_int_caller(int cmc_irq, void *arg) cpuid =cpumask_next (cpuid+1 , cpu_online_mask);if (cpuid < nr_cpu_ids) { -platform_send_ipi (cpuid,IA64_CMCP_VECTOR ,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (cpuid,IA64_CMCP_VECTOR , +IA64_IPI_DM_INT ,0 ); }else {/* If no log record, switch out of polling mode */ if (start_count ==IA64_LOG_COUNT (SAL_INFO_TYPE_CMC )) {
@@ -1514,7 +1515,7 @@ static void ia64_mca_cmc_poll (unsigned long dummy) {/* Trigger a CMC interrupt cascade */ -platform_send_ipi (cpumask_first (cpu_online_mask),IA64_CMCP_VECTOR , +ia64_platform_send_ipi (cpumask_first (cpu_online_mask),IA64_CMCP_VECTOR ,IA64_IPI_DM_INT ,0 ); }
@@ -1551,7 +1552,8 @@ ia64_mca_cpe_int_caller(int cpe_irq, void *arg) cpuid =cpumask_next (cpuid+1 , cpu_online_mask);if (cpuid <NR_CPUS ) { -platform_send_ipi (cpuid,IA64_CPEP_VECTOR ,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (cpuid,IA64_CPEP_VECTOR , +IA64_IPI_DM_INT ,0 ); }else {/* * If a log was recorded, increase our polling frequency,
@@ -1591,7 +1593,7 @@ static void ia64_mca_cpe_poll (unsigned long dummy) {/* Trigger a CPE interrupt cascade */ -platform_send_ipi (cpumask_first (cpu_online_mask),IA64_CPEP_VECTOR , +ia64_platform_send_ipi (cpumask_first (cpu_online_mask),IA64_CPEP_VECTOR ,IA64_IPI_DM_INT ,0 ); }
arch/ia64/kernel/msi_ia64.c +4 -4
@@ -117,16 +117,16 @@ static struct irq_chip ia64_msi_chip = {int arch_setup_msi_irq (struct pci_dev *pdev,struct msi_desc *desc) { -if (platform_setup_msi_irq) -return platform_setup_msi_irq (pdev, desc); +if (ia64_platform_setup_msi_irq) +return ia64_platform_setup_msi_irq (pdev, desc);return ia64_setup_msi_irq (pdev, desc); }void arch_teardown_msi_irq (unsigned int irq) { -if (platform_teardown_msi_irq) -return platform_teardown_msi_irq (irq); +if (ia64_platform_teardown_msi_irq) +return ia64_platform_teardown_msi_irq (irq);return ia64_teardown_msi_irq (irq); }
arch/ia64/kernel/sal.c +1 -1
@@ -255,7 +255,7 @@ check_sal_cache_flush (void)* Send ourselves a timer interrupt, wait until it's reported, and see * if SAL_CACHE_FLUSH drops it. */ -platform_send_ipi (cpu,IA64_TIMER_VECTOR ,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (cpu,IA64_TIMER_VECTOR ,IA64_IPI_DM_INT ,0 );while (!ia64_get_irr (IA64_TIMER_VECTOR ))cpu_relax ();
arch/ia64/kernel/setup.c +2 -2
@@ -621,7 +621,7 @@ setup_arch (char **cmdline_p)if (!nomca)ia64_mca_init (); -platform_setup (cmdline_p); +ia64_platform_setup (cmdline_p);#ifndef CONFIG_IA64_HP_SIM check_sal_cache_flush ();#endif
@@ -1050,7 +1050,7 @@ cpu_init (void)ia64_patch_phys_stack_reg (num_phys_stacked*8 +8 ); max_num_phys_stacked = num_phys_stacked; } -platform_cpu_init (); +ia64_platform_cpu_init (); pm_idle = default_idle; }
arch/ia64/kernel/smp.c +5 -5
@@ -145,7 +145,7 @@ static inline void send_IPI_single (int dest_cpu, int op) { set_bit(op, &per_cpu(ipi_operation, dest_cpu)); -platform_send_ipi (dest_cpu,IA64_IPI_VECTOR ,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (dest_cpu,IA64_IPI_VECTOR ,IA64_IPI_DM_INT ,0 ); }/*
@@ -211,8 +211,8 @@ kdump_smp_send_init(void) self_cpu =smp_processor_id ();for_each_online_cpu (cpu) {if (cpu != self_cpu) { -if (kdump_status[cpu] ==0 ) -platform_send_ipi (cpu,0 ,IA64_IPI_DM_INIT ,0 ); +if (kdump_status[cpu] ==0 ) +ia64_platform_send_ipi (cpu,0 ,IA64_IPI_DM_INIT ,0 ); } } }
@@ -223,7 +223,7 @@ kdump_smp_send_init(void)void smp_send_reschedule (int cpu) { -platform_send_ipi (cpu,IA64_IPI_RESCHEDULE ,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (cpu,IA64_IPI_RESCHEDULE ,IA64_IPI_DM_INT ,0 ); }EXPORT_SYMBOL_GPL (smp_send_reschedule);
@@ -233,7 +233,7 @@ EXPORT_SYMBOL_GPL(smp_send_reschedule);static void smp_send_local_flush_tlb (int cpu) { -platform_send_ipi (cpu,IA64_IPI_LOCAL_TLB_FLUSH ,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (cpu,IA64_IPI_LOCAL_TLB_FLUSH ,IA64_IPI_DM_INT ,0 ); }void
arch/ia64/kernel/smpboot.c +1 -1
@@ -474,7 +474,7 @@ do_boot_cpu (int sapicid, int cpu, struct task_struct *idle)Dprintk ("Sending wakeup vector %lu to AP 0x%x/0x%x.\n" , ap_wakeup_vector, cpu, sapicid);set_brendez_area (cpu); -platform_send_ipi (cpu, ap_wakeup_vector,IA64_IPI_DM_INT ,0 ); +ia64_platform_send_ipi (cpu, ap_wakeup_vector,IA64_IPI_DM_INT ,0 );/* * Wait 10s total for the AP to start
arch/ia64/kernel/time.c +1 -1
@@ -167,7 +167,7 @@ timer_interrupt (int irq, void *dev_id)return IRQ_HANDLED ; } -platform_timer_interrupt (irq, dev_id); +ia64_platform_timer_interrupt (irq, dev_id); new_itm = local_cpu_data->itm_next;
arch/ia64/mm/discontig.c +1 -1
@@ -439,7 +439,7 @@ static void __meminit scatter_node_data(void)* Each node's per-node area has a copy of the global pg_data_t list, so * we copy that to each node here, as well as setting the per-cpu pointer * to the local node data structure. The active_cpus field of the per-node -* structure gets setup by the platform_cpu_init() function later. +* structure gets setup by the ia64_platform_cpu_init() function later. */ static void __init initialize_pernode_data (void ) {
arch/ia64/mm/init.c +1 -1
@@ -626,7 +626,7 @@ mem_init (void)* any drivers that may need the PCI DMA interface are initialized or bootmem has * been freed. */ -platform_dma_init (); +ia64_platform_dma_init ();#endif #ifdef CONFIG_FLATMEM
arch/ia64/mm/tlb.c +1 -1
@@ -323,7 +323,7 @@ flush_tlb_range (struct vm_area_struct *vma, unsigned long start,preempt_disable ();#ifdef CONFIG_SMP if (mm != current->active_mm ||cpumask_weight (mm_cpumask (mm)) !=1 ) { -platform_global_tlb_purge (mm, start, end, nbits); +ia64_platform_global_tlb_purge (mm, start, end, nbits);preempt_enable ();return ; }
arch/ia64/pci/fixup.c +2 -2
@@ -30,8 +30,8 @@ static void __devinit pci_fixup_video(struct pci_dev *pdev)struct pci_bus *bus;u16 config; -if ((strcmp (platform_name,"dig" ) !=0 ) - && (strcmp (platform_name,"hpzx1" ) !=0 )) +if ((strcmp (ia64_platform_name,"dig" ) !=0 ) + && (strcmp (ia64_platform_name,"hpzx1" ) !=0 ))return ;/* Maybe, this machine supports legacy memory map. */
arch/ia64/pci/pci.c +2 -2
@@ -453,7 +453,7 @@ pcibios_fixup_bus (struct pci_bus *b) }list_for_each_entry (dev, &b->devices, bus_list)pcibios_fixup_device_resources (dev); -platform_pci_fixup_bus (b); +ia64_platform_pci_fixup_bus (b); }void pcibios_set_master (struct pci_dev *dev)
@@ -723,7 +723,7 @@ EXPORT_SYMBOL_GPL(ia64_dma_get_required_mask);u64 dma_get_required_mask (struct device *dev) { -return platform_dma_get_required_mask (dev); +return ia64_platform_dma_get_required_mask (dev); }EXPORT_SYMBOL_GPL (dma_get_required_mask);
arch/ia64/sn/kernel/setup.c +1 -1
@@ -556,7 +556,7 @@ static void __init sn_init_pdas(char **cmdline_p)* Called during cpu initialization on each cpu as it starts. * Currently, initializes the per-cpu data area for SNIA. * Also sets up a few fields in the nodepda. Also known as -* platform_cpu_init() by the ia64 machvec code. +* ia64_platform_cpu_init() by the ia64 machvec code. */ void __cpuinit sn_cpu_init (void ) {
Signature · 1 line
1.7.10
RE: [PATCH] ia64: rename platform_* to ia64_platform_*
Quoted 1 line
Quoted 1 line
Is
platform_nameparticularly special?
Yes. It is the symbol that is currently colliding with other subsystem namespace.
Quoted 4 lines
Quoted 2 lines
Perhaps it's be better to rename all the other
platform_<foo> uses to ia64_platform_<foo>That's good point in general, oh well I just wanted to make the minimal change..
Following that logic there isn't anything special about symbols starting with "platform" ... and we should hunt down every global symbol in every architecture that is local to the architecture and replace it with $arch_$symbol.
I think I'll just take the minimal patch to fix "platform_name" and continue to use a "fix as problems occur" algorithm to the namespace pollution problem.
-Tony
RE: [PATCH] ia64: rename platform_* to ia64_platform_*
Quoted 7 lines · Tony
Quoted 1 line
Quoted 1 line
Is
platform_nameparticularly special?Yes. It is the symbol that is currently colliding with other subsystem namespace.
Quoted 3 lines
Quoted 2 lines
Perhaps it's be better to rename all the other
platform_<foo> uses to ia64_platform_<foo>
Quoted 8 lines
Quoted 1 line
That's good point in general, oh well I just wanted to make the minimal change..
Following that logic there isn't anything special about symbols starting with "platform" ... and we should hunt down every global symbol in every architecture that is local to the architecture and replace it with $arch_$symbol.
I think I'll just take the minimal patch to fix "
platform_name" and continue to use a "fix as problems occur" algorithm to the namespace pollution problem.
That can lead to a lot of naming inconsistencies.