Skip to contentSkip to conversation

bcma_bus_scan/bcma_bus_scan_early: missing iounmap

DISCUSSION Fengguang Wu 2 participants 2 messages Jul 25, 2012 – Jul 26, 2012

lore
Share & tools
lore
#0 lore raw

Hi Hauke,

The coccinelle static checker emits these warnings:

drivers/bcma/scan.c:466:3-9: ERROR: missing iounmap; ioremap on line 451 and execution via conditional on line 465 drivers/bcma/scan.c:540:3-9: ERROR: missing iounmap; ioremap on line 515 and execution via conditional on line 539

It seems we need to change the return statements to goto/break statements.

Thanks,
Fengguang

#1 lore raw
Quoted 11 lines · Fengguang Wu

Hi Hauke,

The coccinelle static checker emits these warnings:

drivers/bcma/scan.c:466:3-9: ERROR: missing iounmap; ioremap on line 451 and execution via conditional on line 465 drivers/bcma/scan.c:540:3-9: ERROR: missing iounmap; ioremap on line 515 and execution via conditional on line 539

It seems we need to change the return statements to goto/break statements.

Thanks,
Fengguang

Hi Fengguang,

Thanks for the hint on this problem, I just sent a patch to fix this to John Linville and the linux-wireless mailing list.

Hauke