Skip to contentSkip to conversation

Remove unnecessary WARN_ONCE's from tracing_buffers_splice_read

PATCH Dave Jones 1 participant 1 message Jul 25, 2012 Tracing

lore
Share & tools
lore

Dave Jones

author
#0 lore raw

WARN shouldn't be used as a means of communicating failure to a userspace programmer.

kernel/trace/trace.c +0 -2
index ed7b5d1..a745317 100644
@@ -4136,13 +4136,11 @@ tracing_buffers_splice_read(struct file *file, loff_t *ppos,
 		return -ENOMEM;
 
 	if (*ppos & (PAGE_SIZE - 1)) {
-		WARN_ONCE(1, "Ftrace: previous read must page-align\n");
 		ret = -EINVAL;
 		goto out;
 	}
 
 	if (len & (PAGE_SIZE - 1)) {
-		WARN_ONCE(1, "Ftrace: splice_read should page-align\n");
 		if (len < PAGE_SIZE) {
 			ret = -EINVAL;
 			goto out;