KVM: Only print vcpu_unimpl when DEBUG is set
RFC PATCH 1/1 KVM: Only print vcpu_unimpl when DEBUG is set
Every time I start qemu-kvm on my system the following line is added to the syslog:
vcpu0 unhandled rdmsr: 0xc0010001
AFAICS all calls to vcpu_unimpl only contain debugging info with little or no value for the end user.
Wouldn't something like the following patch make sense?
include/linux/kvm_host.h +1 -1
@@ -321,7 +321,7 @@ struct kvm {#define kvm_debug (fmt, ...) \ pr_debug("kvm [%i]: " fmt, task_pid_nr(current), ## __VA_ARGS__)#define kvm_pr_unimpl (fmt, ...) \ - pr_err_ratelimited("kvm [%i]: " fmt, \ + pr_debug_ratelimited("kvm [%i]: " fmt, \ task_tgid_nr(current), ## __VA_ARGS__)/* The guest did something we don't support. */
Signature · 1 line
Markus
Quoted 11 lines · Markus Trippelsdorf
Every time I start qemu-kvm on my system the following line is added to the syslog:
vcpu0 unhandled rdmsr:
0xc0010001AFAICS all calls to
vcpu_unimplonly contain debugging info with little or no value for the end user.Wouldn't something like the following patch make sense?
Signed-off-by Markus Trippelsdorf <[email protected]>
It could be useful for debugging (but then lots of other things could).
Anyone has a use for this?
Quoted 20 lines
include/linux/kvm_host.h +1
-1@@ -321,7 +321,7 @@ struct kvm {#define kvm_debug (fmt, ...) \ pr_debug("kvm [%i]: " fmt, task_pid_nr(current), ## __VA_ARGS__)#define kvm_pr_unimpl (fmt, ...) \ - pr_err_ratelimited("kvm [%i]: " fmt, \ + pr_debug_ratelimited("kvm [%i]: " fmt, \ task_tgid_nr(current), ## __VA_ARGS__)/* The guest did something we don't support. */ Signature · 6 lines
-- Markus -- To unsubscribe from this list: send the line "unsubscribe kvm" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 9 lines · Marcelo Tosatti
Quoted 8 lines · Markus Trippelsdorf
Every time I start qemu-kvm on my system the following line is added to the syslog:
vcpu0 unhandled rdmsr:
0xc0010001AFAICS all calls to
vcpu_unimplonly contain debugging info with little or no value for the end user.
Quoted 7 lines
Quoted 3 lines
Wouldn't something like the following patch make sense?
Signed-off-by Markus Trippelsdorf <[email protected]>It could be useful for debugging (but then lots of other things could).
Anyone has a use for this?
The current scenario is:
<guest breaks>
Maintainer asks for dmesg
If something shows up, it's something to consider
Following this patch, the scenario will be
<guest breaks>
Maintainer: please enable dynamic debug for kvm and reproduce If something shows up, it's something to consider
I guess with dynamic debug it's acceptable, we just need to make sure that it doesn't spew tons of other stuff.
Signature · 1 line
error compiling committee.c: too many arguments to function