Skip to contentSkip to conversation

NVMe: Fix nvme module init when nvme_major is set

PATCH New Keith Busch 2 participants 2 messages Jul 25, 2012 – Jul 26, 2012

Subsystems (2)
Block layer NVMe
lore
Share & tools
lore

Keith Busch

author
#0 lore raw

PATCH 1/1 NVMe: Fix nvme module init when nvme_major is set

register_blkdev returns 0 when given a valid major number.

Reported-by Ross Zwisler <ross.zwisler at intel.com>
Signed-off-by Keith Busch <keith.busch at intel.com>
---
 drivers/block/nvme.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)
drivers/block/nvme.c +4 -2
index 38b9c73..46e33ee 100644
@@ -1716,9 +1716,11 @@ static int __init nvme_init(void)
 	if (IS_ERR(nvme_thread))
 		return PTR_ERR(nvme_thread);
 
-	nvme_major = register_blkdev(nvme_major, "nvme");
-	if (nvme_major <= 0)
+	result = register_blkdev(nvme_major, "nvme");
+	if (result < 0)
 		goto kill_kthread;
+	else if (result > 0)
+	    nvme_major = result;
 
 	result = pci_register_driver(&nvme_driver);
 	if (result)
Signature · 1 line
1.7.0.4
Applied
#1 lore raw

PATCH 1/1 NVMe: Fix nvme module init when nvme_major is set

Quoted 1 line · Keith Busch

register_blkdev returns 0 when given a valid major number.

Thanks, applied.