Skip to contentSkip to conversation

net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types i

PATCH In review Fengguang Wu 2 participants 2 messages Jul 29, 2012 – Jul 30, 2012 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 2/2 net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types i

Hi Pablo,

There are new sparse warnings show up in

tree:   git://150.214.188.80/nf-next nf_tables4
head:   b33538d5361ec09e5c947765a7615fc67640a9fe
commit: b33538d5361ec09e5c947765a7615fc67640a9fe [2/2] netfilter: nf_tables

All sparse warnings:

+ net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types in comparison expression (different address spaces)

vim +184 net/ipv4/netfilter/nf_table_nat_ipv4.c
181 enum nf_nat_manip_type maniptype = HOOK2MANIP(ops->hooknum);
182 unsigned int ret;
183

Quoted 1 line

184 if (ct = NULL || ct = &nf_conntrack_untracked)

185 return NF_ACCEPT;
186
187 NF_CT_ASSERT(!(ip_hdr(skb)->frag_off & htons(IP_MF | IP_OFFSET)));

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#1 lore raw

Re: [nf-next:nf_tables4 2/2] net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible typ

Quoted 8 lines · Fengguang Wu

Hi Pablo,

There are new sparse warnings show up in

tree:   git://150.214.188.80/nf-next nf_tables4
head:   b33538d5361ec09e5c947765a7615fc67640a9fe
commit: b33538d5361ec09e5c947765a7615fc67640a9fe [2/2] netfilter: nf_tables
Quoted 9 lines

All sparse warnings:

+ net/ipv4/netfilter/nf_table_nat_ipv4.c:184:30: sparse: incompatible types in comparison expression (different address spaces)

vim +184 net/ipv4/netfilter/nf_table_nat_ipv4.c

   181		enum nf_nat_manip_type maniptype = HOOK2MANIP(ops->hooknum);
   182		unsigned int ret;
   183	
Quoted 1 line

184 if (ct = NULL || ct = &nf_conntrack_untracked)

should be fixed now in nf_tables5 branch. Now we use nf_ct_is_untracked(ct) instead of the reference to the global untracked conntrack object.