hawkboard: Fix SPL Nand driver misconfiguration
PATCH 1/1 hawkboard: Fix SPL Nand driver misconfiguration
Hawkboard was using the wrong nand_read_page version for SPL image. As a side effect, the u-boot image loaded by the SPL from nand was getting corrupted.
Enable CONFIG_SYS_NAND_HW_ECC_OOBFIRST to select the correct nand_read_page algorithm for SPL.
--- include/configs/hawkboard.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/hawkboard.h +1 -0
@@ -123,6 +123,7 @@#define CONFIG_SYS_NAND_USE_FLASH_BBT #define CONFIG_NAND_DAVINCI #define CONFIG_SYS_NAND_4BIT_HW_ECC_OOBFIRST +#define CONFIG_SYS_NAND_HW_ECC_OOBFIRST /* SPL nand driver configuration */ #define CFG_DAVINCI_STD_NAND_LAYOUT #define CONFIG_SYS_NAND_CS 3#define CONFIG_SYS_NAND_PAGE_2K
Signature · 1 line
1.7.1
PATCH 1/1 hawkboard: Fix SPL Nand driver misconfiguration
Quoted 8 lines · Linu Cherian
Hawkboard was using the wrong
nand_read_pageversion for SPL image. As a side effect, the u-boot image loaded by the SPL from nand was getting corrupted.Enable
CONFIG_SYS_NAND_HW_ECC_OOBFIRSTto select the correctnand_read_pagealgorithm for SPL.Signed-off-by Linu Cherian <[email protected]>
Tom, since this is a bug fix, can this go to the 2012.07 release.
-sughosh
PATCH 1/1 hawkboard: Fix SPL Nand driver misconfiguration
hi Wolfgang,
Quoted 5 lines · Sughosh Ganu
Quoted 4 lines · Linu Cherian
Hawkboard was using the wrong
nand_read_pageversion for SPL image. As a side effect, the u-boot image loaded by the SPL from nand was getting corrupted.
Quoted 8 lines
Quoted 4 lines
Enable
CONFIG_SYS_NAND_HW_ECC_OOBFIRSTto select the correctnand_read_pagealgorithm for SPL.Signed-off-by Linu Cherian <[email protected]>Acked-by Sughosh Ganu <[email protected]>Tom, since this is a bug fix, can this go to the 2012.07 release.
Did not get any response from Tom, so if it's not too late, can this patch be applied to the master for the 2012.07 release. It is a bugfix.
-sughosh
PATCH 1/1 hawkboard: Fix SPL Nand driver misconfiguration
In reply to Sughosh GanuQuoted 5 lines · Sughosh Ganu
Quoted 4 lines · Linu Cherian
Hawkboard was using the wrong
nand_read_pageversion for SPL image. As a side effect, the u-boot image loaded by the SPL from nand was getting corrupted.
Quoted 8 lines
Quoted 4 lines
Enable
CONFIG_SYS_NAND_HW_ECC_OOBFIRSTto select the correctnand_read_pagealgorithm for SPL.Signed-off-by Linu Cherian <[email protected]>Acked-by Sughosh Ganu <[email protected]>Tom, since this is a bug fix, can this go to the 2012.07 release.
Wolfgang, please take this for the release, thanks!
Signature · 8 lines
Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120730/71141df4/attachment.pgp>
Wolfgang Denk
AppliedPATCH 1/1 hawkboard: Fix SPL Nand driver misconfiguration
In reply to Linu CherianDear Linu Cherian,
Quoted 11 lines · In message <[email protected]> you wrote:
Hawkboard was using the wrong
nand_read_pageversion for SPL image. As a side effect, the u-boot image loaded by the SPL from nand was getting corrupted.Enable
CONFIG_SYS_NAND_HW_ECC_OOBFIRSTto select the correctnand_read_pagealgorithm for SPL.Signed-off-by Linu Cherian <[email protected]>--- include/configs/hawkboard.h | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
Signature · 6 lines
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de On the subject of C program indentation: "In My Egotistical Opinion, most people's C programs should be indented six feet downward and covered with dirt." - Blair P. Houghton