isdnloop: fix and simplify isdnloop_init()
Subsystems (2)
PATCH 1/1 isdnloop: fix and simplify isdnloop_init()
Remove the non-sense isdnloop revision transform code, so as to fix:
[ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 [ 22.097508] isdnloop: (loop0) virtual card added [ 22.174400] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: ffffffff83244972 [ 22.174400] [ 22.436157] Pid: 1, comm: swapper Not tainted 3.5.0-bisect-00018-gfa8bbb1-dirty #129 [ 22.624071] Call Trace: [ 22.720558] [<ffffffff832448c3>] ? CallcNew+0x56/0x56 [ 22.815248] [<ffffffff8222b623>] panic+0x110/0x329 [ 22.914330] [<ffffffff83244972>] ? isdnloop_init+0xaf/0xb1 [ 23.014800] [<ffffffff832448c3>] ? CallcNew+0x56/0x56 [ 23.090763] [<ffffffff8108e24b>] __stack_chk_fail+0x2b/0x30 [ 23.185748] [<ffffffff83244972>] isdnloop_init+0xaf/0xb1
Signed-off-by Fengguang Wu <[email protected]>
--- drivers/isdn/isdnloop/isdnloop.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)
drivers/isdn/isdnloop/isdnloop.c +2 -11
@@ -16,7 +16,7 @@#include <linux/sched.h> #include "isdnloop.h" -static char *revision ="$Revision: 1.11.6.7 $" ; +static char *revision ="1.11.6.7" ;static char *isdnloop_id ="loop0" ;MODULE_DESCRIPTION ("ISDN4Linux: Pseudo Driver that simulates an ISDN card" );
@@ -1494,16 +1494,7 @@ isdnloop_addcard(char *id1)static int __init isdnloop_init (void ) { -char *p; -char rev[10 ]; - -if ((p =strchr (revision,':' ))) { -strcpy (rev, p +1 ); - p =strchr (rev,'$' ); - *p =0 ; - }else -strcpy (rev," ??? " ); -printk (KERN_NOTICE "isdnloop-ISDN-driver Rev%s\n" , rev); +printk (KERN_NOTICE "isdnloop-ISDN-driver Rev %s\n" , revision);if (isdnloop_id)return (isdnloop_addcard (isdnloop_id));
Quoted 15 lines · Fengguang Wu
Remove the non-sense isdnloop revision transform code, so as to fix:
[ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 [ 22.097508] isdnloop: (loop0) virtual card added [ 22.174400] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: ffffffff83244972 [ 22.174400] [ 22.436157] Pid: 1, comm: swapper Not tainted 3.5.0-bisect-00018-gfa8bbb1-dirty #129 [ 22.624071] Call Trace: [ 22.720558] [<ffffffff832448c3>] ? CallcNew+0x56/0x56 [ 22.815248] [<ffffffff8222b623>] panic+0x110/0x329 [ 22.914330] [<ffffffff83244972>] ? isdnloop_init+0xaf/0xb1 [ 23.014800] [<ffffffff832448c3>] ? CallcNew+0x56/0x56 [ 23.090763] [<ffffffff8108e24b>] __stack_chk_fail+0x2b/0x30 [ 23.185748] [<ffffffff83244972>] isdnloop_init+0xaf/0xb1
Quoted 4 lines
Signed-off-by Fengguang Wu <[email protected]>--- drivers/isdn/isdnloop/isdnloop.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)
Please use scripts/get_maintainer.pl to send this to the correct people (hint, you got one address right, lkml, but that was it.)
greg k-h
[Add more CC]
Quoted 49 lines · Fengguang Wu
Remove the non-sense isdnloop revision transform code, so as to fix:
[ 22.016214] isdnloop-ISDN-driver Rev 1.11.6.7 [ 22.097508] isdnloop: (loop0) virtual card added [ 22.174400] Kernel panic - not syncing: stack-protector: Kernel stack is corrupted in: ffffffff83244972 [ 22.174400] [ 22.436157] Pid: 1, comm: swapper Not tainted 3.5.0-bisect-00018-gfa8bbb1-dirty #129 [ 22.624071] Call Trace: [ 22.720558] [<ffffffff832448c3>] ? CallcNew+0x56/0x56 [ 22.815248] [<ffffffff8222b623>] panic+0x110/0x329 [ 22.914330] [<ffffffff83244972>] ? isdnloop_init+0xaf/0xb1 [ 23.014800] [<ffffffff832448c3>] ? CallcNew+0x56/0x56 [ 23.090763] [<ffffffff8108e24b>] __stack_chk_fail+0x2b/0x30 [ 23.185748] [<ffffffff83244972>] isdnloop_init+0xaf/0xb1Signed-off-by Fengguang Wu <[email protected]>--- drivers/isdn/isdnloop/isdnloop.c | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-)drivers/isdn/isdnloop/isdnloop.c +2
-11@@ -16,7 +16,7 @@#include <linux/sched.h> #include "isdnloop.h" -static char *revision ="$Revision: 1.11.6.7 $" ; +static char *revision ="1.11.6.7" ;static char *isdnloop_id ="loop0" ;MODULE_DESCRIPTION ("ISDN4Linux: Pseudo Driver that simulates an ISDN card" );@@ -1494,16 +1494,7 @@ isdnloop_addcard(char *id1)static int __init isdnloop_init (void ) { -char *p; -char rev[10 ]; - -if ((p =strchr (revision,':' ))) { -strcpy (rev, p +1 ); - p =strchr (rev,'$' ); - *p =0 ; - }else -strcpy (rev," ??? " ); -printk (KERN_NOTICE "isdnloop-ISDN-driver Rev%s\n" , rev); +printk (KERN_NOTICE "isdnloop-ISDN-driver Rev %s\n" , revision);if (isdnloop_id)return (isdnloop_addcard (isdnloop_id));
Quoted 1 line · Fengguang Wu
[Add more CC]
That's not going to do much, you just sent them a patch they can't apply without editing by hand :(
Quoted 2 lines · Fengguang Wu
[Add more CC]
That's not helpful... Resend the patch to netdev in a way that applies.
regards,
dan carpenter
Quoted 6 lines · Dan Carpenter
Quoted 2 lines · Fengguang Wu
[Add more CC]
That's not helpful... Resend the patch to netdev in a way that applies.
OK, sorry...