at91: Add support for taskit AT91SAM9G20 boards.
Subsystems (2)
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
This adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
--- board/taskit/stamp9g20/Makefile | 52 ++++++++ board/taskit/stamp9g20/stamp9g20.c | 199 +++++++++++++++++++++++++++++++ boards.cfg | 2 + include/configs/stamp9g20.h | 225 ++++++++++++++++++++++++++++++++++++ 4 files changed, 478 insertions(+), 0 deletions(-) create mode 100644 board/taskit/stamp9g20/Makefile create mode 100644 board/taskit/stamp9g20/stamp9g20.c create mode 100644 include/configs/stamp9g20.h
board/taskit/stamp9g20/Makefile new file +52 -0
@@ -0,0 +1,52 @@ +# +# (C) Copyright 2003-2008 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# (C) Copyright 2008 +# Stelian Pop <[email protected]> +# Lead Tech Design <www.leadtechdesign.com> +# +# (C) Copyright 2012 +# Markus Hubig <[email protected]> +# IMKO GmbH <www.imko.de> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).o + +COBJS-y += stamp9g20.o + +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) + +######################################################################### + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +#########################################################################
board/taskit/stamp9g20/stamp9g20.c new file +199 -0
199 lines not on this page · raw message
boards.cfg +2 -0
@@ -120,6 +120,8 @@ cpu9G20_nand_128M arm arm926ejs cpu9260 eukrea pm9261 arm arm926ejs pm9261 ronetix at91 pm9261:AT91SAM9261 pm9263 arm arm926ejs pm9263 ronetix at91 pm9263:AT91SAM9263 pm9g45 arm arm926ejs pm9g45 ronetix at91 pm9g45:AT91SAM9G45 +portuxg20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20,CONFIG_PORTUXG20 +stamp9g20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20 cam_enc_4xx arm arm926ejs cam_enc_4xx ait davinci cam_enc_4xx da830evm arm arm926ejs da8xxevm davinci davinci da850_am18xxevm arm arm926ejs da8xxevm davinci davinci da850evm:DA850_AM18X_EVM,MAC_ADDR_IN_EEPROM,SYS_I2C_EEPROM_ADDR_LEN=2,SYS_I2C_EEPROM_ADDR=0x50
include/configs/stamp9g20.h new file +225 -0
225 lines not on this page · raw message
Signature · 1 line
1.7.7
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Dear Markus Hubig,
first of all:
---8<---
andreas@andreas-mbp % ./tools/checkpatch.pl U-Boot-at91-Add-support-for-taskit-AT91SAM9G20-boards..patch
WARNING: Whitespace before semicolon
#214: FILE: board/taskit/stamp9g20/stamp9g20.c:123:
+ ;
total: 0 errors, 1 warnings, 484 lines checked
NOTE: Ignored message types: COMPLEX_MACRO CONSIDER_KSTRTO MINMAX MULTISTATEMENT_MACRO_USE_DO_WHILE
U-Boot-at91-Add-support-for-taskit-AT91SAM9G20-boards..patch has style problems, please review.
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. --->8---
I know this part is copied from other at91 boards but I wonder how we should handle these while-loops without content.
Quoted 11 lines · Markus Hubig
This adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
Signed-off-by Markus Hubig <[email protected]>Cc Andreas Bie?mann <[email protected]>--- board/taskit/stamp9g20/Makefile | 52 ++++++++ board/taskit/stamp9g20/stamp9g20.c | 199 +++++++++++++++++++++++++++++++ boards.cfg | 2 + include/configs/stamp9g20.h | 225 ++++++++++++++++++++++++++++++++++++
MAINTAINER entry is missing
Quoted 148 lines
4 files changed, 478 insertions(+), 0 deletions(-) create mode 100644 board/taskit/stamp9g20/Makefile create mode 100644 board/taskit/stamp9g20/stamp9g20.c create mode 100644 include/configs/stamp9g20.hboard/taskit/stamp9g20/Makefile new file +52
-0@@ -0,0 +1,52 @@ +# +# (C) Copyright 2003-2008 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# (C) Copyright 2008 +# Stelian Pop <[email protected]> +# Lead Tech Design <www.leadtechdesign.com> +# +# (C) Copyright 2012 +# Markus Hubig <[email protected]> +# IMKO GmbH <www.imko.de> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).o + +COBJS-y += stamp9g20.o + +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) + +######################################################################### + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +#########################################################################board/taskit/stamp9g20/stamp9g20.c new file +79
-0@@ -0,0 +1,199 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* +* Achim Ehrlich <[email protected]> +* taskit GmbH <www.taskit.de> +* +* (C) Copyright 2012- +* Markus Hubig <[email protected]> +* IMKO GmbH <www.imko.de> +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#include <common.h> +#include <asm/io.h> +#include <asm/arch/at91sam9260_matrix.h> +#include <asm/arch/at91sam9_smc.h> +#include <asm/arch/at91_common.h> +#include <asm/arch/at91_pmc.h> +#include <asm/arch/at91_rstc.h> +#include <asm/arch/gpio.h> + +#ifdef CONFIG_MACB +# include <net.h> +# include <netdev.h> +#endif /* CONFIG_MACB */ + +DECLARE_GLOBAL_DATA_PTR ; + +static void stamp9G20_nand_hw_init (void ) +{ +struct at91_smc *smc = (struct at91_smc *)ATMEL_BASE_SMC ; +struct at91_matrix *matrix = (struct at91_matrix *)ATMEL_BASE_MATRIX ; +unsigned long csa; + +/* Assign CS3 to NAND/SmartMedia Interface */ + csa =readl (&matrix->ebicsa); + csa |=AT91_MATRIX_CS3A_SMC_SMARTMEDIA ; +writel (csa, &matrix->ebicsa); + +/* Configure SMC CS3 for NAND/SmartMedia */ +writel (AT91_SMC_SETUP_NWE (1 ) |AT91_SMC_SETUP_NCS_WR (0 ) | +AT91_SMC_SETUP_NRD (1 ) |AT91_SMC_SETUP_NCS_RD (0 ), + &smc->cs[3 ].setup); +writel (AT91_SMC_PULSE_NWE (3 ) |AT91_SMC_PULSE_NCS_WR (3 ) | +AT91_SMC_PULSE_NRD (3 ) |AT91_SMC_PULSE_NCS_RD (3 ), + &smc->cs[3 ].pulse); +writel (AT91_SMC_CYCLE_NWE (5 ) |AT91_SMC_CYCLE_NRD (5 ), + &smc->cs[3 ].cycle); +writel (AT91_SMC_MODE_RM_NRD |AT91_SMC_MODE_WM_NWE | +AT91_SMC_MODE_EXNW_DISABLE | +AT91_SMC_MODE_DBW_8 | +AT91_SMC_MODE_TDF_CYCLE (2 ), + &smc->cs[3 ].mode); + +/* Configure RDY/BSY */ +at91_set_gpio_input (CONFIG_SYS_NAND_READY_PIN ,1 ); + +/* Enable NandFlash */ +at91_set_gpio_output (CONFIG_SYS_NAND_ENABLE_PIN ,1 ); +}
board/taskit/stamp9g20/stamp9g20.c line 89
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c new file +10
-0+ +#ifdef CONFIG_MACB +static void stamp9G20_macb_hw_init (void ) +{ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ; +struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA ; +struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC ; +unsigned long erstl; + +/* Enable MACB Chip, this is the enable PIN on Stamp Adaptor*/
This comment is a bit misleading. Isn't MACB the SoC MAC component? Why should we switch an external element to enable an internal part? Can you please rewrite the comment to be more precise?
board/taskit/stamp9g20/stamp9g20.c line 93
Quoted 4 lines
board/taskit/stamp9g20/stamp9g20.c new file +4
-0+at91_set_gpio_output (AT91_PIN_PA26 ,0 ); + +/* Enable EMAC clock */ +writel (1 <<ATMEL_ID_EMAC0 , &pmc->pcer);
Is it possible to move this 'enable clock' into at91_macb_hw_init()? Does your PHY address setting still work then?
If yes, can you please send a separate patch first adding the 'enable clock' into the correct at91_macb_hw_init()?
Quoted 14 lines
board/taskit/stamp9g20/stamp9g20.c new file +14
-0+ +/* +* Disable pull-up on: +* RXDV (PA17) => PHY normal mode (not Test mode) +* ERX0 (PA14) => PHY ADDR0 +* ERX1 (PA15) => PHY ADDR1 +* ERX2 (PA25) => PHY ADDR2 +* ERX3 (PA26) => PHY ADDR3 +* ECRS (PA28) => PHY ADDR4 => PHYADDR = 0x0 +* +* PHY has internal pull-down +*/ + writel(pin_to_mask(AT91_PIN_PA14) | + pin_to_mask(AT91_PIN_PA15) |
board/taskit/stamp9g20/stamp9g20.c line 117
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c new file +10
-0+pin_to_mask (AT91_PIN_PA17 ) | +pin_to_mask (AT91_PIN_PA18 ) | +pin_to_mask (AT91_PIN_PA28 ), + &pioa->pudr); + + erstl =readl (&rstc->mr) &AT91_RSTC_MR_ERSTL_MASK ; + +/* Need to reset PHY -> 500ms reset */ +writel (AT91_RSTC_KEY |AT91_RSTC_MR_ERSTL (13 ) | +AT91_RSTC_MR_URSTEN , &rstc->mr);
Hmm ... is it OK to generate the user reset here? I know this is the same in at least at91sam9263ek, can you please check if we should instead delete that bit in MR?
board/taskit/stamp9g20/stamp9g20.c line 123
Quoted 6 lines
board/taskit/stamp9g20/stamp9g20.c new file +6
-0+ +writel (AT91_RSTC_KEY |AT91_RSTC_CR_EXTRST , &rstc->cr); + +/* Wait for end hardware reset */ +while (!(readl (&rstc->sr) &AT91_RSTC_SR_NRSTL )) + ;
Endless loop if bit is not toggling, can you please add some watchdog reset (if you still use wdt in your board) and some timeout? This will also solve the warning detected by checkpatch.
Quoted 15 lines
board/taskit/stamp9g20/stamp9g20.c new file +15
-0+ +/* Restore NRST value */ +writel (AT91_RSTC_KEY | erstl |AT91_RSTC_MR_URSTEN , + &rstc->mr); + +/* Re-enable pull-up */ +writel (pin_to_mask (AT91_PIN_PA14 ) | +pin_to_mask (AT91_PIN_PA15 ) | +pin_to_mask (AT91_PIN_PA17 ) | +pin_to_mask (AT91_PIN_PA18 ) | +pin_to_mask (AT91_PIN_PA28 ), + &pioa->puer); + +/* Initialize EMAC=MACB hardware */ +at91_macb_hw_init ();
board/taskit/stamp9g20/stamp9g20.c line 148
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c new file +10
-0+} +#endif /* CONFIG_MACB */ + +int board_early_init_f (void ) +{ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ; + +/* Enable clocks for all PIOs */ +writel ((1 <<ATMEL_ID_PIOA ) | (1 <<ATMEL_ID_PIOB ) | + (1 <<ATMEL_ID_PIOC ), &pmc->pcer);
you should initialize seriald_hw here to avoid strange characters on serial line when switching from at91bootstrap to u-boot.
board/taskit/stamp9g20/stamp9g20.c line 159
Quoted 11 lines
board/taskit/stamp9g20/stamp9g20.c new file +11
-0+ +return 0 ; +} + +int board_init (void ) +{ +#ifdef CONFIG_PORTUXG20 + gd->bd->bi_arch_number =MACH_TYPE_PORTUXG20 ; +#else + gd->bd->bi_arch_number =MACH_TYPE_STAMP9G20 ; +#endif
I would favor the generic CONFIG_MACH_TYPE here -> see arch/arm/lib/board.c:401
Just add the definition in your board config header and remove these lines here.
board/taskit/stamp9g20/stamp9g20.c line 164
Quoted 5 lines
board/taskit/stamp9g20/stamp9g20.c new file +5
-0+/* adress of boot parameters */ + gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE +0x100 ; + +at91_set_gpio_output (AT91_PIN_PC9 ,1 ); +at91_set_gpio_output (AT91_PIN_PC5 ,1 );
Can you please add some comment why switching these pins?
Quoted 16 lines
board/taskit/stamp9g20/stamp9g20.c new file +16
-0+ +at91_seriald_hw_init (); +stamp9G20_nand_hw_init (); +#ifdef CONFIG_MACB +stamp9G20_macb_hw_init (); +#endif + +return 0 ; +} + +int dram_init (void ) +{ + gd->ram_size =get_ram_size ( + (void *)CONFIG_SYS_SDRAM_BASE , +CONFIG_SYS_SDRAM_SIZE ); +return 0 ;
board/taskit/stamp9g20/stamp9g20.c line 190
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c new file +10
-0+} + +#ifdef CONFIG_MACB +void reset_phy (void ) +{ +/* +* Initialize ethernet HW addr prior to starting Linux, +* needed for nfsroot +*/ +eth_init (gd->bd);
This is not longer required, the HW address should always be set by generic code. Can you please check this?
board/taskit/stamp9g20/stamp9g20.c line 197
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c new file +7
-0+} + +int board_eth_init (bd_t *bis) +{ +int rc =0 ; + rc =macb_eth_initialize (0 , (void *)ATMEL_BASE_EMAC0 ,0x00 ); +return rc;
return macb_eth_initialize()?
Quoted 69 lines
board/taskit/stamp9g20/stamp9g20.c new file +2
-0+} +#endif /* CONFIG_MACB */ boards.cfg +2
-0@@ -120,6 +120,8 @@ cpu9G20_nand_128M arm arm926ejs cpu9260 eukrea pm9261 arm arm926ejs pm9261 ronetix at91 pm9261:AT91SAM9261 pm9263 arm arm926ejs pm9263 ronetix at91 pm9263:AT91SAM9263 pm9g45 arm arm926ejs pm9g45 ronetix at91 pm9g45:AT91SAM9G45 +portuxg20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20,CONFIG_PORTUXG20 +stamp9g20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20 cam_enc_4xx arm arm926ejs cam_enc_4xx ait davinci cam_enc_4xx da830evm arm arm926ejs da8xxevm davinci davinci da850_am18xxevm arm arm926ejs da8xxevm davinci davinci da850evm:DA850_AM18X_EVM,MAC_ADDR_IN_EEPROM,SYS_I2C_EEPROM_ADDR_LEN=2,SYS_I2C_EEPROM_ADDR=0x50include/configs/stamp9g20.h new file +48
-0@@ -0,0 +1,225 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* +* (C) Copyright 2010 +* Achim Ehrlich <[email protected]> +* taskit GmbH <www.taskit.de> +* +* (C) Copyright 2012 +* Markus Hubig <[email protected]> +* IMKO GmbH <www.imko.de> +* +* Configuation settings for the stamp9g20 CPU module. +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#ifndef __CONFIG_H +#define __CONFIG_H + +/* +* SoC must be defined first, before hardware.h is included. +* In this case SoC is defined in boards.cfg. +*/ +#include <asm/hardware.h> + +/* +* Warning: changing CONFIG_SYS_TEXT_BASE requires adapting the initial boot +* program. Since the linker has to swallow that define, we must use a pure +* hex number here! +*/
include/configs/stamp9g20.h line 58
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+#define CONFIG_SYS_TEXT_BASE 0x23f00000 + +/* ARM asynchronous clock */ +#define CONFIG_SYS_AT91_SLOW_CLOCK 32768/* slow clock xtal */ +#define CONFIG_SYS_AT91_MAIN_CLOCK 18432000/* 18.432MHz crystal */ +#define CONFIG_SYS_HZ 1000/* 1ms resolution */ + +/* Misc CPU related settings */ +#define CONFIG_ARCH_CPU_INIT /* call arch_cpu_init() */ +#undef CONFIG_USE_IRQ/* we don't need IRQ stuff */
just remove that, it was not defined before
Quoted 22 lines
include/configs/stamp9g20.h new file +22
-0+#define CONFIG_CMDLINE_TAG /* pass commandline to Kernel */ +#define CONFIG_SETUP_MEMORY_TAGS /* pass memory defs to kernel */ +#define CONFIG_INITRD_TAG /* pass initrd param to kernel */ +#define CONFIG_SKIP_LOWLEVEL_INIT /* U-Boot is loaded by a bootloader */ +#define CONFIG_BOARD_EARLY_INIT_f/* call board_early_init_f() */ +#define CONFIG_DISPLAY_CPUINFO /* display CPU Info at startup */ + +/* +* SDRAM: 1 bank, 64 MB, base address 0x20000000 +* Already initialized before u-boot gets started. +*/ +#define CONFIG_NR_DRAM_BANKS 1 +#define CONFIG_SYS_SDRAM_BASE ATMEL_BASE_CS1 +#define CONFIG_SYS_SDRAM_SIZE (64 * (1024 << 10)) + +/* +* Perform a SDRAM Memtest from the start of SDRAM +* till the beginning of the U-Boot position in RAM. +*/ +#define CONFIG_SYS_MEMTEST_START CONFIG_SYS_SDRAM_BASE +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_TEXT_BASE - 0x100000) +
include/configs/stamp9g20.h line 90
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN \ + ROUND(3 * CONFIG_ENV_SIZE + 128 * 1024, 0x1000) + +/* +* Initial stack pointer: 4k - GENERATED_GBL_DATA_SIZE in internal SRAM, +* leaving the correct space for initial global data structure above that +* address while providing maximum stack area below. +*/ +#define CONFIG_STACKSIZE (32 * 1024)/* 32k regular stack size */
CONFIG_STACKSIZE is nowhere used, please remove.
Quoted 13 lines
include/configs/stamp9g20.h new file +13
-0+#define CONFIG_SYS_INIT_SP_ADDR \ + (ATMEL_BASE_SRAM1 + 0x1000 - GENERATED_GBL_DATA_SIZE) + +/* NAND flash settings */ +#define CONFIG_NAND_ATMEL +#define CONFIG_SYS_NO_FLASH +#define CONFIG_SYS_MAX_NAND_DEVICE 1 +#define CONFIG_SYS_NAND_BASE ATMEL_BASE_CS3 +#define CONFIG_SYS_NAND_DBW_8 +#define CONFIG_SYS_NAND_MASK_ALE (1 << 21) +#define CONFIG_SYS_NAND_MASK_CLE (1 << 22) +#define CONFIG_SYS_NAND_ENABLE_PIN AT91_PIN_PC14 +#define CONFIG_SYS_NAND_READY_PIN AT91_PIN_PC13
include/configs/stamp9g20.h line 113
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+ +/* general purpose I/O */ +#define CONFIG_ATMEL_LEGACY /* required until (g)pio is fixed */ +#define CONFIG_AT91_GPIO /* enable the GPIO features */ +#define CONFIG_AT91_GPIO_PULLUP 1/* keep pullups on peripheral pins */ + +/* serial console */ +#define CONFIG_ATMEL_USART +#define CONFIG_USART_BASE ATMEL_BASE_DBGU +#define CONFIG_USART_ID ATMEL_ID_SYS
-----------^
no tab here please
include/configs/stamp9g20.h line 115
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+#define CONFIG_BAUDRATE 115200 +#define CONFIG_SYS_BAUDRATE_TABLE {115200, 19200, 38400, 57600, 9600}
This is same as generic table, please remove (was added in 26750c8aee2383a026e0cf89e9310628d3a5a6a0)
include/configs/stamp9g20.h line 116
Quoted 1 line
include/configs/stamp9g20.h new file +1
-0+#define CONFIG_USART3 /* USART 3 is used as DBGU */
Well, this is a remnant ... please remove (BTW: the statement in comment is wrong, USART3 is available beside DBGU ... ;)
include/configs/stamp9g20.h line 119
Quoted 3 lines
include/configs/stamp9g20.h new file +3
-0+ +/* Ethernet configuration */ +#define CONFIG_MACB /* initialize the ethernet port */
------------------------------------------------------------------------^ Can you please remove these white space? I know there are a lot of at91 config header formatted like this, but I personally dislike this style. Especially in this case where the previous intention of aligning all these '*/' on the 80th char of a line is still broken by other lines. I think just a single white space is good here.
include/configs/stamp9g20.h line 121
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+ +#ifdef CONFIG_MACB
Well, you defined it some lines above, is there any case where you want to switch the network off? If no please remove this ifdef block and just define required stuff.
include/configs/stamp9g20.h line 123
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+# define CONFIG_RMII /* use reduced MII inteface */ +# define CONFIG_RESET_PHY_R /* call reset_phy() after reloc. */
I think this could be remove once you checked if eth_init() is really required.
Quoted 5 lines
include/configs/stamp9g20.h new file +5
-0+# define CONFIG_NET_RETRY_COUNT 20/* # of DHCP/BOOTP retries */ +#endif /* CONFIG_MACB */ + +/* USB configuration */ +#define CONFIG_USB_ATMEL
include/configs/stamp9g20.h line 138
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+#define CONFIG_USB_OHCI_NEW +#define CONFIG_USB_STORAGE +#define CONFIG_DOS_PARTITION +#define CONFIG_SYS_USB_OHCI_CPU_INIT +#define CONFIG_SYS_USB_OHCI_REGS_BASE ATMEL_UHP_BASE +#define CONFIG_SYS_USB_OHCI_SLOT_NAME "at91sam9260" +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 + +/* BOOTP options */ +#ifdef CONFIG_MACB
same comment as above, if you do not want to disable MACB, remove this ifdef.
Quoted 21 lines
include/configs/stamp9g20.h new file +21
-0+# define CONFIG_BOOTP_BOOTFILESIZE +# define CONFIG_BOOTP_BOOTPATH +# define CONFIG_BOOTP_GATEWAY +# define CONFIG_BOOTP_HOSTNAME +#endif /* CONFIG_MACB */ + +/* General Boot Parameter */ +#define CONFIG_BOOTDELAY 3 +#define CONFIG_BOOTCOMMAND "run flashboot" +#define CONFIG_SYS_PROMPT "U-Boot> " +#define CONFIG_SYS_CBSIZE 256 +#define CONFIG_SYS_MAXARGS 16 +#define CONFIG_SYS_PBSIZE \ + (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) +#define CONFIG_SYS_LONGHELP +#define CONFIG_CMDLINE_EDITING + +/* +* RAM Memory address where to put the +* Linux Kernel bevor starting. +*/
include/configs/stamp9g20.h line 169
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+#define CONFIG_SYS_LOAD_ADDR 0x22000000 + +/* +* The NAND Flash partitions: +* ========================================== +* 0x0000000-0x001ffff -> 128k, bootstrap +* 0x0020000-0x005ffff -> 256k, u-boot +* 0x0060000-0x007ffff -> 128k, env1 +* 0x0080000-0x009ffff -> 128k, env2 (backup) +* 0x0100000-0x03fffff -> 2M, kernel
You should think about bad blocks ... 2MiB for kernel is IMHO way to small for normal configurations (especially when you care about boot time, think about io-/cpu-bound stuff: high compression vs fast access). The space will be even smaller if you hit some bad blocks in this area ... I really recommend to use a bit more here for your kernel, but its up to you whether you change it in your next patch version or not.
Quoted 4 lines
include/configs/stamp9g20.h new file +4
-0+* 0x0400000-0x8000000 -> 124M, RootFS +*/ +#define CONFIG_ENV_IS_IN_NAND +#define CONFIG_ENV_OFFSET (128 + 256 << 10)
include/configs/stamp9g20.h line 183
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+#define CONFIG_ENV_OFFSET_REDUND (128 + 256 + 128 << 10) +#define CONFIG_ENV_SIZE (128 << 10) + +/* +* Predefined environment variables. +* Usefull to define some easy to use boot commands. +*/ +#define CONFIG_EXTRA_ENV_SETTINGS \ + \ + "basicargs=console=ttyS0,115200 mem=64M\0" \
Only a side note ... isn't the mem parameter handled by ATAGS correctly? Or why do you add this here?
include/configs/stamp9g20.h line 190
Quoted 7 lines
include/configs/stamp9g20.h new file +7
-0+ \ +"mtdparts=mtdparts=atmel_nand:128k(bootstrap)ro," \ +"256k(uboot)ro,128k(env1)ro," \ +"128k(env2)ro,2M(linux),-(root)rw\0" \ + \ +"sdboot=setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/mmcblk0p1 rootdelay=1; " \
another side note ... you should read about rootwait in kernel docs
include/configs/stamp9g20.h line 195
Quoted 5 lines
include/configs/stamp9g20.h new file +5
-0+"nand read 0x22000000 0xA0000 0x200000; " \ +"bootm 22000000\0" \ + \ +"flashboot=setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/mtdblock5 rootfstype=jffs2; " \
another side note ... you should read about ubifs ;)
Don't get me wrong, these side notes are just for you information and not a request for change!
Quoted 5 lines
include/configs/stamp9g20.h new file +5
-0+"nand read 0x22000000 0xA0000 0x200000; " \ +"bootm 22000000\0" \ + \ +"nfsboot=setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/nfs ip=dhcp " \
include/configs/stamp9g20.h line 210
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+"nfsroot=${serverip}:/srv/nfs/rootfs; dhcp; " \ +"bootm\0" + +/* Command line & features configuration */ +#include <config_cmd_default.h> +#undef CONFIG_CMD_FPGA +#undef CONFIG_CMD_IMI +#undef CONFIG_CMD_IMLS +#undef CONFIG_CMD_LOADS +#undef CONFIG_CMD_SOURCE
The source command is a really useful command for scripting, you should not disable it except you need to e.g. save space in text section. I guess this not the case for you cause it saves just about 700 bytes in code section.
Beside that I can not see another way for updating your device. You disabled flash access to bootstrap, u-boot and env sections in mtdparts so you will need u-boot to write to these sections or you need to change these parameters in u-boot. For all these cases scripting in u-boot is really viable. Think about ... (just another side note ;)
include/configs/stamp9g20.h line 216
Quoted 6 lines
include/configs/stamp9g20.h new file +6
-0+ +#define CONFIG_CMD_NAND +#define CONFIG_CMD_USB +#define CONFIG_CMD_FAT + +#ifdef CONFIG_MACB
again ifdef block, see comments above
include/configs/stamp9g20.h line 223
Quoted 7 lines
include/configs/stamp9g20.h new file +7
-0+# define CONFIG_CMD_PING +# define CONFIG_CMD_DHCP +#endif /* CONFIG_MACB */ + +#ifdef CONFIG_USE_IRQ +# error CONFIG_USE_IRQ not supported +#endif
I tend to say, remove that. I can not imagine a case where one enables irq accidentially, this should only be done intentionally. Then this part is not really useful.
But I know this is copied from other at91 config files.
include/configs/stamp9g20.h line 225
Quoted 3 lines
include/configs/stamp9g20.h new file +2
-0+ +#endif
Best regards
Andreas Bie?mann
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Hello Andreas,
thanks for your responce. I will provide an updated patch based on your comments!
Quoted 15 lines · Andreas Bie?mann
---8<---
andreas at andreas-mbp %./tools/checkpatch.plU-Boot-at91-Add-support-for-taskit-AT91SAM9G20-boards..patch
WARNING: Whitespace before semicolon
#214: FILE:board/taskit/stamp9g20/stamp9g20.c:123:board/taskit/stamp9g20/stamp9g20.c new file +1
-0+ ;total: 0 errors, 1 warnings, 484 lines checked
NOTE: Ignored message types:
COMPLEX_MACROCONSIDER_KSTRTOMINMAXMULTISTATEMENT_MACRO_USE_DO_WHILEU-Boot-at91-Add-support-for-taskit-AT91SAM9G20-boards..patch has style problems, please review.
Quoted 6 lines
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in
MAINTAINERS. --->8---I know this part is copied from other at91 boards but I wonder how we should handle these while-loops without content.
Oh I didn't recognice there is a version of checkpatch provided with u-boot. I used the one from kernel.org which didn't put a warning out for this one ...
Quoted 13 lines · Markus Hubig
Quoted 11 lines
This adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
Signed-off-by Markus Hubig <[email protected]>Cc Andreas Bie?mann <[email protected]>--- board/taskit/stamp9g20/Makefile | 52 ++++++++ board/taskit/stamp9g20/stamp9g20.c | 199 +++++++++++++++++++++++++++++++ boards.cfg | 2 + include/configs/stamp9g20.h | 225 ++++++++++++++++++++++++++++++++++++
Quoted 1 line
MAINTAINER entry is missing
Fixed!
Quoted 4 lines
Quoted 4 lines
board/taskit/stamp9g20/stamp9g20.c new file +4
-0+#ifdef CONFIG_MACB +static void stamp9G20_macb_hw_init (void ) +{ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ;
Quoted 8 lines
board/taskit/stamp9g20/stamp9g20.c line 89
Quoted 5 lines
board/taskit/stamp9g20/stamp9g20.c new file +5
-0+struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA ; +struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC ; +unsigned long erstl; + +/* Enable MACB Chip, this is the enable PIN on Stamp Adaptor*/ This comment is a bit misleading. Isn't MACB the SoC MAC component? Why should we switch an external element to enable an internal part? Can you please rewrite the comment to be more precise?
Hmm yes you're right. That pin enables the PHY Chip which of course is an external component ...
Quoted 9 lines
board/taskit/stamp9g20/stamp9g20.c line 93
Quoted 4 lines
board/taskit/stamp9g20/stamp9g20.c new file +4
-0+at91_set_gpio_output (AT91_PIN_PA26 ,0 ); + +/* Enable EMAC clock */ +writel (1 <<ATMEL_ID_EMAC0 , &pmc->pcer);Is it possible to move this 'enable clock' into
at91_macb_hw_init()? Does your PHY address setting still work then?
If yes, can you please send a separate patch first adding the 'enable clock' into the correctat91_macb_hw_init()?
Yes it works. I put it into arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c and will send a separate patch.
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c line 117
Quoted 3 lines
board/taskit/stamp9g20/stamp9g20.c new file +3
-0+/* Need to reset PHY -> 500ms reset */ +writel (AT91_RSTC_KEY |AT91_RSTC_MR_ERSTL (13 ) | +AT91_RSTC_MR_URSTEN , &rstc->mr);Hmm ... is it OK to generate the user reset here? I know this is the same in at least at91sam9263ek, can you please check if we should instead delete that bit in MR?
MR? Sorry I don't get this one. Please explain a bit ...
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c line 123
Quoted 6 lines
board/taskit/stamp9g20/stamp9g20.c new file +6
-0+ +writel (AT91_RSTC_KEY |AT91_RSTC_CR_EXTRST , &rstc->cr); + +/* Wait for end hardware reset */ +while (!(readl (&rstc->sr) &AT91_RSTC_SR_NRSTL )) + ;Endless loop if bit is not toggling, can you please add some watchdog reset (if you still use wdt in your board) and some timeout? This will also solve the warning detected by checkpatch.
Maybe something like this?
| /* Wait for end of hardware reset */
| while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL))
| {
| /* avoid shutdown by watchdog */
| hw_watchdog_reset();
|
| mdelay(10);
| timeout--;
|
| /* timeout for not getting stuck in an endless loop */
| if (timeout <= 0) {
| debug("ERROR: Timeout waiting for PHY reset!\n");
| break;
| };
| };Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c line 148
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c new file +7
-0+int board_early_init_f (void ) +{ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ; + +/* Enable clocks for all PIOs */ +writel ((1 <<ATMEL_ID_PIOA ) | (1 <<ATMEL_ID_PIOB ) | + (1 <<ATMEL_ID_PIOC ), &pmc->pcer);you should initialize
seriald_hwhere to avoid strange characters on serial line when switching from at91bootstrap to u-boot.
If I do so I don't get serial output any more ;-(
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c line 159
Quoted 5 lines
board/taskit/stamp9g20/stamp9g20.c new file +5
-0+#ifdef CONFIG_PORTUXG20 + gd->bd->bi_arch_number =MACH_TYPE_PORTUXG20 ; +#else + gd->bd->bi_arch_number =MACH_TYPE_STAMP9G20 ; +#endif I would favor the generic
CONFIG_MACH_TYPEhere -> seearch/arm/lib/board.c:401
Just add the definition in your board config header and remove these lines here.
Fixed!
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c line 164
Quoted 5 lines
board/taskit/stamp9g20/stamp9g20.c new file +5
-0+/* adress of boot parameters */ + gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE +0x100 ; + +at91_set_gpio_output (AT91_PIN_PC9 ,1 ); +at91_set_gpio_output (AT91_PIN_PC5 ,1 );Can you please add some comment why switching these pins?
I which I could! My documentation is not detailed enough to figure it out. But I will write an email to taskit ...
AT91_PIN_PC9 is connected to TIOB0/NCS5/CFS1 AT91_PIN_PC5 is connected to A24/SPI1_NPCS1 (maybe the red LED)
Quoted 11 lines
board/taskit/stamp9g20/stamp9g20.c line 190
Quoted 8 lines
board/taskit/stamp9g20/stamp9g20.c new file +8
-0+#ifdef CONFIG_MACB +void reset_phy (void ) +{ +/* +* Initialize ethernet HW addr prior to starting Linux, +* needed for nfsroot +*/ +eth_init (gd->bd);This is not longer required, the HW address should always be set by generic code. Can you please check this?
Fixed!
Quoted 9 lines
board/taskit/stamp9g20/stamp9g20.c line 197
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c new file +7
-0+} + +int board_eth_init (bd_t *bis) +{ +int rc =0 ; + rc =macb_eth_initialize (0 , (void *)ATMEL_BASE_EMAC0 ,0x00 ); +return rc;return
macb_eth_initialize()?
Jup!
Quoted 5 lines
include/configs/stamp9g20.h line 58
Quoted 3 lines
include/configs/stamp9g20.h new file +3
-0+/* Misc CPU related settings */ +#define CONFIG_ARCH_CPU_INIT /* call arch_cpu_init() */ +#undef CONFIG_USE_IRQ/* we don't need IRQ stuff */ just remove that, it was not defined before
Fixed!
Quoted 8 lines
include/configs/stamp9g20.h line 90
Quoted 6 lines
include/configs/stamp9g20.h new file +6
-0+/* +* Initial stack pointer: 4k - GENERATED_GBL_DATA_SIZE in internal SRAM, +* leaving the correct space for initial global data structure above that +* address while providing maximum stack area below. +*/ +#define CONFIG_STACKSIZE (32 * 1024)/* 32k regular stack size */
CONFIG_STACKSIZEis nowhere used, please remove.
Fixed!
Quoted 3 lines
Quoted 1 line
+#define
CONFIG_USART_IDATMEL_ID_SYS-----------^
no tab here please
Fixed!
Quoted 5 lines
include/configs/stamp9g20.h line 115
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+#define CONFIG_BAUDRATE 115200 +#define CONFIG_SYS_BAUDRATE_TABLE {115200, 19200, 38400, 57600, 9600}This is same as generic table, please remove (was added in
26750c8aee2383a026e0cf89e9310628d3a5a6a0)
Fixed!
Quoted 3 lines
Quoted 1 line
+#define
CONFIG_USART3/* USART 3 is used as DBGU */Well, this is a remnant ... please remove (BTW: the statement in comment is wrong, USART3 is available beside DBGU ... ;)
Fixed!
Quoted 9 lines
include/configs/stamp9g20.h line 119
Quoted 3 lines
include/configs/stamp9g20.h new file +3
-0+ +/* Ethernet configuration */ +#define CONFIG_MACB /* initialize the ethernet port */ ------------------------------------------------------------------------^ Can you please remove these white space? I know there are a lot of at91 config header formatted like this, but I personally dislike this style. Especially in this case where the previous intention of aligning all these '*/' on the 80th char of a line is still broken by other lines. I think just a single white space is good here.
Formating source code with tabs is already broken by default! You can never get it right ... ;-( If I look at it with my vim all is well formated ...
Fixed ...
Quoted 5 lines
Quoted 1 line
+#ifdef
CONFIG_MACBWell, you defined it some lines above, is there any case where you want to switch the network off? If no please remove this ifdef block and just define required stuff.
I thought about making it easy to disable the eth feature if one is not using it with the stamp9g20 CPU Board ... but anyway you're right!
Quoted 4 lines
include/configs/stamp9g20.h line 123
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+# define CONFIG_RMII /* use reduced MII inteface */ +# define CONFIG_RESET_PHY_R /* call reset_phy() after reloc. */ I think this could be remove once you checked if
eth_init()is really required.
It's gone ...
Quoted 5 lines
include/configs/stamp9g20.h line 138
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+/* BOOTP options */ +#ifdef CONFIG_MACB same comment as above, if you do not want to disable MACB, remove this ifdef.
Fixed!
Quoted 8 lines
Quoted 7 lines
+ * The NAND Flash partitions:
+ * ==========================================
+ * 0x0000000-0x001ffff -> 128k, bootstrap
+ * 0x0020000-0x005ffff -> 256k, u-boot
+ * 0x0060000-0x007ffff -> 128k, env1
+ * 0x0080000-0x009ffff -> 128k, env2 (backup)
+ * 0x0100000-0x03fffff -> 2M, kernel
Quoted 6 lines
You should think about bad blocks ... 2MiB for kernel is IMHO way to small for normal configurations (especially when you care about boot time, think about io-/cpu-bound stuff: high compression vs fast access). The space will be even smaller if you hit some bad blocks in this area ... I really recommend to use a bit more here for your kernel, but its up to you whether you change it in your next patch version or not.
Increased it to 6Mb ...
Quoted 4 lines
include/configs/stamp9g20.h line 183
Quoted 1 line
include/configs/stamp9g20.h new file +1
-0+"basicargs=console=ttyS0,115200 mem=64M\0" \Only a side note ... isn't the mem parameter handled by ATAGS correctly? Or why do you add this here?
Fixed!
Quoted 4 lines
include/configs/stamp9g20.h line 190
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+"sdboot=setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/mmcblk0p1 rootdelay=1; " \another side note ... you should read about rootwait in kernel docs
Fixed ;-)
Quoted 6 lines
include/configs/stamp9g20.h line 195
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+"flashboot=setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/mtdblock5 rootfstype=jffs2; " \another side note ... you should read about ubifs ;)
Don't get me wrong, these side notes are just for you information and not a request for change!
Keep on writing side notes! I learned a lot the last couple of hours ;-)
Quoted 11 lines
Quoted 1 line
+#undef
CONFIG_CMD_SOURCEThe source command is a really useful command for scripting, you should not disable it except you need to e.g. save space in text section. I guess this not the case for you cause it saves just about 700 bytes in code section.
Beside that I can not see another way for updating your device. You disabled flash access to bootstrap, u-boot and env sections in mtdparts so you will need u-boot to write to these sections or you need to change these parameters in u-boot. For all these cases scripting in u-boot is really viable. Think about ... (just another side note ;)
Yes I definitly have to think about a deployment scenario and than this will be really useful. But i just overlooked it until now ...
Quoted 8 lines
include/configs/stamp9g20.h line 223
Quoted 3 lines
include/configs/stamp9g20.h new file +3
-0+#ifdef CONFIG_USE_IRQ +# error CONFIG_USE_IRQ not supported +#endif I tend to say, remove that. I can not imagine a case where one enables irq accidentially, this should only be done intentionally. Then this part is not really useful.
But I know this is copied from other at91 config files.
It's gone! :-)
Thank you very much for this good review! I Learned a lot and will post the updated patches soon!
Cheers, Markus
PS.: I will send a new patch with all your requested changes already included, not a couple of small ones based in this one? Right!?
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Hi Markus,
Quoted 86 lines · Markus Hubig
Hello Andreas,
thanks for your responce. I will provide an updated patch based on your comments!
Quoted 15 lines · Andreas Bie?mann
---8<---
andreas at andreas-mbp %./tools/checkpatch.plU-Boot-at91-Add-support-for-taskit-AT91SAM9G20-boards..patch
WARNING: Whitespace before semicolon
#214: FILE:board/taskit/stamp9g20/stamp9g20.c:123:board/taskit/stamp9g20/stamp9g20.c new file +1
-0+ ;total: 0 errors, 1 warnings, 484 lines checked
NOTE: Ignored message types:
COMPLEX_MACROCONSIDER_KSTRTOMINMAXMULTISTATEMENT_MACRO_USE_DO_WHILEU-Boot-at91-Add-support-for-taskit-AT91SAM9G20-boards..patch has style problems, please review.
Quoted 6 lines
If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in
MAINTAINERS. --->8---I know this part is copied from other at91 boards but I wonder how we should handle these while-loops without content.
Oh I didn't recognice there is a version of checkpatch provided with u-boot. I used the one from kernel.org which didn't put a warning out for this one ...
Quoted 13 lines · Markus Hubig
Quoted 11 lines
This adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
Signed-off-by Markus Hubig <[email protected]>Cc Andreas Bie?mann <[email protected]>--- board/taskit/stamp9g20/Makefile | 52 ++++++++ board/taskit/stamp9g20/stamp9g20.c | 199 +++++++++++++++++++++++++++++++ boards.cfg | 2 + include/configs/stamp9g20.h | 225 ++++++++++++++++++++++++++++++++++++Quoted 1 line
MAINTAINER entry is missing
Fixed!
Quoted 4 lines
Quoted 4 lines
board/taskit/stamp9g20/stamp9g20.c new file +4
-0+#ifdef CONFIG_MACB +static void stamp9G20_macb_hw_init (void ) +{ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ;Quoted 8 lines
board/taskit/stamp9g20/stamp9g20.c line 89
Quoted 5 lines
board/taskit/stamp9g20/stamp9g20.c new file +5
-0+struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA ; +struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC ; +unsigned long erstl; + +/* Enable MACB Chip, this is the enable PIN on Stamp Adaptor*/ This comment is a bit misleading. Isn't MACB the SoC MAC component? Why should we switch an external element to enable an internal part? Can you please rewrite the comment to be more precise?
Hmm yes you're right. That pin enables the PHY Chip which of course is an external component ...
Quoted 9 lines
board/taskit/stamp9g20/stamp9g20.c line 93
Quoted 4 lines
board/taskit/stamp9g20/stamp9g20.c new file +4
-0+at91_set_gpio_output (AT91_PIN_PA26 ,0 ); + +/* Enable EMAC clock */ +writel (1 <<ATMEL_ID_EMAC0 , &pmc->pcer);Is it possible to move this 'enable clock' into
at91_macb_hw_init()? Does your PHY address setting still work then?
If yes, can you please send a separate patch first adding the 'enable clock' into the correctat91_macb_hw_init()?Yes it works. I put it into
arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.cand will send a separate patch.Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c line 117
Quoted 3 lines
board/taskit/stamp9g20/stamp9g20.c new file +3
-0+/* Need to reset PHY -> 500ms reset */ +writel (AT91_RSTC_KEY |AT91_RSTC_MR_ERSTL (13 ) | +AT91_RSTC_MR_URSTEN , &rstc->mr);Hmm ... is it OK to generate the user reset here? I know this is the same in at least at91sam9263ek, can you please check if we should instead delete that bit in MR?
Quoted 1 line
MR? Sorry I don't get this one. Please explain a bit ...
I talked about URSTEN bit in RSTC_MR (Reset Controller Mode Register; p99 in at91sam9g20 datasheet). The URSTEN bit set to 1 means disable low level detection on NRST pin. Which in fact disables external reset with the reset key. One have to check if this is true or maybe I'm wrong here.
Quoted 11 lines
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c line 123
Quoted 6 lines
board/taskit/stamp9g20/stamp9g20.c new file +6
-0+ +writel (AT91_RSTC_KEY |AT91_RSTC_CR_EXTRST , &rstc->cr); + +/* Wait for end hardware reset */ +while (!(readl (&rstc->sr) &AT91_RSTC_SR_NRSTL )) + ;Endless loop if bit is not toggling, can you please add some watchdog reset (if you still use wdt in your board) and some timeout? This will also solve the warning detected by checkpatch.
Quoted 8 lines
Maybe something like this?
| /* Wait for end of hardware reset */ | while (!(readl(&rstc->sr) & AT91_RSTC_SR_NRSTL)) | { | /* avoid shutdown by watchdog */ | hw_watchdog_reset();
WATCHDOG_RESET();
Quoted 7 lines
|
| mdelay(10);
| timeout--;
|
| /* timeout for not getting stuck in an endless loop */
| if (timeout <= 0) {
| debug("ERROR: Timeout waiting for PHY reset!\n");Error messages should not use debug macro.
Quoted 3 lines
| break; | }; | };
For timeout stuff you could also use get_timer(0) to get current timestamp and compare against another timestamp.
<snip>
Quoted 3 lines
PS.: I will send a new patch with all your requested changes already included, not a couple of small ones based in this one? Right!?
Yes, just a new version (v2), it is still arrived, will have a look then.
Best regards
Andreas Bie?mann
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Quoted 10 lines · Andreas Bie?mann
Quoted 9 lines · Markus Hubig
Quoted 7 lines · Andreas Bie?mann
board/taskit/stamp9g20/stamp9g20.c line 117
Quoted 3 lines
board/taskit/stamp9g20/stamp9g20.c new file +3
-0+/* Need to reset PHY -> 500ms reset */ +writel (AT91_RSTC_KEY |AT91_RSTC_MR_ERSTL (13 ) | +AT91_RSTC_MR_URSTEN , &rstc->mr);Hmm ... is it OK to generate the user reset here? I know this is the same in at least at91sam9263ek, can you please check if we should instead delete that bit in MR?
Quoted 6 lines
Quoted 1 line
MR? Sorry I don't get this one. Please explain a bit ...
I talked about URSTEN bit in
RSTC_MR(Reset Controller Mode Register; p99 in at91sam9g20 datasheet). The URSTEN bit set to 1 means disable low level detection on NRST pin. Which in fact disables external reset with the reset key. One have to check if this is true or maybe I'm wrong here.
Hmm ok I'll investigate this a bit further ...
Quoted 4 lines
Quoted 2 lines
| /* avoid shutdown by watchdog */
|hw_watchdog_reset();WATCHDOG_RESET();
Fixed!
Quoted 4 lines
Quoted 2 lines
| if (timeout <= 0) {
|debug("ERROR: Timeout waiting for PHY reset!\n");Error messages should not use debug macro.
Fixed!
Quoted 2 lines
For timeout stuff you could also use
get_timer(0)to get current timestamp and compare against another timestamp.
Fixed!
Cheers, Markus
PATCH v3 1/1 at91: Add support for taskit AT91SAM9G20 boards.
This adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
--- MAINTAINERS | 16 ++- board/taskit/stamp9g20/Makefile | 52 ++++++++ board/taskit/stamp9g20/stamp9g20.c | 196 ++++++++++++++++++++++++++++++ boards.cfg | 2 + include/configs/stamp9g20.h | 235 ++++++++++++++++++++++++++++++++++++ 5 files changed, 495 insertions(+), 6 deletions(-) create mode 100644 board/taskit/stamp9g20/Makefile create mode 100644 board/taskit/stamp9g20/stamp9g20.c create mode 100644 include/configs/stamp9g20.h
MAINTAINERS +10 -6
@@ -243,12 +243,6 @@ Klaus Heydeck <[email protected]> KUP4K MPC855 KUP4X MPC859 -Ilko Iliev <[email protected]> - - PM9261 AT91SAM9261 - PM9263 AT91SAM9263 - PM9G45 ARM926EJS (AT91SAM9G45 SoC) - Gary Jennejohn <[email protected]> quad100hd PPC405EP
@@ -681,10 +675,20 @@ Vaibhav Hiremath <[email protected]> am3517_evm ARM ARMV7 (AM35x SoC) +Markus Hubig <[email protected]> + + STAMP9G20 ARM926EJS + Grazvydas Ignotas <[email protected]> omap3_pandora ARM ARMV7 (OMAP3xx SoC) +Ilko Iliev <[email protected]> + + PM9261 AT91SAM9261 + PM9263 AT91SAM9263 + PM9G45 ARM926EJS (AT91SAM9G45 SoC) + Michael Jones <[email protected]> omap3_mvblx ARM ARMV7 (OMAP3xx SoC)
board/taskit/stamp9g20/Makefile new file +52 -0
52 lines not on this page · raw message
board/taskit/stamp9g20/stamp9g20.c new file +196 -0
196 lines not on this page · raw message
boards.cfg +2 -0
@@ -120,6 +120,8 @@ cpu9G20_nand_128M arm arm926ejs cpu9260 eukrea pm9261 arm arm926ejs pm9261 ronetix at91 pm9261:AT91SAM9261 pm9263 arm arm926ejs pm9263 ronetix at91 pm9263:AT91SAM9263 pm9g45 arm arm926ejs pm9g45 ronetix at91 pm9g45:AT91SAM9G45 +portuxg20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20,PORTUXG20 +stamp9g20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20 cam_enc_4xx arm arm926ejs cam_enc_4xx ait davinci cam_enc_4xx da830evm arm arm926ejs da8xxevm davinci davinci da850_am18xxevm arm arm926ejs da8xxevm davinci davinci da850evm:DA850_AM18X_EVM,MAC_ADDR_IN_EEPROM,SYS_I2C_EEPROM_ADDR_LEN=2,SYS_I2C_EEPROM_ADDR=0x50
include/configs/stamp9g20.h new file +235 -0
235 lines not on this page · raw message
Signature · 1 line
1.7.7
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
In reply to Markus HubigQuoted 11 lines · Markus Hubig
Quoted 10 lines · Andreas Bie?mann
Quoted 9 lines · Markus Hubig
Quoted 7 lines · Andreas Bie?mann
board/taskit/stamp9g20/stamp9g20.c line 117
Quoted 3 lines
board/taskit/stamp9g20/stamp9g20.c new file +3
-0+/* Need to reset PHY -> 500ms reset */ +writel (AT91_RSTC_KEY |AT91_RSTC_MR_ERSTL (13 ) | +AT91_RSTC_MR_URSTEN , &rstc->mr);Hmm ... is it OK to generate the user reset here? I know this is the same in at least at91sam9263ek, can you please check if we should instead delete that bit in MR?
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
MR? Sorry I don't get this one. Please explain a bit ...
I talked about URSTEN bit in
RSTC_MR(Reset Controller Mode Register; p99 in at91sam9g20 datasheet). The URSTEN bit set to 1 means disable low level detection on NRST pin. Which in fact disables external reset with the reset key. One have to check if this is true or maybe I'm wrong here.Hmm ok I'll investigate this a bit further ...
OK I looked this up in the at91sam9g20 datasheet, but as fahr as I understand it, setting AT91_RSTC_MR_URSTEN enables the *detection* of a low level on NRST to trigger USER RESET, while in order to perform the PHY Reset, NRST just hast to get low. To get NRST low, one has to set EXTRST in RSTC_CR.
So to perform a PHY Reset, the correct code should be:
| /* Reset PHY for 500ms */ | writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | & ~AT91_RSTC_MR_URSTEN, &rstc->mr); | writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr);
I tested it with my PortuxG20 and Network is still working!
Unfortunatlie the Portux has no reset button, but I think for all at91sam9g20 boards with a reset button the AT91_RSTC_MR_URSTEN has to be high by default, so somewhere in arch/arm/cpu/arm926ejs/at91/ there has to be some code like this:
|#ifdef CONFIG_AT91_RESET_BUTTON |struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC; |writel(AT91_RSTC_KEY | AT91_RSTC_MR_URSTEN, &rstc->mr); |#endif
Cheers, Markus
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Dear Markus Hubig,
Quoted 19 lines · Markus Hubig
Quoted 18 lines · Markus Hubig
Quoted 16 lines · Andreas Bie?mann
Quoted 10 lines · Markus Hubig
Quoted 7 lines · Andreas Bie?mann
board/taskit/stamp9g20/stamp9g20.c line 117
Quoted 3 lines
board/taskit/stamp9g20/stamp9g20.c new file +3
-0+/* Need to reset PHY -> 500ms reset */ +writel (AT91_RSTC_KEY |AT91_RSTC_MR_ERSTL (13 ) | +AT91_RSTC_MR_URSTEN , &rstc->mr);Hmm ... is it OK to generate the user reset here? I know this is the same in at least at91sam9263ek, can you please check if we should instead delete that bit in MR?
MR? Sorry I don't get this one. Please explain a bit ...
I talked about URSTEN bit in
RSTC_MR(Reset Controller Mode Register; p99 in at91sam9g20 datasheet). The URSTEN bit set to 1 means disable low level detection on NRST pin. Which in fact disables external reset with the reset key. One have to check if this is true or maybe I'm wrong here.
Quoted 6 lines
Quoted 1 line
Hmm ok I'll investigate this a bit further ...
OK I looked this up in the at91sam9g20 datasheet, but as fahr as I understand it, setting
AT91_RSTC_MR_URSTENenables the *detection* of a low level on NRST to trigger USER RESET, while in order to perform the PHY Reset, NRST just hast to get low. To get NRST low, one has to set EXTRST inRSTC_CR.
correct.
Quoted 15 lines
So to perform a PHY Reset, the correct code should be:
| /* Reset PHY for 500ms */ | writel(AT91_RSTC_KEY | AT91_RSTC_MR_ERSTL(13) | & ~AT91_RSTC_MR_URSTEN, &rstc->mr); | writel(AT91_RSTC_KEY | AT91_RSTC_CR_EXTRST, &rstc->cr);I tested it with my PortuxG20 and Network is still working!
Unfortunatlie the Portux has no reset button, but I think for all at91sam9g20 boards with a reset button the
AT91_RSTC_MR_URSTENhas to be high by default, so somewhere inarch/arm/cpu/arm926ejs/at91/there has to be some code like this:
Quoted 4 lines
|#ifdef CONFIG_AT91_RESET_BUTTON |struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC; |writel(AT91_RSTC_KEY | AT91_RSTC_MR_URSTEN, &rstc->mr); |#endif
Well, I think it is up to the board maintainer to verify the reset switch is working.
Best regards
Andreas Bie?mann
PATCH 1/1 Enable the EMAC clock in at91_macb_hw_init().
In reply to Andreas Bießmann--- arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)
arch/arm/cpu/arm926ejs/at91/at91sam9260_devices.c +4 -0
@@ -158,6 +158,10 @@ void at91_spi1_hw_init(unsigned long cs_mask)#ifdef CONFIG_MACB void at91_macb_hw_init (void ) { +/* Enable EMAC clock */ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ; +writel (1 <<ATMEL_ID_EMAC0 , &pmc->pcer); +at91_set_a_periph (AT91_PIO_PORTA ,19 ,0 );/* ETXCK_EREFCK */ at91_set_a_periph (AT91_PIO_PORTA ,17 ,0 );/* ERXDV */ at91_set_a_periph (AT91_PIO_PORTA ,14 ,0 );/* ERX0 */
Signature · 1 line
1.7.7
PATCH 1/1 Enable the EMAC clock in at91_macb_hw_init().
Dear Markus Hubig,
Quoted 3 lines · Markus Hubig
Signed-off-by Markus Hubig <[email protected]>Cc Andreas Bie?mann <[email protected]>---
applied to u-boot-atmel, thanks.
Best regards
Andreas Bie?mann
PATCH v2 1/1 at91: Add support for taskit AT91SAM9G20 boards.
In reply to Andreas BießmannThis adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
--- MAINTAINERS | 4 + board/taskit/stamp9g20/Makefile | 52 +++++++++ board/taskit/stamp9g20/stamp9g20.c | 185 ++++++++++++++++++++++++++++++ boards.cfg | 2 + include/configs/stamp9g20.h | 216 ++++++++++++++++++++++++++++++++++++ 5 files changed, 459 insertions(+), 0 deletions(-) create mode 100644 board/taskit/stamp9g20/Makefile create mode 100644 board/taskit/stamp9g20/stamp9g20.c create mode 100644 include/configs/stamp9g20.h
MAINTAINERS +4 -0
@@ -243,6 +243,10 @@ Klaus Heydeck <[email protected]> KUP4K MPC855 KUP4X MPC859 +Markus Hubig <[email protected]> + + STAMP9G20 ARM926EJS + Ilko Iliev <[email protected]> PM9261 AT91SAM9261
board/taskit/stamp9g20/Makefile new file +52 -0
52 lines not on this page · raw message
board/taskit/stamp9g20/stamp9g20.c new file +185 -0
185 lines not on this page · raw message
boards.cfg +2 -0
@@ -120,6 +120,8 @@ cpu9G20_nand_128M arm arm926ejs cpu9260 eukrea pm9261 arm arm926ejs pm9261 ronetix at91 pm9261:AT91SAM9261 pm9263 arm arm926ejs pm9263 ronetix at91 pm9263:AT91SAM9263 pm9g45 arm arm926ejs pm9g45 ronetix at91 pm9g45:AT91SAM9G45 +portuxg20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20,CONFIG_PORTUXG20 +stamp9g20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20 cam_enc_4xx arm arm926ejs cam_enc_4xx ait davinci cam_enc_4xx da830evm arm arm926ejs da8xxevm davinci davinci da850_am18xxevm arm arm926ejs da8xxevm davinci davinci da850evm:DA850_AM18X_EVM,MAC_ADDR_IN_EEPROM,SYS_I2C_EEPROM_ADDR_LEN=2,SYS_I2C_EEPROM_ADDR=0x50
include/configs/stamp9g20.h new file +216 -0
216 lines not on this page · raw message
Signature · 1 line
1.7.7
PATCH v2 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Dear Markus Hubig,
Quoted 22 lines · Markus Hubig
This adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
Signed-off-by Markus Hubig <[email protected]>Cc Andreas Bie?mann <[email protected]>--- MAINTAINERS | 4 + board/taskit/stamp9g20/Makefile | 52 +++++++++ board/taskit/stamp9g20/stamp9g20.c | 185 ++++++++++++++++++++++++++++++ boards.cfg | 2 + include/configs/stamp9g20.h | 216 ++++++++++++++++++++++++++++++++++++ 5 files changed, 459 insertions(+), 0 deletions(-) create mode 100644 board/taskit/stamp9g20/Makefile create mode 100644 board/taskit/stamp9g20/stamp9g20.c create mode 100644 include/configs/stamp9g20.hMAINTAINERS +0
-0
MAINTAINERS Klaus Heydeck <[email protected]> · line 250
Quoted 8 lines
MAINTAINERS +4
-0@@ -243,6 +243,10 @@ Klaus Heydeck <[email protected]> KUP4K MPC855 KUP4X MPC859 +Markus Hubig <[email protected]> + + STAMP9G20 ARM926EJS + Ilko Iliev <[email protected]>
unfortunately Ilko Iliev is wrong here ... this is the PPC section (all these MPCxx). About line 566 begins the ARM section.
Quoted 175 lines
MAINTAINERS +0
-0PM9261 AT91SAM9261board/taskit/stamp9g20/Makefile new file +52
-0@@ -0,0 +1,52 @@ +# +# (C) Copyright 2003-2008 +# Wolfgang Denk, DENX Software Engineering, wd at denx.de. +# +# (C) Copyright 2008 +# Stelian Pop <[email protected]> +# Lead Tech Design <www.leadtechdesign.com> +# +# (C) Copyright 2012 +# Markus Hubig <[email protected]> +# IMKO GmbH <www.imko.de> +# +# See file CREDITS for list of people who contributed to this +# project. +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License as +# published by the Free Software Foundation; either version 2 of +# the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 59 Temple Place, Suite 330, Boston, +# MA 02111-1307 USA +# + +include $(TOPDIR)/config.mk + +LIB = $(obj)lib$(BOARD).o + +COBJS-y += stamp9g20.o + +SRCS := $(SOBJS:.o=.S) $(COBJS-y:.o=.c) +OBJS := $(addprefix $(obj),$(COBJS-y)) +SOBJS := $(addprefix $(obj),$(SOBJS)) + +$(LIB): $(obj).depend $(OBJS) $(SOBJS) + $(call cmd_link_o_target, $(OBJS) $(SOBJS)) + +######################################################################### + +# defines $(obj).depend target +include $(SRCTREE)/rules.mk + +sinclude $(obj).depend + +#########################################################################board/taskit/stamp9g20/stamp9g20.c new file +109
-0@@ -0,0 +1,185 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* +* Achim Ehrlich <[email protected]> +* taskit GmbH <www.taskit.de> +* +* (C) Copyright 2012- +* Markus Hubig <[email protected]> +* IMKO GmbH <www.imko.de> +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#include <common.h> +#include <asm/io.h> +#include <asm/arch/at91sam9260_matrix.h> +#include <asm/arch/at91sam9_smc.h> +#include <asm/arch/at91_common.h> +#include <asm/arch/at91_pmc.h> +#include <asm/arch/at91_rstc.h> +#include <asm/arch/gpio.h> +#include <watchdog.h> +#include <net.h> +#include <netdev.h> + +DECLARE_GLOBAL_DATA_PTR ; + +static void stamp9G20_nand_hw_init (void ) +{ +struct at91_smc *smc = (struct at91_smc *)ATMEL_BASE_SMC ; +struct at91_matrix *matrix = (struct at91_matrix *)ATMEL_BASE_MATRIX ; +unsigned long csa; + +/* Assign CS3 to NAND/SmartMedia Interface */ + csa =readl (&matrix->ebicsa); + csa |=AT91_MATRIX_CS3A_SMC_SMARTMEDIA ; +writel (csa, &matrix->ebicsa); + +/* Configure SMC CS3 for NAND/SmartMedia */ +writel (AT91_SMC_SETUP_NWE (1 ) |AT91_SMC_SETUP_NCS_WR (0 ) | +AT91_SMC_SETUP_NRD (1 ) |AT91_SMC_SETUP_NCS_RD (0 ), + &smc->cs[3 ].setup); +writel (AT91_SMC_PULSE_NWE (3 ) |AT91_SMC_PULSE_NCS_WR (3 ) | +AT91_SMC_PULSE_NRD (3 ) |AT91_SMC_PULSE_NCS_RD (3 ), + &smc->cs[3 ].pulse); +writel (AT91_SMC_CYCLE_NWE (5 ) |AT91_SMC_CYCLE_NRD (5 ), + &smc->cs[3 ].cycle); +writel (AT91_SMC_MODE_RM_NRD |AT91_SMC_MODE_WM_NWE | +AT91_SMC_MODE_EXNW_DISABLE | +AT91_SMC_MODE_DBW_8 | +AT91_SMC_MODE_TDF_CYCLE (2 ), + &smc->cs[3 ].mode); + +/* Configure RDY/BSY */ +at91_set_gpio_input (CONFIG_SYS_NAND_READY_PIN ,1 ); + +/* Enable NandFlash */ +at91_set_gpio_output (CONFIG_SYS_NAND_ENABLE_PIN ,1 ); +} + +static void stamp9G20_macb_hw_init (void ) +{ +struct at91_port *pioa = (struct at91_port *)ATMEL_BASE_PIOA ; +struct at91_rstc *rstc = (struct at91_rstc *)ATMEL_BASE_RSTC ; +unsigned long erstl; +int timeout =100 ; + +/* Enable the PHY Chip via PA26 on the Stamp 2 Adaptor */ +at91_set_gpio_output (AT91_PIN_PA26 ,0 ); + +/* +* Disable pull-up on: +* RXDV (PA17) => PHY normal mode (not Test mode) +* ERX0 (PA14) => PHY ADDR0 +* ERX1 (PA15) => PHY ADDR1 +* ERX2 (PA25) => PHY ADDR2 +* ERX3 (PA26) => PHY ADDR3 +* ECRS (PA28) => PHY ADDR4 => PHYADDR = 0x0 +* +* PHY has internal pull-down +*/ +writel (pin_to_mask (AT91_PIN_PA14 ) | +pin_to_mask (AT91_PIN_PA15 ) | +pin_to_mask (AT91_PIN_PA17 ) | +pin_to_mask (AT91_PIN_PA18 ) | +pin_to_mask (AT91_PIN_PA28 ), + &pioa->pudr); + + erstl =readl (&rstc->mr) &AT91_RSTC_MR_ERSTL_MASK ; + +/* Need to reset PHY -> 500ms reset */
board/taskit/stamp9g20/stamp9g20.c line 119
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c new file +10
-0+writel (AT91_RSTC_KEY |AT91_RSTC_MR_ERSTL (13 ) | +AT91_RSTC_MR_URSTEN , &rstc->mr); + +writel (AT91_RSTC_KEY |AT91_RSTC_CR_EXTRST , &rstc->cr); + +/* Wait for end of hardware reset */ +while (!(readl (&rstc->sr) &AT91_RSTC_SR_NRSTL )) { + +/* avoid shutdown by watchdog */ +hw_watchdog_reset ();
WATCHDOG_RESET();
board/taskit/stamp9g20/stamp9g20.c line 126
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c new file +7
-0+ +mdelay (10 ); + timeout--; + +/* timeout for not getting stuck in an endless loop */ +if (timeout <=0 ) { +debug ("ERROR: Timeout waiting for PHY reset!\n" );
Error should always print out.
Quoted 30 lines
board/taskit/stamp9g20/stamp9g20.c new file +30
-0+break ; + }; + }; + +/* Restore NRST value */ +writel (AT91_RSTC_KEY | erstl |AT91_RSTC_MR_URSTEN , + &rstc->mr); + +/* Re-enable pull-up */ +writel (pin_to_mask (AT91_PIN_PA14 ) | +pin_to_mask (AT91_PIN_PA15 ) | +pin_to_mask (AT91_PIN_PA17 ) | +pin_to_mask (AT91_PIN_PA18 ) | +pin_to_mask (AT91_PIN_PA28 ), + &pioa->puer); + +/* Initialize EMAC=MACB hardware */ +at91_macb_hw_init (); +} + +int board_early_init_f (void ) +{ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ; + +/* Enable clocks for all PIOs */ +writel ((1 <<ATMEL_ID_PIOA ) | (1 <<ATMEL_ID_PIOB ) | + (1 <<ATMEL_ID_PIOC ), &pmc->pcer); + +return 0 ; +}
board/taskit/stamp9g20/stamp9g20.c line 166
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c new file +10
-0+ +int board_init (void ) +{ +/* adress of boot parameters */ + gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE +0x100 ; + +at91_set_gpio_output (AT91_PIN_PC9 ,1 ); +at91_set_gpio_output (AT91_PIN_PC5 ,1 ); + +at91_seriald_hw_init ();
at least the at91sam9263ek initializes the usart in board_early_init_f ... will check it with at91sam9260ek these days.
Quoted 85 lines
board/taskit/stamp9g20/stamp9g20.c new file +19
-0+stamp9G20_nand_hw_init (); +stamp9G20_macb_hw_init (); + +return 0 ; +} + +int dram_init (void ) +{ + gd->ram_size =get_ram_size ( + (void *)CONFIG_SYS_SDRAM_BASE , +CONFIG_SYS_SDRAM_SIZE ); +return 0 ; +} + +int board_eth_init (bd_t *bis) +{ +int rc =0 ; +return macb_eth_initialize (0 , (void *)ATMEL_BASE_EMAC0 ,0x00 ); +}boards.cfg +2
-0@@ -120,6 +120,8 @@ cpu9G20_nand_128M arm arm926ejs cpu9260 eukrea pm9261 arm arm926ejs pm9261 ronetix at91 pm9261:AT91SAM9261 pm9263 arm arm926ejs pm9263 ronetix at91 pm9263:AT91SAM9263 pm9g45 arm arm926ejs pm9g45 ronetix at91 pm9g45:AT91SAM9G45 +portuxg20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20,CONFIG_PORTUXG20 +stamp9g20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20 cam_enc_4xx arm arm926ejs cam_enc_4xx ait davinci cam_enc_4xx da830evm arm arm926ejs da8xxevm davinci davinci da850_am18xxevm arm arm926ejs da8xxevm davinci davinci da850evm:DA850_AM18X_EVM,MAC_ADDR_IN_EEPROM,SYS_I2C_EEPROM_ADDR_LEN=2,SYS_I2C_EEPROM_ADDR=0x50include/configs/stamp9g20.h new file +47
-0@@ -0,0 +1,216 @@ +/* +* (C) Copyright 2007-2008 +* Stelian Pop <[email protected]> +* Lead Tech Design <www.leadtechdesign.com> +* +* (C) Copyright 2010 +* Achim Ehrlich <[email protected]> +* taskit GmbH <www.taskit.de> +* +* (C) Copyright 2012 +* Markus Hubig <[email protected]> +* IMKO GmbH <www.imko.de> +* +* Configuation settings for the stamp9g20 CPU module. +* +* See file CREDITS for list of people who contributed to this +* project. +* +* This program is free software; you can redistribute it and/or +* modify it under the terms of the GNU General Public License as +* published by the Free Software Foundation; either version 2 of +* the License, or (at your option) any later version. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 59 Temple Place, Suite 330, Boston, +* MA 02111-1307 USA +*/ + +#ifndef __CONFIG_H +#define __CONFIG_H + +/* +* SoC must be defined first, before hardware.h is included. +* In this case SoC is defined in boards.cfg. +*/ +#include <asm/hardware.h> + +/* +* Warning: changing CONFIG_SYS_TEXT_BASE requires adapting the initial boot +* program. Since the linker has to swallow that define, we must use a pure +* hex number here!
include/configs/stamp9g20.h line 57
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+*/ +#define CONFIG_SYS_TEXT_BASE 0x23f00000 + +/* ARM asynchronous clock */ +#define CONFIG_SYS_AT91_SLOW_CLOCK 32768/* slow clock xtal */ +#define CONFIG_SYS_AT91_MAIN_CLOCK 18432000/* 18.432MHz crystal */ +#define CONFIG_SYS_HZ 1000/* 1ms resolution */ + +/* Misc CPU related settings */ +#define CONFIG_ARCH_CPU_INIT /* call arch_cpu_init() */
Commit a21c65115bd95572cc80092a31b0e9ecb8710e9f removes necessity for this config ... also new to me.
Quoted 92 lines
include/configs/stamp9g20.h new file +92
-0+#define CONFIG_CMDLINE_TAG /* pass commandline to Kernel */ +#define CONFIG_SETUP_MEMORY_TAGS /* pass memory defs to kernel */ +#define CONFIG_INITRD_TAG /* pass initrd param to kernel */ +#define CONFIG_SKIP_LOWLEVEL_INIT /* U-Boot is loaded by a bootloader */ +#define CONFIG_BOARD_EARLY_INIT_f/* call board_early_init_f() */ +#define CONFIG_DISPLAY_CPUINFO /* display CPU Info at startup */ + +/* setting the mach type */ +#ifdef CONFIG_PORTUXG20 +# define CONFIG_MACH_TYPE MACH_TYPE_PORTUXG20 +#else +# define CONFIG_MACH_TYPE MACH_TYPE_STAMP9G20 +#endif + +/* +* SDRAM: 1 bank, 64 MB, base address 0x20000000 +* Already initialized before u-boot gets started. +*/ +#define CONFIG_NR_DRAM_BANKS 1 +#define CONFIG_SYS_SDRAM_BASE ATMEL_BASE_CS1 +#define CONFIG_SYS_SDRAM_SIZE (64 * (1024 << 10)) + +/* +* Perform a SDRAM Memtest from the start of SDRAM +* till the beginning of the U-Boot position in RAM. +*/ +#define CONFIG_SYS_MEMTEST_START CONFIG_SYS_SDRAM_BASE +#define CONFIG_SYS_MEMTEST_END (CONFIG_SYS_TEXT_BASE - 0x100000) + +/* Size of malloc() pool */ +#define CONFIG_SYS_MALLOC_LEN \ + ROUND(3 * CONFIG_ENV_SIZE + 128 * 1024, 0x1000) + +/* +* Initial stack pointer: 4k - GENERATED_GBL_DATA_SIZE in internal SRAM, +* leaving the correct space for initial global data structure above that +* address while providing maximum stack area below. +*/ +#define CONFIG_SYS_INIT_SP_ADDR \ + (ATMEL_BASE_SRAM1 + 0x1000 - GENERATED_GBL_DATA_SIZE) + +/* NAND flash settings */ +#define CONFIG_NAND_ATMEL +#define CONFIG_SYS_NO_FLASH +#define CONFIG_SYS_MAX_NAND_DEVICE 1 +#define CONFIG_SYS_NAND_BASE ATMEL_BASE_CS3 +#define CONFIG_SYS_NAND_DBW_8 +#define CONFIG_SYS_NAND_MASK_ALE (1 << 21) +#define CONFIG_SYS_NAND_MASK_CLE (1 << 22) +#define CONFIG_SYS_NAND_ENABLE_PIN AT91_PIN_PC14 +#define CONFIG_SYS_NAND_READY_PIN AT91_PIN_PC13 + +/* general purpose I/O */ +#define CONFIG_ATMEL_LEGACY /* required until (g)pio is fixed */ +#define CONFIG_AT91_GPIO /* enable the GPIO features */ +#define CONFIG_AT91_GPIO_PULLUP 1/* keep pullups on peripheral pins */ + +/* serial console */ +#define CONFIG_ATMEL_USART +#define CONFIG_USART_BASE ATMEL_BASE_DBGU +#define CONFIG_USART_ID ATMEL_ID_SYS +#define CONFIG_BAUDRATE 115200 + +/* Ethernet configuration */ +#define CONFIG_MACB /* initialize the ethernet port */ +#define CONFIG_RMII /* use reduced MII inteface */ +#define CONFIG_NET_RETRY_COUNT 20/* # of DHCP/BOOTP retries */ + +/* Enable the watchdog */ +#define CONFIG_AT91SAM9_WATCHDOG +#define CONFIG_HW_WATCHDOG + +/* USB configuration */ +#define CONFIG_USB_ATMEL +#define CONFIG_USB_OHCI_NEW +#define CONFIG_USB_STORAGE +#define CONFIG_DOS_PARTITION +#define CONFIG_SYS_USB_OHCI_CPU_INIT +#define CONFIG_SYS_USB_OHCI_REGS_BASE ATMEL_UHP_BASE +#define CONFIG_SYS_USB_OHCI_SLOT_NAME "at91sam9260" +#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS 2 + +/* BOOTP options */ +#define CONFIG_BOOTP_BOOTFILESIZE +#define CONFIG_BOOTP_BOOTPATH +#define CONFIG_BOOTP_GATEWAY +#define CONFIG_BOOTP_HOSTNAME + +/* General Boot Parameter */ +#define CONFIG_BOOTDELAY 3 +#define CONFIG_BOOTCOMMAND "run flashboot" +#define CONFIG_SYS_PROMPT "U-Boot> "
include/configs/stamp9g20.h line 159
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+#define CONFIG_SYS_CBSIZE 256 +#define CONFIG_SYS_MAXARGS 16 +#define CONFIG_SYS_PBSIZE \ + (CONFIG_SYS_CBSIZE + sizeof(CONFIG_SYS_PROMPT) + 16) +#define CONFIG_SYS_LONGHELP +#define CONFIG_CMDLINE_EDITING + +/* +* RAM Memory address where to put the +* Linux Kernel bevor starting.
--------------------^
before?
Quoted 19 lines
include/configs/stamp9g20.h new file +19
-0+*/ +#define CONFIG_SYS_LOAD_ADDR 0x22000000 + +/* +* The NAND Flash partitions: +* ========================================== +* 0x0000000-0x001ffff -> 128k, bootstrap +* 0x0020000-0x005ffff -> 256k, u-boot +* 0x0060000-0x007ffff -> 128k, env1 +* 0x0080000-0x009ffff -> 128k, env2 (backup) +* 0x0100000-0x06fffff -> 6M, kernel +* 0x0700000-0x8000000 -> 121M, RootFS +*/ +#define CONFIG_ENV_IS_IN_NAND +#define CONFIG_ENV_OFFSET (128 + 256 << 10) +#define CONFIG_ENV_OFFSET_REDUND (128 + 256 + 128 << 10) +#define CONFIG_ENV_SIZE (128 << 10) + +/*
include/configs/stamp9g20.h line 188
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+* Predefined environment variables. +* Usefull to define some easy to use boot commands. +*/ +#define CONFIG_EXTRA_ENV_SETTINGS \ + \ + "basicargs=console=ttyS0,115200\0" \ + \ + "mtdparts=mtdparts=atmel_nand:128k(bootstrap)ro," \ + "256k(uboot)ro,128k(env1)ro," \ + "128k(env2)ro,12M(linux),-(root)rw\0" \
your table in comment tells 6MiB for kernel, here you have 12MiB ;)
include/configs/stamp9g20.h line 201
Quoted 13 lines
include/configs/stamp9g20.h new file +13
-0+ \ +"sdboot=setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/mmcblk0p1 rootwait; " \ +"nand read 0x22000000 0x100000 0x600000; " \ +"bootm 22000000\0" \ + \ +"flashboot=setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/mtdblock5 rootfstype=jffs2; " \ +"nand read 0x22000000 0x100000 0x600000; " \ +"bootm 22000000\0" \ + \ +"nfsboot=dhcp; setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/nfs ip=dhcp; bootm\0"
dhcp command can use some env (I think bootfile) to directely boot. So setting this env, setting bootargs and then run dhcp would maybe better. Alternatively the nfsboot could imply a correctly set bootfile, this could be another env in your EXTRA_ENV_SETTINGS (another side note;).
Quoted 6 lines
include/configs/stamp9g20.h new file +5
-0+ +/* Command line & features configuration */ +#include <config_cmd_default.h> +#undef CONFIG_CMD_FPGA +#undef CONFIG_CMD_IMI
include/configs/stamp9g20.h line 216
Quoted 10 lines
include/configs/stamp9g20.h new file +10
-0+#undef CONFIG_CMD_IMLS +#undef CONFIG_CMD_LOADS + +#define CONFIG_CMD_NAND +#define CONFIG_CMD_USB +#define CONFIG_CMD_FAT +#define CONFIG_CMD_PING +#define CONFIG_CMD_DHCP + +#endif /* __CONFIG_H */
We should think about the MACB ifdef stuff again. I learned that the stamp9g20 is a small device sitting on different base boards. In case of portux9g20 we will have ethernet. Therefore we should always enable MACB when we are configured as portux9g20. But if one uses the stamp on another base board he maybe want to disable ethernet support easily ... with this information I think it is good to have these ifdef blocks around all the ethernet stuff. Sorry, I understood this in your last mail and you sent this patch to fast to comment ...
Best regards
Andreas Bie?mann
PATCH v2 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Quoted 9 lines · Andreas Bie?mann
MAINTAINERS Klaus Heydeck <[email protected]> · line 250
Quoted 5 lines · Markus Hubig
MAINTAINERS +4
-0+Markus Hubig <[email protected]> + + STAMP9G20 ARM926EJS + Ilko Iliev <[email protected]>unfortunately Ilko Iliev is wrong here ... this is the PPC section (all these MPCxx). About line 566 begins the ARM section.
Moved both of us ...
Quoted 4 lines
Quoted 2 lines
+ * RAM Memory address where to put the
+ * Linux Kernel bevor starting.--------------------^
before?
Ups ...
Quoted 5 lines
include/configs/stamp9g20.h line 188
Quoted 3 lines
include/configs/stamp9g20.h new file +3
-0+"mtdparts=mtdparts=atmel_nand:128k(bootstrap)ro," \ +"256k(uboot)ro,128k(env1)ro," \ +"128k(env2)ro,12M(linux),-(root)rw\0" \your table in comment tells 6MiB for kernel, here you have 12MiB ;)
Grrr fixed! ;)
Quoted 7 lines
include/configs/stamp9g20.h line 201
Quoted 2 lines
include/configs/stamp9g20.h new file +2
-0+"nfsboot=dhcp; setenv bootargs ${basicargs} ${mtdparts} " \ +"root=/dev/nfs ip=dhcp; bootm\0" dhcp command can use some env (I think bootfile) to directely boot. So setting this env, setting bootargs and then run dhcp would maybe better. Alternatively the nfsboot could imply a correctly set bootfile, this could be another env in your
EXTRA_ENV_SETTINGS(another side note;).
Ahh it's autoboot=yes! ;)
Btw: I think it would be easier to handle if all the options in env_common.h would be prefixed with CONFIG_ENV_* ...
Quoted 11 lines
Quoted 2 lines
+#endif /*
__CONFIG_H*/We should think about the MACB ifdef stuff again. I learned that the stamp9g20 is a small device sitting on different base boards. In case of portux9g20 we will have ethernet. Therefore we should always enable MACB when we are configured as portux9g20. But if one uses the stamp on another base board he maybe want to disable ethernet support easily ... with this information I think it is good to have these ifdef blocks around all the ethernet stuff. Sorry, I understood this in your last mail and you sent this patch to fast to comment ...
Hmm ok good idea ... will include this in the next patch.
Cheers, Markus
PATCH v2 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Dear Markus Hubig,
Quoted 5 lines · Markus Hubig
Quoted 1 line · Andreas Bie?mann
On 01.08.12 21:57, Markus Hubig wrote:
Btw: I think it would be easier to handle if all the options in
env_common.hwould be prefixed with CONFIG_ENV_* ...
feel free to send patches. I dunno if they will be accepted.
Best regards
Andreas Bie?mann
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
In reply to Andreas BießmannQuoted 2 lines · Andreas Bie?mann
Quoted 1 line · Markus Hubig
<snipp>
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c line 148
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c new file +7
-0+int board_early_init_f (void ) +{ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ; + +/* Enable clocks for all PIOs */ +writel ((1 <<ATMEL_ID_PIOA ) | (1 <<ATMEL_ID_PIOB ) | + (1 <<ATMEL_ID_PIOC ), &pmc->pcer);you should initialize
seriald_hwhere to avoid strange characters on serial line when switching from at91bootstrap to u-boot.
<snip>
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c line 164
Quoted 5 lines
board/taskit/stamp9g20/stamp9g20.c new file +5
-0+/* adress of boot parameters */ + gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE +0x100 ; + +at91_set_gpio_output (AT91_PIN_PC9 ,1 ); +at91_set_gpio_output (AT91_PIN_PC5 ,1 );Can you please add some comment why switching these pins?
OK now I now that PC5 switches the red LED on and there since is a LED framework in u-boot I will use that in a later patch.
PC9 is somewhat strange. If I set it to 0 I don't have a console!
So I tried to put both
| at91_set_gpio_output(AT91_PIN_PC9, 1);
| at91_seriald_hw_init();
into board_early_init_f() to avoid the strange characters at boot time, but again no console output ...
Further tests showed that It seems that I can't use at91_set_gpio_output() inside board_early_init_f(). Switching on the red LED with PC5 also do not work in board_early_init_f() ...
Any ideas?
Cheers, Markus
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Dear Markus Hubig,
Quoted 27 lines · Markus Hubig
Quoted 2 lines · Andreas Bie?mann
Quoted 1 line · Markus Hubig
<snipp>
Quoted 10 lines
board/taskit/stamp9g20/stamp9g20.c line 148
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c new file +7
-0+int board_early_init_f (void ) +{ +struct at91_pmc *pmc = (struct at91_pmc *)ATMEL_BASE_PMC ; + +/* Enable clocks for all PIOs */ +writel ((1 <<ATMEL_ID_PIOA ) | (1 <<ATMEL_ID_PIOB ) | + (1 <<ATMEL_ID_PIOC ), &pmc->pcer);you should initialize
seriald_hwhere to avoid strange characters on serial line when switching from at91bootstrap to u-boot.<snip>
Quoted 7 lines
board/taskit/stamp9g20/stamp9g20.c line 164
Quoted 5 lines
board/taskit/stamp9g20/stamp9g20.c new file +5
-0+/* adress of boot parameters */ + gd->bd->bi_boot_params =CONFIG_SYS_SDRAM_BASE +0x100 ; + +at91_set_gpio_output (AT91_PIN_PC9 ,1 ); +at91_set_gpio_output (AT91_PIN_PC5 ,1 );Can you please add some comment why switching these pins?
Quoted 4 lines
OK now I now that PC5 switches the red LED on and there since is a LED framework in u-boot I will use that in a later patch.
PC9 is somewhat strange. If I set it to 0 I don't have a console!
can you please ask at taskit what function this pin has and document it here?
Quoted 5 lines
So I tried to put both
|
at91_set_gpio_output(AT91_PIN_PC9, 1);
|at91_seriald_hw_init();
Quoted 8 lines
into
board_early_init_f()to avoid the strange characters at boot time, but again no console output ...Further tests showed that It seems that I can't use
at91_set_gpio_output()insideboard_early_init_f(). Switching on the red LED with PC5 also do not work inboard_early_init_f()...Any ideas?
Not currently. Maybe the PC9 has some vital functionality for UART to work (some switch, power, ...) and is reset by another part running after board_early_init_f()?
Quoted 2 lines
Cheers, Markus
Best regards
Andreas Bie?mann
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Quoted 8 lines · Andreas Bie?mann
Quoted 4 lines · Markus Hubig
Quoted 1 line · Andreas Bie?mann
On 30.07.12 20:01, Markus Hubig wrote:
PC9 is somewhat strange. If I set it to 0 I don't have a console!
can you please ask at taskit what function this pin has and document it here?
I'm already waiting for an aswer ...
Quoted 12 lines
Quoted 12 lines
So I tried to put both
|
at91_set_gpio_output(AT91_PIN_PC9, 1);
|at91_seriald_hw_init();into
board_early_init_f()to avoid the strange characters at boot time, but again no console output ...Further tests showed that It seems that I can't use
at91_set_gpio_output()insideboard_early_init_f(). Switching on the red LED with PC5 also do not work inboard_early_init_f()...
Quoted 5 lines
Quoted 1 line
Any ideas?
Not currently. Maybe the PC9 has some vital functionality for UART to work (some switch, power, ...) and is reset by another part running after
board_early_init_f()?
But how can I reset this PIN without using 'AT91_PIN_PC9'? I'm grep'ed all over the source code but don't find nothing! Is there another way of setting the PIO pins?
Cheers, Markus
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
In reply to Markus HubigThis adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
--- MAINTAINERS | 16 ++- board/taskit/stamp9g20/Makefile | 53 +++++++ board/taskit/stamp9g20/led.c | 134 ++++++++++++++++++ board/taskit/stamp9g20/stamp9g20.c | 192 ++++++++++++++++++++++++++ boards.cfg | 2 + include/configs/stamp9g20.h | 267 ++++++++++++++++++++++++++++++++++++ 6 files changed, 658 insertions(+), 6 deletions(-) create mode 100644 board/taskit/stamp9g20/Makefile create mode 100644 board/taskit/stamp9g20/led.c create mode 100644 board/taskit/stamp9g20/stamp9g20.c create mode 100644 include/configs/stamp9g20.h
MAINTAINERS +10 -6
@@ -243,12 +243,6 @@ Klaus Heydeck <[email protected]> KUP4K MPC855 KUP4X MPC859 -Ilko Iliev <[email protected]> - - PM9261 AT91SAM9261 - PM9263 AT91SAM9263 - PM9G45 ARM926EJS (AT91SAM9G45 SoC) - Gary Jennejohn <[email protected]> quad100hd PPC405EP
@@ -681,10 +675,20 @@ Vaibhav Hiremath <[email protected]> am3517_evm ARM ARMV7 (AM35x SoC) +Markus Hubig <[email protected]> + + STAMP9G20 ARM926EJS + Grazvydas Ignotas <[email protected]> omap3_pandora ARM ARMV7 (OMAP3xx SoC) +Ilko Iliev <[email protected]> + + PM9261 AT91SAM9261 + PM9263 AT91SAM9263 + PM9G45 ARM926EJS (AT91SAM9G45 SoC) + Michael Jones <[email protected]> omap3_mvblx ARM ARMV7 (OMAP3xx SoC)
board/taskit/stamp9g20/Makefile new file +53 -0
53 lines not on this page · raw message
board/taskit/stamp9g20/led.c new file +134 -0
134 lines not on this page · raw message
board/taskit/stamp9g20/stamp9g20.c new file +192 -0
192 lines not on this page · raw message
boards.cfg +2 -0
@@ -120,6 +120,8 @@ cpu9G20_nand_128M arm arm926ejs cpu9260 eukrea pm9261 arm arm926ejs pm9261 ronetix at91 pm9261:AT91SAM9261 pm9263 arm arm926ejs pm9263 ronetix at91 pm9263:AT91SAM9263 pm9g45 arm arm926ejs pm9g45 ronetix at91 pm9g45:AT91SAM9G45 +portuxg20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20,PORTUXG20 +stamp9g20 arm arm926ejs stamp9g20 taskit at91 stamp9g20:AT91SAM9G20 cam_enc_4xx arm arm926ejs cam_enc_4xx ait davinci cam_enc_4xx da830evm arm arm926ejs da8xxevm davinci davinci da850_am18xxevm arm arm926ejs da8xxevm davinci davinci da850evm:DA850_AM18X_EVM,MAC_ADDR_IN_EEPROM,SYS_I2C_EEPROM_ADDR_LEN=2,SYS_I2C_EEPROM_ADDR=0x50
include/configs/stamp9g20.h new file +267 -0
267 lines not on this page · raw message
Signature · 1 line
1.7.9.5
PATCH 1/1 at91: Add support for taskit AT91SAM9G20 boards.
Quoted 3 lines · Markus Hubig
This adds support for the AT91SAM9G20 boards by taskit GmbH. Both boards, Stamp9G20 and PortuxG20, are integrated in one file. PortuxG20 is basically a SBC built around the Stamp9G20.
Ignore this. I started a new thread with [PATCH v4] in the subject.
Cheers, Markus