Skip to contentSkip to conversation

env_onenand: set ONENAND_MAX_ENV_SIZE to CONFIG_ENV_SIZE

PATCH New David du Colombier 2 participants 3 messages Jun 13, 2012 – Aug 6, 2012

lore
Share & tools
lore

David du Colombier

author
#0 lore raw

PATCH 1/1 env_onenand: set ONENAND_MAX_ENV_SIZE to CONFIG_ENV_SIZE

This fix prevents env_import() CRC to fail when CONFIG_ENV_SIZE is not equal to 4096 bytes
It also prevents mtd->read and mtd->write to be incomplete when the environment is larger than 4096 bytes.

Signed-off-by David du Colombier <[email protected]>
---
 common/env_onenand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
common/env_onenand.c +1 -1
index 7197ab6..da35071 100644
@@ -39,7 +39,7 @@
 
 char *env_name_spec = "OneNAND";
 
-#define ONENAND_MAX_ENV_SIZE	4096
+#define ONENAND_MAX_ENV_SIZE	CONFIG_ENV_SIZE
 #define ONENAND_ENV_SIZE(mtd)	(ONENAND_MAX_ENV_SIZE - ENV_HEADER_SIZE)
 
 DECLARE_GLOBAL_DATA_PTR;
Signature · 1 line
1.7.6.5
author
#1 lore raw

PATCH 1/1 env_onenand: set ONENAND_MAX_ENV_SIZE to CONFIG_ENV_SIZE

Quoted 15 lines

This fix prevents env_import() CRC to fail when CONFIG_ENV_SIZE is not equal to 4096 bytes
It also prevents mtd->read and mtd->write to be incomplete when the environment is larger than 4096 bytes.

Signed-off-by David du Colombier <[email protected]>
---
 common/env_onenand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
common/env_onenand.c +0 -0
index 7197ab6..da35071 100644

common/env_onenand.c line 45

Quoted 8 lines
common/env_onenand.c +1 -1
@@ -39,7 +39,7 @@
 
 char *env_name_spec = "OneNAND";
 
-#define ONENAND_MAX_ENV_SIZE	4096
+#define ONENAND_MAX_ENV_SIZE	CONFIG_ENV_SIZE
 #define ONENAND_ENV_SIZE(mtd)	(ONENAND_MAX_ENV_SIZE -
 ENV_HEADER_SIZE) 
 DECLARE_GLOBAL_DATA_PTR;

Could you please take a look? It fixes environment saving and restoring on IGEPv2.

Thanks.

Signature · 1 line
David du Colombier
#2 lore raw

PATCH 1/1 env_onenand: set ONENAND_MAX_ENV_SIZE to CONFIG_ENV_SIZE

Dear David du Colombier,

Quoted 27 lines
Quoted 15 lines

This fix prevents env_import() CRC to fail when CONFIG_ENV_SIZE is not equal to 4096 bytes
It also prevents mtd->read and mtd->write to be incomplete when the environment is larger than 4096 bytes.

Signed-off-by David du Colombier <[email protected]>
---
 common/env_onenand.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
common/env_onenand.c +0 -0
index 7197ab6..da35071 100644

common/env_onenand.c line 45

Quoted 8 lines
common/env_onenand.c +1 -1
@@ -39,7 +39,7 @@
 
 char *env_name_spec = "OneNAND";
 
-#define ONENAND_MAX_ENV_SIZE	4096
+#define ONENAND_MAX_ENV_SIZE	CONFIG_ENV_SIZE
 #define ONENAND_ENV_SIZE(mtd)	(ONENAND_MAX_ENV_SIZE -
 ENV_HEADER_SIZE) 
 DECLARE_GLOBAL_DATA_PTR;

Could you please take a look? It fixes environment saving and restoring on IGEPv2.

Quoted 2 lines

Thanks.

Tested-by Lukasz Majewski <[email protected]>

Test HW: S5PC110 GONI

Applied to u-boot-onenand repository,

Signature · 5 lines
Best regards,

Lukasz Majewski

Samsung Poland R&D Center | Linux Platform Group