Fix bracket imbalance if IPPROTO_SCTP is defined
PATCH 1/1 Fix bracket imbalance if IPPROTO_SCTP is defined
Detected by cppcheck.
Signed-off-by Thomas Jarosch <[email protected]>
--- output/ulogd_output_IPFIX.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
output/ulogd_output_IPFIX.c +1 -0
@@ -406,6 +406,7 @@ static int open_connect_socket(struct ulogd_pluginstance *pi)freeaddrinfo (resave); return ret; } + }#endif if (connect (ii->fd, res->ai_addr, res->ai_addrlen) !=0 ) {
Signature · 1 line
1.7.4.4
Quoted 1 line · Thomas Jarosch
Detected by cppcheck.
This is still applicable.
Quoted 20 lines
output/ulogd_output_IPFIX.c +1
-0@@ -406,6 +406,7 @@ static int open_connect_socket(struct ulogd_pluginstance *pi)freeaddrinfo (resave); return ret; } + }#endif if (connect (ii->fd, res->ai_addr, res->ai_addrlen) !=0 ) {Signature · 6 lines
1.7.4.4 -- To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Quoted 5 lines · Jan Engelhardt
Quoted 1 line · Thomas Jarosch
Detected by cppcheck.
This is still applicable.
Applied, thanks.
Still, the ipfix plugin needs one spin. The current snapshot doesn't work, that's why it's kept out of the compilation.
It shouldn't be hard to fix it. If anyone interested in contributing to Netfilter projects, this should be a good one to start with.
If not, I'll find the time to get it working.