Skip to contentSkip to conversation

mkconfig: fix failure on boards that don't define soc

PATCH New Allen Martin 3 participants 4 messages Aug 7, 2012

lore
Share & tools
lore

Allen Martin

author
#0 lore raw

PATCH 1/1 mkconfig: fix failure on boards that don't define soc

Fix a configure failure on boards that don't define soc. The exit status of the subshell was propogating up and causing mkconfig to fail. Add an explicit exit 0 to the subshell to fix this.

Signed-off-by Allen Martin <[email protected]>
---
 mkconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
mkconfig +2 -1
index 07031c6..d3363c6 100755
@@ -144,7 +144,8 @@ fi
     echo "BOARD  = ${board}"
 
     [ "${vendor}" ] && echo "VENDOR = ${vendor}"
-    [ "${soc}"    ] && echo "SOC    = ${soc}" ) > config.mk
+    [ "${soc}"    ] && echo "SOC    = ${soc}"
+    exit 0 ) > config.mk
 
 # Assign board directory to BOARDIR variable
 if [ -z "${vendor}" ] ; then
Signature · 1 line
1.7.9.5
author
#1 lore raw

PATCH 1/1 mkconfig: fix failure on boards that don't define soc

Quoted 5 lines · Allen Martin

Fix a configure failure on boards that don't define soc. The exit status of the subshell was propogating up and causing mkconfig to fail. Add an explicit exit 0 to the subshell to fix this.

Signed-off-by Allen Martin <[email protected]>

I ran a full MAKEALL -a arm on a system where I reproduced the failure on jornada previously and it ran clean.

-Allen

Signature · 1 line
nvpublic
#2 lore raw

PATCH 1/1 mkconfig: fix failure on boards that don't define soc

Hi Allen,

Quoted 5 lines · Allen Martin
Quoted 4 lines · Allen Martin

Fix a configure failure on boards that don't define soc. The exit status of the subshell was propogating up and causing mkconfig to fail. Add an explicit exit 0 to the subshell to fix this.

Quoted 7 lines
Quoted 1 line
Signed-off-by Allen Martin <[email protected]>

I ran a full MAKEALL -a arm on a system where I reproduced the failure on jornada previously and it ran clean.

-Allen

Sorry, Allen, missed this. I'd rather have this fix directly corrected in the original tegra/master commit so that bisecting remains feasible around this.

Amicalement,

Signature · 1 line
Albert.