Skip to contentSkip to conversation

MIPS: init module specific mips_hi16_list to NULL

PATCH Superseded Tony Wu 2 participants 2 messages Aug 10, 2012 MIPS

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Tony Wu

author
#0 lore raw

PATCH 1/1 MIPS: init module specific mips_hi16_list to NULL

MIPS: init module specific mips_hi16_list to NULL

mips_hi16_list was moved from global to mod_arch_specific. While global, it was bss initialized automatically, when moved to mod_arch_specific, we have to do the zero initialization.

---
 arch/mips/kernel/module.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
arch/mips/kernel/module.c +1 -0
index 8b29976..8e1fb80 100644
@@ -276,6 +276,7 @@ int apply_relocate(Elf_Shdr *sechdrs, const char *strtab,
 	pr_debug("Applying relocate section %u to %u\n", relsec,
 	       sechdrs[relsec].sh_info);
 
+	me->arch.r_mips_hi16_list = NULL;
 	for (i = 0; i < sechdrs[relsec].sh_size / sizeof(*rel); i++) {
 		/* This is where to make the change */
 		location = (void *)sechdrs[sechdrs[relsec].sh_info].sh_addr
Signature · 1 line
1.7.4.4
#1 lore raw
Quoted 7 lines · Tony Wu

MIPS: init module specific mips_hi16_list to NULL

mips_hi16_list was moved from global to mod_arch_specific. While global, it was bss initialized automatically, when moved to mod_arch_specific, we have to do the zero initialization.

Hi Tony,

can you reference the offending commit that caused the regression inside the patches description please ...

John