eth_write_hwaddr: Return error for invalid MACs
PATCH 1/1 eth_write_hwaddr: Return error for invalid MACs
If dev->enetaddr was supposed to be set with dev->write_hwaddr() but the MAC address was not valid, return an error.
Signed-off-by Beno?t Th?baudeau <[email protected]>
Cc Joe Hershberger <[email protected]>
---
{u-boot-4d3c95f.orig => u-boot-4d3c95f}/net/eth.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)net/eth.c +5 -2
@@ -222,9 +222,12 @@ int eth_write_hwaddr(struct eth_device *dev, const char *base_name, }if (dev->write_hwaddr && - !eth_mac_skip (eth_number) && -is_valid_ether_addr (dev->enetaddr)) + !eth_mac_skip (eth_number)) { +if (!is_valid_ether_addr (dev->enetaddr)) +return -1 ; + ret = dev->write_hwaddr (dev); + }return ret; }
PATCH 1/1 eth_write_hwaddr: Return error for invalid MACs
Acked-by Mike Frysinger <[email protected]>
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120811/9345b271/attachment.pgp>
Joe Hershberger
AppliedPATCH 1/1 eth_write_hwaddr: Return error for invalid MACs
In reply to Benoît ThébaudeauHi Beno?t,
Quoted 6 lines · Beno?t Th?baudeau
If
dev->enetaddrwas supposed to be set withdev->write_hwaddr()but the MAC address was not valid, return an error.Signed-off-by Beno?t Th?baudeau <[email protected]>Cc Joe Hershberger <[email protected]>---
Applied, thanks.
-Joe