mxs: Remove unused iomux-mx28.h
Subsystems (11)
PATCH 1/3 mxs: Remove unused iomux-mx28.h
The iomux-mx28.h include is not required on spl_mem_init.c so it has been droped.
--- arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 1 - 1 file changed, 1 deletion(-)
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +0 -1
@@ -26,7 +26,6 @@#include <common.h> #include <config.h> #include <asm/io.h> -#include <asm/arch/iomux-mx28.h> #include <asm/arch/imx-regs.h> #include "mxs_init.h"
Signature · 1 line
1.7.10.4
PATCH 2/3 mxs: rename regs-clkctrl.h to regs-clkctrl-mx28.h
The CLKCTRL registers are SoC specific so we ought to have it clear on filename.
---
arch/arm/include/asm/arch-mxs/imx-regs.h | 2 +-
.../arm/include/asm/arch-mxs/{regs-clkctrl.h => regs-clkctrl-mx28.h} | 0
drivers/usb/host/ehci-mxs.c | 2 +-
3 files changed, 2 insertions(+), 2 deletions(-)
rename arch/arm/include/asm/arch-mxs/{regs-clkctrl.h => regs-clkctrl-mx28.h} (100%)arch/arm/include/asm/arch-mxs/imx-regs.h +1 -1
@@ -26,7 +26,7 @@#include <asm/arch/regs-apbh.h> #include <asm/arch/regs-base.h> #include <asm/arch/regs-bch.h> -#include <asm/arch/regs-clkctrl.h> +#include <asm/arch/regs-clkctrl-mx28.h> #include <asm/arch/regs-digctl.h> #include <asm/arch/regs-gpmi.h> #include <asm/arch/regs-i2c.h>
arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.h renamed from arch/arm/include/asm/arch-mxs/regs-clkctrl.h +0 -0
drivers/usb/host/ehci-mxs.c +1 -1
@@ -23,7 +23,7 @@#include <asm/io.h> #include <asm/arch/regs-common.h> #include <asm/arch/regs-base.h> -#include <asm/arch/regs-clkctrl.h> +#include <asm/arch/regs-clkctrl-mx28.h> #include <asm/arch/regs-usb.h> #include <asm/arch/regs-usbphy.h>
Signature · 1 line
1.7.10.4
PATCH 2/3 mxs: rename regs-clkctrl.h to regs-clkctrl-mx28.h
Dear Otavio Salvador,
Quoted 2 lines
The CLKCTRL registers are SoC specific so we ought to have it clear on filename.
Quoted 31 lines
Signed-off-by Otavio Salvador <[email protected]>---
arch/arm/include/asm/arch-mxs/imx-regs.h|
2 +-.../arm/include/asm/arch-mxs/{regs-clkctrl.h=>regs-clkctrl-mx28.h}
| 0drivers/usb/host/ehci-mxs.c
| 2 +- 3 files changed, 2 insertions(+), 2 deletions(-)rename arch/arm/include/asm/arch-mxs/{regs-clkctrl.h =>
regs-clkctrl-mx28.h} (100%)(quoted diff) +0
-0
b/arch/arm/include/asm/arch-mxs/imx-regs.hindex 37d0a93..5e1901e 100644arch/arm/include/asm/arch-mxs/imx-regs.h +1
-1@@ -26,7 +26,7 @@#include <asm/arch/regs-apbh.h> #include <asm/arch/regs-base.h> #include <asm/arch/regs-bch.h> -#include <asm/arch/regs-clkctrl.h> +#include <asm/arch/regs-clkctrl-mx28.h> #include <asm/arch/regs-digctl.h> #include <asm/arch/regs-gpmi.h> #include <asm/arch/regs-i2c.h> (quoted diff) +0
-0
b/arch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.hsimilarity index 100% rename fromarch/arm/include/asm/arch-mxs/regs-clkctrl.hrename toarch/arm/include/asm/arch-mxs/regs-clkctrl-mx28.hdrivers/usb/host/ehci-mxs.c +0
-0
drivers/usb/host/ehci-mxs.c line 28
Quoted 7 lines
drivers/usb/host/ehci-mxs.c +1
-1@@ -23,7 +23,7 @@#include <asm/io.h> #include <asm/arch/regs-common.h> #include <asm/arch/regs-base.h> -#include <asm/arch/regs-clkctrl.h> +#include <asm/arch/regs-clkctrl-mx28.h> #include <asm/arch/regs-usb.h> #include <asm/arch/regs-usbphy.h>
Best regards,
Marek Vasut
PATCH 3/3 mxs: Convert sys_proto.h prefixes to 'mxs'
In reply to Otavio SalvadorThe sys_proto.h functions (except the boot modes) are compatible with i.MX233 and i.MX28 so we use 'mxs' prefix for its methods.
--- arch/arm/cpu/arm926ejs/mxs/mxs.c | 32 ++++++++++++++--------------- arch/arm/cpu/arm926ejs/mxs/spl_boot.c | 6 +++--- arch/arm/cpu/arm926ejs/mxs/timer.c | 2 +- arch/arm/include/asm/arch-mxs/sys_proto.h | 20 +++++++++--------- board/bluegiga/apx4devkit/apx4devkit.c | 2 +- drivers/dma/apbh_dma.c | 4 ++-- drivers/i2c/mxs_i2c.c | 2 +- drivers/mmc/mxsmmc.c | 2 +- drivers/mtd/nand/mxs_nand.c | 6 +++--- drivers/rtc/mxsrtc.c | 4 ++-- drivers/spi/mxs_spi.c | 8 ++++---- 11 files changed, 44 insertions(+), 44 deletions(-)
arch/arm/cpu/arm926ejs/mxs/mxs.c +16 -16
@@ -41,8 +41,8 @@ DECLARE_GLOBAL_DATA_PTR;/* 1 second delay should be plenty of time for block reset. */ #define RESET_MAX_TIMEOUT 1000000 -#define MX28_BLOCK_SFTRST (1 << 31) -#define MX28_BLOCK_CLKGATE (1 << 30) +#define MXS_BLOCK_SFTRST (1 << 31) +#define MXS_BLOCK_CLKGATE (1 << 30)/* Lowlevel init isn't used on i.MX28, so just have a dummy here */ inline void lowlevel_init (void ) {}
@@ -81,7 +81,7 @@ void enable_caches(void)#endif } -int mx28_wait_mask_set (struct mxs_register_32 *reg,uint32_t mask,int timeout) +int mxs_wait_mask_set (struct mxs_register_32 *reg,uint32_t mask,int timeout) {while (--timeout) {if ((readl (®->reg) & mask) == mask)
@@ -92,7 +92,7 @@ int mx28_wait_mask_set(struct mxs_register_32 *reg, uint32_t mask, int timeout)return !timeout; } -int mx28_wait_mask_clr (struct mxs_register_32 *reg,uint32_t mask,int timeout) +int mxs_wait_mask_clr (struct mxs_register_32 *reg,uint32_t mask,int timeout) {while (--timeout) {if ((readl (®->reg) & mask) ==0 )
@@ -103,34 +103,34 @@ int mx28_wait_mask_clr(struct mxs_register_32 *reg, uint32_t mask, int timeout)return !timeout; } -int mx28_reset_block (struct mxs_register_32 *reg) +int mxs_reset_block (struct mxs_register_32 *reg) {/* Clear SFTRST */ -writel (MX28_BLOCK_SFTRST , ®->reg_clr); +writel (MXS_BLOCK_SFTRST , ®->reg_clr); -if (mx28_wait_mask_clr (reg,MX28_BLOCK_SFTRST ,RESET_MAX_TIMEOUT )) +if (mxs_wait_mask_clr (reg,MXS_BLOCK_SFTRST ,RESET_MAX_TIMEOUT ))return 1 ;/* Clear CLKGATE */ -writel (MX28_BLOCK_CLKGATE , ®->reg_clr); +writel (MXS_BLOCK_CLKGATE , ®->reg_clr);/* Set SFTRST */ -writel (MX28_BLOCK_SFTRST , ®->reg_set); +writel (MXS_BLOCK_SFTRST , ®->reg_set);/* Wait for CLKGATE being set */ -if (mx28_wait_mask_set (reg,MX28_BLOCK_CLKGATE ,RESET_MAX_TIMEOUT )) +if (mxs_wait_mask_set (reg,MXS_BLOCK_CLKGATE ,RESET_MAX_TIMEOUT ))return 1 ;/* Clear SFTRST */ -writel (MX28_BLOCK_SFTRST , ®->reg_clr); +writel (MXS_BLOCK_SFTRST , ®->reg_clr); -if (mx28_wait_mask_clr (reg,MX28_BLOCK_SFTRST ,RESET_MAX_TIMEOUT )) +if (mxs_wait_mask_clr (reg,MXS_BLOCK_SFTRST ,RESET_MAX_TIMEOUT ))return 1 ;/* Clear CLKGATE */ -writel (MX28_BLOCK_CLKGATE , ®->reg_clr); +writel (MXS_BLOCK_CLKGATE , ®->reg_clr); -if (mx28_wait_mask_clr (reg,MX28_BLOCK_CLKGATE ,RESET_MAX_TIMEOUT )) +if (mxs_wait_mask_clr (reg,MXS_BLOCK_CLKGATE ,RESET_MAX_TIMEOUT ))return 1 ;return 0 ;
@@ -229,7 +229,7 @@ int print_cpuinfo(void)get_cpu_type (),get_cpu_rev (), mxc_get_clock(MXC_ARM_CLK) / 1000000); -printf ("BOOT: %s\n" , mx28_boot_modes[data->boot_mode_idx].mode); +printf ("BOOT: %s\n" , mxs_boot_modes[data->boot_mode_idx].mode); return 0; }#endif
@@ -299,7 +299,7 @@ void imx_get_mac_from_fuse(int dev_id, unsigned char *mac)writel (OCOTP_CTRL_RD_BANK_OPEN , &ocotp_regs->hw_ocotp_ctrl_set); -if (mx28_wait_mask_clr (&ocotp_regs->hw_ocotp_ctrl_reg,OCOTP_CTRL_BUSY , +if (mxs_wait_mask_clr (&ocotp_regs->hw_ocotp_ctrl_reg,OCOTP_CTRL_BUSY ,MXS_OCOTP_MAX_TIMEOUT )) {printf ("MXS FEC: Can't get MAC from OCOTP\n" );return ;
arch/arm/cpu/arm926ejs/mxs/spl_boot.c +3 -3
@@ -82,9 +82,9 @@ uint8_t mxs_get_bootmode_index(void) bootmode |= (gpio_get_value (MX28_PAD_LCD_D04__GPIO_1_4 ) ?1 :0 ) <<4 ; bootmode |= (gpio_get_value (MX28_PAD_LCD_D05__GPIO_1_5 ) ?1 :0 ) <<5 ; -for (i =0 ; i <ARRAY_SIZE (mx28_boot_modes); i++) { - masked = bootmode & mx28_boot_modes[i].boot_mask; -if (masked == mx28_boot_modes[i].boot_pads) +for (i =0 ; i <ARRAY_SIZE (mxs_boot_modes); i++) { + masked = bootmode & mxs_boot_modes[i].boot_mask; +if (masked == mxs_boot_modes[i].boot_pads)break ; }
arch/arm/cpu/arm926ejs/mxs/timer.c +1 -1
@@ -66,7 +66,7 @@ int timer_init(void) (struct mxs_timrot_regs *)MXS_TIMROT_BASE ;/* Reset Timers and Rotary Encoder module */ -mx28_reset_block (&timrot_regs->hw_timrot_rotctrl_reg); +mxs_reset_block (&timrot_regs->hw_timrot_rotctrl_reg);/* Set fixed_count to 0 */ writel (0 , &timrot_regs->hw_timrot_fixed_count0);
arch/arm/include/asm/arch-mxs/sys_proto.h +10 -10
@@ -1,5 +1,5 @@/* -* Freescale i.MX28 MX28 specific functions +* Freescale i.MX233/i.MX28 specific functions * * Copyright (C) 2011 Marek Vasut <[email protected]> * on behalf of DENX Software Engineering GmbH
@@ -20,14 +20,14 @@* */ -#ifndef __MX28_H__ -#define __MX28_H__ +#ifndef __SYS_PROTO_H__ +#define __SYS_PROTO_H__ -int mx28_reset_block (struct mxs_register_32 *reg); -int mx28_wait_mask_set (struct mxs_register_32 *reg, +int mxs_reset_block (struct mxs_register_32 *reg); +int mxs_wait_mask_set (struct mxs_register_32 *reg,uint32_t mask,int timeout); -int mx28_wait_mask_clr (struct mxs_register_32 *reg, +int mxs_wait_mask_clr (struct mxs_register_32 *reg,uint32_t mask,int timeout);
@@ -39,13 +39,13 @@ void mxs_common_spl_init(const iomux_cfg_t *iomux_setup, const unsigned int iomux_size);#endif -struct mx28_pair { +struct mxs_pair {uint8_t boot_pads;uint8_t boot_mask;const char *mode; }; -static const struct mx28_pair mx28_boot_modes[] = { +static const struct mxs_pair mxs_boot_modes[] = { {0x00 ,0x0f ,"USB #0" }, {0x01 ,0x1f ,"I2C #0, master, 3V3" }, {0x11 ,0x1f ,"I2C #0, master, 1V8" },
@@ -69,6 +69,6 @@ struct mxs_spl_data { uint32_t mem_dram_size; }; -int mx28_dram_init (void ); +int mxs_dram_init (void ); -#endif /* __MX28_H__ */ +#endif /* __SYS_PROTO_H__ */
board/bluegiga/apx4devkit/apx4devkit.c +1 -1
@@ -130,7 +130,7 @@ void get_board_serial(struct tag_serialnr *serialnr)writel (OCOTP_CTRL_RD_BANK_OPEN , &ocotp_regs->hw_ocotp_ctrl_set); -if (mx28_wait_mask_clr (&ocotp_regs->hw_ocotp_ctrl_reg,OCOTP_CTRL_BUSY , +if (mxs_wait_mask_clr (&ocotp_regs->hw_ocotp_ctrl_reg,OCOTP_CTRL_BUSY ,MXS_OCOTP_MAX_TIMEOUT )) {printf ("MXS: Can't get serial number from OCOTP\n" );return ;
drivers/dma/apbh_dma.c +2 -2
@@ -512,7 +512,7 @@ static int mxs_dma_wait_complete(uint32_t timeout, unsigned int chan)if (ret)return ret; -if (mx28_wait_mask_set (&apbh_regs->hw_apbh_ctrl1_reg, +if (mxs_wait_mask_set (&apbh_regs->hw_apbh_ctrl1_reg,1 << chan, timeout)) { ret = -ETIMEDOUT ;mxs_dma_reset (chan);
@@ -557,7 +557,7 @@ void mxs_dma_init(void)struct mxs_apbh_regs *apbh_regs = (struct mxs_apbh_regs *)MXS_APBH_BASE ; -mx28_reset_block (&apbh_regs->hw_apbh_ctrl0_reg); +mxs_reset_block (&apbh_regs->hw_apbh_ctrl0_reg);#ifdef CONFIG_APBH_DMA_BURST8 writel(APBH_CTRL0_AHB_BURST8_EN,
drivers/i2c/mxs_i2c.c +1 -1
@@ -41,7 +41,7 @@ void mxs_i2c_reset(void)struct mxs_i2c_regs *i2c_regs = (struct mxs_i2c_regs *)MXS_I2C0_BASE ;int ret; - ret =mx28_reset_block (&i2c_regs->hw_i2c_ctrl0_reg); + ret =mxs_reset_block (&i2c_regs->hw_i2c_ctrl0_reg);if (ret) {debug ("MXS I2C: Block reset timeout\n" );return ;
drivers/mmc/mxsmmc.c +1 -1
@@ -336,7 +336,7 @@ static int mxsmmc_init(struct mmc *mmc)struct mxs_ssp_regs *ssp_regs = priv->regs;/* Reset SSP */ -mx28_reset_block (&ssp_regs->hw_ssp_ctrl0_reg); +mxs_reset_block (&ssp_regs->hw_ssp_ctrl0_reg);/* 8 bits word length in MMC mode */ clrsetbits_le32(&ssp_regs->hw_ssp_ctrl1,
drivers/mtd/nand/mxs_nand.c +3 -3
@@ -237,7 +237,7 @@ static int mxs_nand_wait_for_bch_complete(void)int timeout =MXS_NAND_BCH_TIMEOUT ;int ret; - ret =mx28_wait_mask_set (&bch_regs->hw_bch_ctrl_reg, + ret =mxs_wait_mask_set (&bch_regs->hw_bch_ctrl_reg,BCH_CTRL_COMPLETE_IRQ , timeout);writel (BCH_CTRL_COMPLETE_IRQ , &bch_regs->hw_bch_ctrl_clr);
@@ -972,7 +972,7 @@ static int mxs_nand_scan_bbt(struct mtd_info *mtd)uint32_t tmp;/* Configure BCH and set NFC geometry */ -mx28_reset_block (&bch_regs->hw_bch_ctrl_reg); +mxs_reset_block (&bch_regs->hw_bch_ctrl_reg);/* Configure layout 0 */ tmp = (mxs_nand_ecc_chunk_cnt (mtd->writesize) -1 )
@@ -1080,7 +1080,7 @@ int mxs_nand_init(struct mxs_nand_info *info) }/* Reset the GPMI block. */ -mx28_reset_block (&gpmi_regs->hw_gpmi_ctrl0_reg); +mxs_reset_block (&gpmi_regs->hw_gpmi_ctrl0_reg);/* * Choose NAND mode, set IRQ polarity, disable write protection and
drivers/rtc/mxsrtc.c +2 -2
@@ -41,7 +41,7 @@ int mxs_rtc_set_time(uint32_t secs)* is taken from the linux kernel driver for the STMP37xx RTC since * documentation doesn't mention it. */ - ret =mx28_wait_mask_clr (&rtc_regs->hw_rtc_stat_reg, + ret =mxs_wait_mask_clr (&rtc_regs->hw_rtc_stat_reg,0x80 <<RTC_STAT_STALE_REGS_OFFSET ,MXS_RTC_MAX_TIMEOUT );if (ret)
@@ -80,7 +80,7 @@ void rtc_reset(void)mxs_rtc_set_time (0 );/* Reset the RTC block */ - ret =mx28_reset_block (&rtc_regs->hw_rtc_ctrl_reg); + ret =mxs_reset_block (&rtc_regs->hw_rtc_ctrl_reg);if (ret)printf ("MXS RTC: Block reset timeout\n" ); }
drivers/spi/mxs_spi.c +4 -4
@@ -139,7 +139,7 @@ int spi_claim_bus(struct spi_slave *slave)struct mxs_ssp_regs *ssp_regs = mxs_slave->regs;uint32_t reg =0 ; -mx28_reset_block (&ssp_regs->hw_ssp_ctrl0_reg); +mxs_reset_block (&ssp_regs->hw_ssp_ctrl0_reg);writel (SSP_CTRL0_BUS_WIDTH_ONE_BIT , &ssp_regs->hw_ssp_ctrl0);
@@ -193,7 +193,7 @@ static int mxs_spi_xfer_pio(struct mxs_spi_slave *slave,writel (SSP_CTRL0_RUN , &ssp_regs->hw_ssp_ctrl0_set); -if (mx28_wait_mask_set (&ssp_regs->hw_ssp_ctrl0_reg, +if (mxs_wait_mask_set (&ssp_regs->hw_ssp_ctrl0_reg,SSP_CTRL0_RUN ,MXS_SPI_MAX_TIMEOUT )) {printf ("MXS SPI: Timeout waiting for start\n" );return -ETIMEDOUT ;
@@ -205,7 +205,7 @@ static int mxs_spi_xfer_pio(struct mxs_spi_slave *slave,writel (SSP_CTRL0_DATA_XFER , &ssp_regs->hw_ssp_ctrl0_set);if (!write) { -if (mx28_wait_mask_clr (&ssp_regs->hw_ssp_status_reg, +if (mxs_wait_mask_clr (&ssp_regs->hw_ssp_status_reg,SSP_STATUS_FIFO_EMPTY ,MXS_SPI_MAX_TIMEOUT )) {printf ("MXS SPI: Timeout waiting for data\n" );return -ETIMEDOUT ;
@@ -215,7 +215,7 @@ static int mxs_spi_xfer_pio(struct mxs_spi_slave *slave, data++; } -if (mx28_wait_mask_clr (&ssp_regs->hw_ssp_ctrl0_reg, +if (mxs_wait_mask_clr (&ssp_regs->hw_ssp_ctrl0_reg,SSP_CTRL0_RUN ,MXS_SPI_MAX_TIMEOUT )) {printf ("MXS SPI: Timeout waiting for finish\n" );return -ETIMEDOUT ;
Signature · 1 line
1.7.10.4
PATCH 3/3 mxs: Convert sys_proto.h prefixes to 'mxs'
Dear Otavio Salvador,
[...]
Quoted 5 lines
(quoted diff) +0
-0
b/arch/arm/cpu/arm926ejs/mxs/spl_boot.cindex 84d4a17..ddafddb 100644
arch/arm/cpu/arm926ejs/mxs/spl_boot.c uint8_t mxs_get_bootmode_index(void) · line 87
Quoted 9 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c +3
-3@@ -82,9 +82,9 @@ uint8_t mxs_get_bootmode_index(void) bootmode |= (gpio_get_value (MX28_PAD_LCD_D04__GPIO_1_4 ) ?1 :0 ) <<4 ; bootmode |= (gpio_get_value (MX28_PAD_LCD_D05__GPIO_1_5 ) ?1 :0 ) <<5 ; -for (i =0 ; i <ARRAY_SIZE (mx28_boot_modes); i++) { - masked = bootmode & mx28_boot_modes[i].boot_mask; -if (masked == mx28_boot_modes[i].boot_pads) +for (i =0 ; i <ARRAY_SIZE (mxs_boot_modes); i++) { + masked = bootmode & mxs_boot_modes[i].boot_mask; +if (masked == mxs_boot_modes[i].boot_pads)
mxs_boot_modes? They're different for mx23 and mx28!
arch/arm/cpu/arm926ejs/mxs/spl_boot.c uint8_t mxs_get_bootmode_index(void) · line 90
Quoted 3 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c +0
-0break ; }
[...]
Rest seems fine
Best regards,
Marek Vasut
PATCH 3/3 mxs: Convert sys_proto.h prefixes to 'mxs'
Quoted 12 lines · Marek Vasut
Dear Otavio Salvador,
[...]
Quoted 8 lines
(quoted diff) +0
-0
b/arch/arm/cpu/arm926ejs/mxs/spl_boot.cindex 84d4a17..ddafddb 100644arch/arm/cpu/arm926ejs/mxs/spl_boot.c +0
-0@@ -82,9 +82,9 @@ uint8_t mxs_get_bootmode_index(void) bootmode |= (gpio_get_value (MX28_PAD_LCD_D04__GPIO_1_4 ) ?1 :0 ) <<4 ; bootmode |= (gpio_get_value (MX28_PAD_LCD_D05__GPIO_1_5 ) ?1 :0 ) <<5 ;
Quoted 8 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c uint8_t mxs_get_bootmode_index(void) · line 87
Quoted 6 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c +3
-3-for (i =0 ; i <ARRAY_SIZE (mx28_boot_modes); i++) { - masked = bootmode & mx28_boot_modes[i].boot_mask; -if (masked == mx28_boot_modes[i].boot_pads) +for (i =0 ; i <ARRAY_SIZE (mxs_boot_modes); i++) { + masked = bootmode & mxs_boot_modes[i].boot_mask; +if (masked == mxs_boot_modes[i].boot_pads)
mxs_boot_modes? They're different for mx23 and mx28!
Yes, they're but the structure is the same so we can use same symbol and have a different mxs_boot_modes matrix for each.
Quoted 9 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c uint8_t mxs_get_bootmode_index(void) · line 90
Quoted 3 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c +0
-0break ; }[...]
Rest seems fine
Best regards,
Marek Vasut
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
PATCH 3/3 mxs: Convert sys_proto.h prefixes to 'mxs'
Dear Otavio Salvador,
Quoted 24 lines · Marek Vasut
Quoted 14 lines
Dear Otavio Salvador,
[...]
Quoted 10 lines
(quoted diff) +0
-0
b/arch/arm/cpu/arm926ejs/mxs/spl_boot.cindex 84d4a17..ddafddb 100644arch/arm/cpu/arm926ejs/mxs/spl_boot.c +0
-0@@ -82,9 +82,9 @@ uint8_t mxs_get_bootmode_index(void) bootmode |= (gpio_get_value (MX28_PAD_LCD_D04__GPIO_1_4 ) ?1 :0 ) <<4 ; bootmode |= (gpio_get_value (MX28_PAD_LCD_D05__GPIO_1_5 ) ?1 :0 ) <<5 ;Quoted 8 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c uint8_t mxs_get_bootmode_index(void) · line 87
Quoted 6 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c +3
-3-for (i =0 ; i <ARRAY_SIZE (mx28_boot_modes); i++) { - masked = bootmode & mx28_boot_modes[i].boot_mask; -if (masked == mx28_boot_modes[i].boot_pads) +for (i =0 ; i <ARRAY_SIZE (mxs_boot_modes); i++) { + masked = bootmode & mxs_boot_modes[i].boot_mask; +if (masked == mxs_boot_modes[i].boot_pads)
mxs_boot_modes? They're different for mx23 and mx28!
Quoted 2 lines
Yes, they're but the structure is the same so we can use same symbol and have a different
mxs_boot_modesmatrix for each.
Unless we want a single image for mx233 and mx28. Oh well ... for now
Quoted 10 lines
Quoted 10 lines
Quoted 3 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c +0
-0break ;}[...]
Rest seems fine
Best regards,
Marek Vasut
Best regards,
Marek Vasut
PATCH 3/3 mxs: Convert sys_proto.h prefixes to 'mxs'
Quoted 7 lines · Marek Vasut
Quoted 7 lines
Quoted 7 lines
Quoted 6 lines
arch/arm/cpu/arm926ejs/mxs/spl_boot.c +3
-3-for (i =0 ; i <ARRAY_SIZE (mx28_boot_modes); i++) { - masked = bootmode & mx28_boot_modes[i].boot_mask; -if (masked == mx28_boot_modes[i].boot_pads) +for (i =0 ; i <ARRAY_SIZE (mxs_boot_modes); i++) { + masked = bootmode & mxs_boot_modes[i].boot_mask; +if (masked == mxs_boot_modes[i].boot_pads)
Quoted 6 lines
Quoted 4 lines
Quoted 1 line
mxs_boot_modes? They're different for mx23 and mx28!Yes, they're but the structure is the same so we can use same symbol and have a different
mxs_boot_modesmatrix for each.Unless we want a single image for mx233 and mx28. Oh well ... for now
What do you mean by single image?
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
PATCH 1/3 mxs: Remove unused iomux-mx28.h
In reply to Otavio SalvadorDear Otavio Salvador,
Fix the subject, you're not removing the file ... otherwise Acked.
Quoted 13 lines
The
iomux-mx28.hinclude is not required onspl_mem_init.cso it has been droped.Signed-off-by Otavio Salvador <[email protected]>--- arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c | 1 - 1 file changed, 1 deletion(-)(quoted diff) +0
-0
b/arch/arm/cpu/arm926ejs/mxs/spl_mem_init.cindex 88d1abe..e693145 100644
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c line 31
Quoted 7 lines
arch/arm/cpu/arm926ejs/mxs/spl_mem_init.c +0
-1@@ -26,7 +26,6 @@#include <common.h> #include <config.h> #include <asm/io.h> -#include <asm/arch/iomux-mx28.h> #include <asm/arch/imx-regs.h> #include "mxs_init.h"
Best regards,
Marek Vasut