staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb_info
PATCH v2 1/1 staging: sm7xxfb: copy name of the device before calling smtc_alloc_fb_info
as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in sm7xxx_probe is not having any assignment, and which leads to copying of the garbage value into the id field of the fix struct of fb interface struct. fix it by copying the name before calling alloc_fbinfo.
---
Changes since V1:
Fix a null deref when smtc_alloc_fbinfo fails, this was added by me in V1.
drivers/staging/sm7xxfb/sm7xxfb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/sm7xxfb/sm7xxfb.c +2 -2
@@ -798,6 +798,8 @@ static int __devinit smtcfb_pci_probe(struct pci_dev *pdev,if (err)return err; +sprintf (name,"sm%Xfb" , ent->device); + sfb =smtc_alloc_fb_info (pdev, name);if (!sfb) {
@@ -806,8 +808,6 @@ static int __devinit smtcfb_pci_probe(struct pci_dev *pdev, } sfb->chip_id = ent->device; -sprintf (name,"sm%Xfb" , sfb->chip_id); -pci_set_drvdata (pdev, sfb);sm7xx_init_hw ();
Signature · 1 line
1.7.9.5
Greg Kroah-Hartman
maintainerQuoted 10 lines · Devendra Naga
as we do a
strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here insm7xxx_probeis not having any assignment, and which leads to copying of the garbage value into the id field of the fix struct of fb interface struct. fix it by copying the name before callingalloc_fbinfo.Signed-off-by Devendra Naga <[email protected]>---
Changes since V1:
Fix a null deref whensmtc_alloc_fbinfofails, this was added by me in V1.
Huh? Please resend the correct patch you want me to apply, I'm confused here.
greg k-h