Skip to contentSkip to conversation

kvm: drop parameter validation

PATCH Applied Michael S. Tsirkin 2 participants 2 messages Aug 14, 2012 – Aug 15, 2012

Subsystems (3)
x86 KVM KVM x86
lore
Share & tools
lore

Michael S. Tsirkin

author
#0 lore raw

PATCH v2 1/1 kvm: drop parameter validation

We validate irq pin number when routing is setup, so code handling illegal irq # in pic and ioapic on each injection is never called.
Drop it, replace with BUG_ON to catch out of bounds access bugs.

Signed-off-by Michael S. Tsirkin <[email protected]>

---

Changes from v1:
add BUG_ON at Gleb's suggestion

 arch/x86/kvm/i8259.c | 18 +++++++++---------
 virt/kvm/ioapic.c    | 37 +++++++++++++++++++------------------
 2 files changed, 28 insertions(+), 27 deletions(-)
arch/x86/kvm/i8259.c +9 -9
index e498b18..90c84f9 100644
@@ -190,17 +190,17 @@ void kvm_pic_update_irq(struct kvm_pic *s)
 
 int kvm_pic_set_irq(struct kvm_pic *s, int irq, int irq_source_id, int level)
 {
-	int ret = -1;
+	int ret, irq_level;
+
+	BUG_ON(irq < 0 || irq >= PIC_NUM_PINS);
 
 	pic_lock(s);
-	if (irq >= 0 && irq < PIC_NUM_PINS) {
-		int irq_level = __kvm_irq_line_state(&s->irq_states[irq],
-						     irq_source_id, level);
-		ret = pic_set_irq1(&s->pics[irq >> 3], irq & 7, irq_level);
-		pic_update_irq(s);
-		trace_kvm_pic_set_irq(irq >> 3, irq & 7, s->pics[irq >> 3].elcr,
-				      s->pics[irq >> 3].imr, ret == 0);
-	}
+	irq_level = __kvm_irq_line_state(&s->irq_states[irq],
+					 irq_source_id, level);
+	ret = pic_set_irq1(&s->pics[irq >> 3], irq & 7, irq_level);
+	pic_update_irq(s);
+	trace_kvm_pic_set_irq(irq >> 3, irq & 7, s->pics[irq >> 3].elcr,
+			      s->pics[irq >> 3].imr, ret == 0);
 	pic_unlock(s);
 
 	return ret;
virt/kvm/ioapic.c +19 -18
index ef61d52..cfb7e4d 100644
@@ -197,28 +197,29 @@ int kvm_ioapic_set_irq(struct kvm_ioapic *ioapic, int irq, int irq_source_id,
 	u32 old_irr;
 	u32 mask = 1 << irq;
 	union kvm_ioapic_redirect_entry entry;
-	int ret = 1;
+	int ret, irq_level;
+
+	BUG_ON(irq < 0 || irq >= IOAPIC_NUM_PINS);
 
 	spin_lock(&ioapic->lock);
 	old_irr = ioapic->irr;
-	if (irq >= 0 && irq < IOAPIC_NUM_PINS) {
-		int irq_level = __kvm_irq_line_state(&ioapic->irq_states[irq],
-						     irq_source_id, level);
-		entry = ioapic->redirtbl[irq];
-		irq_level ^= entry.fields.polarity;
-		if (!irq_level)
-			ioapic->irr &= ~mask;
-		else {
-			int edge = (entry.fields.trig_mode == IOAPIC_EDGE_TRIG);
-			ioapic->irr |= mask;
-			if ((edge && old_irr != ioapic->irr) ||
-			    (!edge && !entry.fields.remote_irr))
-				ret = ioapic_service(ioapic, irq);
-			else
-				ret = 0; /* report coalesced interrupt */
-		}
-		trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
+	irq_level = __kvm_irq_line_state(&ioapic->irq_states[irq],
+					 irq_source_id, level);
+	entry = ioapic->redirtbl[irq];
+	irq_level ^= entry.fields.polarity;
+	if (!irq_level) {
+		ioapic->irr &= ~mask;
+		ret = 1;
+	} else {
+		int edge = (entry.fields.trig_mode == IOAPIC_EDGE_TRIG);
+		ioapic->irr |= mask;
+		if ((edge && old_irr != ioapic->irr) ||
+		    (!edge && !entry.fields.remote_irr))
+			ret = ioapic_service(ioapic, irq);
+		else
+			ret = 0; /* report coalesced interrupt */
 	}
+	trace_kvm_ioapic_set_irq(entry.bits, irq, ret == 0);
 	spin_unlock(&ioapic->lock);
 
 	return ret;
Signature · 1 line
MST
Applied
#1 lore raw
Quoted 6 lines · Michael S. Tsirkin

We validate irq pin number when routing is setup, so code handling illegal irq # in pic and ioapic on each injection is never called.
Drop it, replace with BUG_ON to catch out of bounds access bugs.

Signed-off-by Michael S. Tsirkin <[email protected]>
Quoted 8 lines

---

Changes from v1:
add BUG_ON at Gleb's suggestion

 arch/x86/kvm/i8259.c | 18 +++++++++---------
 virt/kvm/ioapic.c    | 37 +++++++++++++++++++------------------
 2 files changed, 28 insertions(+), 27 deletions(-)

Applied, thanks.