Skip to contentSkip to conversation

COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake

PATCH New Marek Vasut 2 participants 3 messages Aug 14, 2012 Kbuild

lore
Share & tools
lore

Marek Vasut

author
#0 lore raw

PATCH 1/1 COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake

The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated " y" instead of "y", causing the vendor lib not being built. This in turn made some spear boards and nvidia boards broken.

Signed-off-by Marek Vasut <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -1
index 5ce5cc3..947f3ff 100644
@@ -225,7 +225,7 @@ endif
 
 OBJS := $(addprefix $(obj),$(OBJS))
 
-HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile), y, n)
+HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile),y,n)
 
 LIBS-y += lib/libgeneric.o
 LIBS-y += lib/lzma/liblzma.o
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake

Hi Marek,

2012/8/14 Marek Vasut <[email protected]>:

Quoted 25 lines

The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated " y" instead of "y", causing the vendor lib not being built. This in turn made some spear boards and nvidia boards broken.

Signed-off-by Marek Vasut <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Daniel Schwierzeck <[email protected]>
---
 Makefile |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Makefile +1 -2
index 5ce5cc3..947f3ff 100644
@@ -225,7 +225,7 @@ endif
 
 OBJS := $(addprefix $(obj),$(OBJS))
 
-HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile), y, n)
+HAVE_VENDOR_COMMON_LIB = $(if $(wildcard board/$(VENDOR)/common/Makefile),y,n)
 
 LIBS-y += lib/libgeneric.o
 LIBS-y += lib/lzma/liblzma.o
--
Quoted 2 lines

1.7.10.4

there is already a patch for this
http://patchwork.ozlabs.org/patch/177235/

sorry for the inconvenience

Signature · 2 lines
Best regards,
Daniel
author
#2 lore raw

PATCH 1/1 COMMON: Fix HAVE_VENDOR_COMMON_LIB mistake

Dear Daniel Schwierzeck,

Quoted 10 lines

Hi Marek,

2012/8/14 Marek Vasut <[email protected]>:

Quoted 7 lines

The conditional clause assigning HAVE_VENDOR_COMMON_LIB generated " y" instead of "y", causing the vendor lib not being built. This in turn made some spear boards and nvidia boards broken.

Signed-off-by Marek Vasut <[email protected]>
Cc Wolfgang Denk <[email protected]>
Cc Daniel Schwierzeck <[email protected]>

[..]

Quoted 4 lines

there is already a patch for this
http://patchwork.ozlabs.org/patch/177235/

sorry for the inconvenience

That's ok, don't sweat it :)

Your patch is better, thanks Dan!

Best regards,
Marek Vasut