Skip to contentSkip to conversation

drm_fb_helper.c:1247:1-8: alloc with no test

DISCUSSION Fengguang Wu 1 participant 1 message Aug 17, 2012 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hi Daniel,

FYI, here is a potential problem on memory allocation failure, caught by coccinelle:

+ drivers/gpu/drm/drm_fb_helper.c:1247:1-8: alloc with no test, possible model on line 1252

vim +1247 drivers/gpu/drm/drm_fb_helper.c
1244 sizeof(struct drm_fb_helper_crtc *), GFP_KERNEL);
1245 modes = kcalloc(dev->mode_config.num_connector,
1246 sizeof(struct drm_display_mode *), GFP_KERNEL);

Quoted 1 line

1247 enabled = kcalloc(dev->mode_config.num_connector,

1248 sizeof(bool), GFP_KERNEL);
1249
1250 drm_enable_connectors(fb_helper, enabled);

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation