patman feature request
Hey,
It looks like today was the day that Joe and I both decided to give patman a whirl. On IRC we both hit the same annoyance of commits like:
"Cosmetic: Something" causing patman to look for a maintainer for cosmetic and failing fatally. Could we please make maintainer alias not found a warning and not a fatal error (so the human can go "oh, that's not a real area, that's fine" ? My ~/.patman is almost more fixups than real aliases.
Signature · 1 line
Tom
Quoted 7 lines · Tom Rini
It looks like today was the day that Joe and I both decided to give patman a whirl. On IRC we both hit the same annoyance of commits like:
"Cosmetic: Something" causing patman to look for a maintainer for cosmetic and failing fatally. Could we please make maintainer alias not found a warning and not a fatal error (so the human can go "oh, that's not a real area, that's fine" ? My ~/.patman is almost more fixups than real aliases.
I agree; I have also sent two minor fixes to patman and I've been putting fixups on my .patman to make it run and it does seem it would work better if it was an warn.
Another idea is to have a wildcard that matches as a fallback.
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Hi,
Quoted 9 lines · Otavio Salvador
Quoted 7 lines · Tom Rini
It looks like today was the day that Joe and I both decided to give patman a whirl. On IRC we both hit the same annoyance of commits like:
"Cosmetic: Something" causing patman to look for a maintainer for cosmetic and failing fatally. Could we please make maintainer alias not found a warning and not a fatal error (so the human can go "oh, that's not a real area, that's fine" ? My ~/.patman is almost more fixups than real aliases.
Quoted 3 lines
I agree; I have also sent two minor fixes to patman and I've been putting fixups on my .patman to make it run and it does seem it would work better if it was an warn.
Yes I like the idea of a warning instead of an error. It annoys me too sometimes, although I do use it as a check against adding a tag that no one has heard of.
Quoted 3 lines
Another idea is to have a wildcard that matches as a fallback.
I suppose wildcards matches might be useful - could be overkill though.
Regards,
Simon
Quoted 4 lines
--
Otavio SalvadorO.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
Quoted 15 lines · Simon Glass
Quoted 9 lines · Otavio Salvador
Quoted 7 lines · Tom Rini
It looks like today was the day that Joe and I both decided to give patman a whirl. On IRC we both hit the same annoyance of commits like:
"Cosmetic: Something" causing patman to look for a maintainer for cosmetic and failing fatally. Could we please make maintainer alias not found a warning and not a fatal error (so the human can go "oh, that's not a real area, that's fine" ? My ~/.patman is almost more fixups than real aliases.Quoted 3 lines
I agree; I have also sent two minor fixes to patman and I've been putting fixups on my .patman to make it run and it does seem it would work better if it was an warn.
Quoted 7 lines
Yes I like the idea of a warning instead of an error. It annoys me too sometimes, although I do use it as a check against adding a tag that no one has heard of.
Quoted 1 line
Another idea is to have a wildcard that matches as a fallback.
I suppose wildcards matches might be useful - could be overkill though.
Maybe the .patman might support a regexp for the tag; this way we can have things like:
mx[s5]: ...
Signature · 3 lines
Otavio Salvador O.S. Systems E-mail: otavio at ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br