Skip to contentSkip to conversation

snd-als100: fix suspend/resume

PATCH In review Ondrej Zary 2 participants 2 messages Aug 20, 2012 – Aug 21, 2012 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 snd-als100: fix suspend/resume

snd_card_als100_probe() does not set pcm field in struct snd_sb. As a result, PCM is not suspended and applications don't know that they need to resume the playback.

Tested with Labway A381-F20 card (ALS120).

sound/isa/als100.c +1 -1
@@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
 			irq[dev], dma8[dev], dma16[dev]);
 	}
 
-	if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
+	if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
 		snd_card_free(card);
 		return error;
 	}
Signature · 1 line
Ondrej Zary
#1 lore raw

At Mon, 20 Aug 2012 21:50:13 +0200,

Quoted 8 lines · Ondrej Zary

snd_card_als100_probe() does not set pcm field in struct snd_sb. As a result, PCM is not suspended and applications don't know that they need to resume the playback.

Tested with Labway A381-F20 card (ALS120).

Applied now. Thanks.

Takashi

Quoted 23 lines
sound/isa/als100.c +1 -1
@@ -233,7 +233,7 @@ static int __devinit snd_card_als100_probe(int dev,
 			irq[dev], dma8[dev], dma16[dev]);
 	}
 
-	if ((error = snd_sb16dsp_pcm(chip, 0, NULL)) < 0) {
+	if ((error = snd_sb16dsp_pcm(chip, 0, &chip->pcm)) < 0) {
 		snd_card_free(card);
 		return error;
 	}
Signature · 6 lines
-- 
Ondrej Zary
_______________________________________________
Alsa-devel mailing list
[email protected]
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel