iio: lm3533-als: Fix build warnings

PATCH In review Axel Lin 3 participants 3 messages Aug 2, 2012 – Aug 22, 2012 IIO

Share & tools

Axel Lin

author

2012-08-02 10:10 UTC #0 lore raw

PATCH 1/1 iio: lm3533-als: Fix build warnings

Fix below build warnings:
CC [M] drivers/iio/light/lm3533-als.o
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]

Signed-off-by Axel Lin <[email protected]>

---
 drivers/iio/light/lm3533-als.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/iio/light/lm3533-als.c +2 -2

index c3e7bac..e45712a9 100644
@@ -404,7 +404,7 @@ out:
 	return ret;
 }
 
-static int show_thresh_either_en(struct device *dev,
+static ssize_t show_thresh_either_en(struct device *dev,
 					struct device_attribute *attr,
 					char *buf)
 {

@@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
 	return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
 }
 
-static int store_thresh_either_en(struct device *dev,
+static ssize_t store_thresh_either_en(struct device *dev,
 					struct device_attribute *attr,
 					const char *buf, size_t len)
 {

Signature · 1 line

1.7.9.5

Jonathan Cameron

maintainer

2012-08-14 20:29 UTC #1 lore raw

Quoted 8 lines · Axel Lin

Fix below build warnings:
CC [M] drivers/iio/light/lm3533-als.o
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
Signed-off-by Axel Lin <[email protected]>

Thanks queued up.

Quoted 27 lines

---
 drivers/iio/light/lm3533-als.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/iio/light/lm3533-als.c +2 -2

index c3e7bac..e45712a9 100644
@@ -404,7 +404,7 @@ out:
 	return ret;
 }
 
-static int show_thresh_either_en(struct device *dev,
+static ssize_t show_thresh_either_en(struct device *dev,
 					struct device_attribute *attr,
 					char *buf)
 {

@@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
 	return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
 }
 
-static int store_thresh_either_en(struct device *dev,
+static ssize_t store_thresh_either_en(struct device *dev,
 					struct device_attribute *attr,
 					const char *buf, size_t len)
 {

Johan Hovold

2012-08-22 09:48 UTC #2 lore raw

Quoted 10 lines · Jonathan Cameron

Quoted 8 lines · Axel Lin
Fix below build warnings:
CC [M] drivers/iio/light/lm3533-als.o
drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.show') [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: initialization from incompatible pointer type [enabled by default] drivers/iio/light/lm3533-als.c:667:8: warning: (near initialization for 'dev_attr_in_illuminance0_thresh_either_en.store') [enabled by default]
Signed-off-by Axel Lin <[email protected]>
Thanks queued up.

Thanks for fixing this and sorry for not responding sooner (vacation...).

Johan

Quoted 27 lines

---
 drivers/iio/light/lm3533-als.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/iio/light/lm3533-als.c +2 -2

index c3e7bac..e45712a9 100644
@@ -404,7 +404,7 @@ out:
 	return ret;
 }
 
-static int show_thresh_either_en(struct device *dev,
+static ssize_t show_thresh_either_en(struct device *dev,
 					struct device_attribute *attr,
 					char *buf)
 {

@@ -424,7 +424,7 @@ static int show_thresh_either_en(struct device *dev,
 	return scnprintf(buf, PAGE_SIZE, "%u\n", enable);
 }
 
-static int store_thresh_either_en(struct device *dev,
+static ssize_t store_thresh_either_en(struct device *dev,
 					struct device_attribute *attr,
 					const char *buf, size_t len)
 {