Skip to contentSkip to conversation

Document the --done option.

PATCH In review Eric S. Raymond 3 participants 5 messages Jun 15, 2016 Documentation

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Document the --done option.

---
 Documentation/git-fast-import.txt |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Documentation/git-fast-import.txt +7 -1
index 2620d28..9291ea0 100644
@@ -39,6 +39,10 @@ OPTIONS
 	See ``Date Formats'' below for details about which formats
 	are supported, and their syntax.
 
+-- done::
+	Terminate with error if there is no 'done' command at the 
+	end of the stream.
+
 --force::
 	Force updating modified existing branches, even if doing
 	so would cause commits to be lost (as the new commit does
@@ -1047,7 +1051,9 @@ done::
 	Error out if the stream ends without a 'done' command.
 	Without this feature, errors causing the frontend to end
 	abruptly at a convenient point in the stream can go
-	undetected.
+	undetected.  This may occur, for example, if an import
+	front end dies in mid-operation without emitting SIGTERM
+	or SIGKILL at its subordinate git fast-import instance.
 
 `option`
 ~~~~~~~~
Signature · 5 lines
1.7.9.5


-- 
		<a href="http://www.catb.org/~esr/">Eric S. Raymond</a>
#1 lore raw
Quoted 1 line · Eric S. Raymond

---

A forgotten Sign-off?

Sverre, the text matches my understanding as well as what be56862 (fast-import: introduce 'done' command, 2011-07-16) says it did. Ack?

Quoted 31 lines
 Documentation/git-fast-import.txt |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Documentation/git-fast-import.txt +7 -1
index 2620d28..9291ea0 100644
@@ -39,6 +39,10 @@ OPTIONS
 	See ``Date Formats'' below for details about which formats
 	are supported, and their syntax.
 
+-- done::
+	Terminate with error if there is no 'done' command at the 
+	end of the stream.
+
 --force::
 	Force updating modified existing branches, even if doing
 	so would cause commits to be lost (as the new commit does
@@ -1047,7 +1051,9 @@ done::
 	Error out if the stream ends without a 'done' command.
 	Without this feature, errors causing the frontend to end
 	abruptly at a convenient point in the stream can go
-	undetected.
+	undetected.  This may occur, for example, if an import
+	front end dies in mid-operation without emitting SIGTERM
+	or SIGKILL at its subordinate git fast-import instance.
 
 `option`
 ~~~~~~~~
Signature · 1 line
1.7.9.5
#2 lore raw
Quoted 9 lines · Junio C Hamano
Quoted 1 line · Eric S. Raymond

---

A forgotten Sign-off?

Sverre, the text matches my understanding as well as what be56862 (fast-import: introduce 'done' command, 2011-07-16) says it did. Ack?

Signature · 3 lines
Cheers,

Sverre Rabbelier
#3 lore raw
In reply to Junio C Hamano
Quoted 5 lines · Junio C Hamano
Quoted 1 line · Eric S. Raymond

---

A forgotten Sign-off?

Ping? Just telling us that this is Signed-off is fine.

Thanks.

Quoted 36 lines

Sverre, the text matches my understanding as well as what be56862 (fast-import: introduce 'done' command, 2011-07-16) says it did. Ack?

Quoted 31 lines
 Documentation/git-fast-import.txt |    8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
Documentation/git-fast-import.txt +7 -1
index 2620d28..9291ea0 100644
@@ -39,6 +39,10 @@ OPTIONS
 	See ``Date Formats'' below for details about which formats
 	are supported, and their syntax.
 
+-- done::
+	Terminate with error if there is no 'done' command at the 
+	end of the stream.
+
 --force::
 	Force updating modified existing branches, even if doing
 	so would cause commits to be lost (as the new commit does
@@ -1047,7 +1051,9 @@ done::
 	Error out if the stream ends without a 'done' command.
 	Without this feature, errors causing the frontend to end
 	abruptly at a convenient point in the stream can go
-	undetected.
+	undetected.  This may occur, for example, if an import
+	front end dies in mid-operation without emitting SIGTERM
+	or SIGKILL at its subordinate git fast-import instance.
 
 `option`
 ~~~~~~~~
Signature · 1 line
1.7.9.5
#4 lore raw
Quoted 9 lines · Junio C Hamano
Quoted 5 lines · Junio C Hamano
Quoted 1 line · Eric S. Raymond

---

A forgotten Sign-off?

Ping? Just telling us that this is Signed-off is fine.

Ping again.