Skip to contentSkip to conversation

ipvs: Fix GSO support for IPVS DR IPv6 mode

PATCH New Jesper Dangaard Brouer 1 participant 1 message Aug 22, 2012

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ipvs: Fix GSO support for IPVS DR IPv6 mode

The MTU check in ip_vs_dr_xmit_v6() were missing a check for skb_is_gso().

This e.g. caused issues for KVM IPVS setups, where different Segmentation Offloading techniques are utilized, between guests, via the virtio driver. This resulted in very bad performance, due to the ICMPv6 "too big" messages didn't affect the sender.

---
To Simon,
This should perhaps go to stable?
The patch is based on ipvs-next, but will apply on ipvs with an offset. Jesper

 net/netfilter/ipvs/ip_vs_xmit.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
net/netfilter/ipvs/ip_vs_xmit.c +1 -1
index 543a554..80c3006 100644
@@ -1113,7 +1113,7 @@ ip_vs_dr_xmit_v6(struct sk_buff *skb, struct ip_vs_conn *cp,
 
 	/* MTU checking */
 	mtu = dst_mtu(&rt->dst);
-	if (skb->len > mtu) {
+	if (skb->len > mtu && !skb_is_gso(skb))) {
 		if (!skb->dev) {
 			struct net *net = dev_net(skb_dst(skb)->dev);