Skip to contentSkip to conversation

omapdrm: use alloc_ordered_workqueue() instead of UNBOUND w/ max_active = 1

PATCH In review Tejun Heo 2 participants 3 messages Aug 22, 2012 – Aug 23, 2012 Staging

lore
Share & tools
lore

Tejun Heo

author
#0 lore raw

PATCH 1/1 omapdrm: use alloc_ordered_workqueue() instead of UNBOUND w/ max_active = 1

This is an equivalent conversion and will ease scheduled removal of WQ_NON_REENTRANT.

Only compile tested.

---
 drivers/staging/omapdrm/omap_drv.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/omapdrm/omap_drv.c +1 -2
index 4beab94..672cb3a 100644
@@ -571,8 +571,7 @@ static int dev_load(struct drm_device *dev, unsigned long flags)
 
 	dev->dev_private = priv;
 
-	priv->wq = alloc_workqueue("omapdrm",
-			WQ_UNBOUND | WQ_NON_REENTRANT, 1);
+	priv->wq = alloc_ordered_workqueue("omapdrm", 0);
 
 	INIT_LIST_HEAD(&priv->obj_list);
 
#1 lore raw
Quoted 6 lines · Tejun Heo

This is an equivalent conversion and will ease scheduled removal of WQ_NON_REENTRANT.

Only compile tested.

I've tested it

Quoted 18 lines
---
 drivers/staging/omapdrm/omap_drv.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/staging/omapdrm/omap_drv.c +1 -2
index 4beab94..672cb3a 100644
@@ -571,8 +571,7 @@ static int dev_load(struct drm_device *dev, unsigned long flags)
 
        dev->dev_private = priv;
 
-       priv->wq = alloc_workqueue("omapdrm",
-                       WQ_UNBOUND | WQ_NON_REENTRANT, 1);
+       priv->wq = alloc_ordered_workqueue("omapdrm", 0);
 
        INIT_LIST_HEAD(&priv->obj_list);
 
author
#2 lore raw
Quoted 11 lines · Rob
Quoted 6 lines · Tejun Heo

This is an equivalent conversion and will ease scheduled removal of WQ_NON_REENTRANT.

Only compile tested.

I've tested it

Can you please route this with other omap patches?

Thanks!

Signature · 1 line
tejun