Skip to contentSkip to conversation

atmel-ssc: include linux/io.h for raw io

PATCH New Joachim Eastwood 5 participants 12 messages Aug 13, 2012 – Sep 11, 2012

Subsystems (3)
Arm/Microchip (AT91) SoC support ATM Microchip ssc driver
lore
Share & tools
lore

Joachim Eastwood

author
#0 lore raw

PATCH 1/1 atmel-ssc: include linux/io.h for raw io

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by Joachim Eastwood <[email protected]>
---
 include/linux/atmel-ssc.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/atmel-ssc.h +1 -0
index 0602339..4eb3175 100644
@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;
Signature · 1 line
1.7.11
#1 lore raw

PATCH 1/1 atmel-ssc: include linux/io.h for raw io

On 08/13/2012 09:59 PM, Joachim Eastwood :

Quoted 10 lines

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by Joachim Eastwood <[email protected]>

Added to at91-fixes for 3.6. Thanks!

Arnd, can I queue this one in my upcoming pull-request to you?

Quoted 17 lines
---
 include/linux/atmel-ssc.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/atmel-ssc.h +1 -0
index 0602339..4eb3175 100644
@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;
Signature · 1 line
Nicolas Ferre
#2 lore raw

PATCH 1/1 atmel-ssc: include linux/io.h for raw io

Quoted 10 lines · Nicolas Ferre

On 08/13/2012 09:59 PM, Joachim Eastwood :

Quoted 9 lines

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Quoted 6 lines
Quoted 1 line
Signed-off-by Joachim Eastwood <[email protected]>

Added to at91-fixes for 3.6. Thanks!

Arnd, can I queue this one in my upcoming pull-request to you?

Sure, no problem.

Arnd

#3 lore raw

PATCH 1/1 atmel-ssc: include linux/io.h for raw io

In reply to Joachim Eastwood

On 08/13/2012 09:59 PM, Joachim Eastwood :

Quoted 10 lines

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by Joachim Eastwood <[email protected]>

Liam, Mark,

May I have your Acked-by for this patch, I plan to queue it with my other at91-related fixes in arm-soc tree?

Thanks, best regards,

Quoted 17 lines
---
 include/linux/atmel-ssc.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/atmel-ssc.h +1 -0
index 0602339..4eb3175 100644
@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;
Signature · 1 line
Nicolas Ferre
#4 lore raw

PATCH 1/1 atmel-ssc: include linux/io.h for raw io

Quoted 2 lines · Nicolas Ferre

May I have your Acked-by for this patch, I plan to queue it with my other at91-related fixes in arm-soc tree?

Don't think the original patch was CCed to me - can you send me a copy
please and I'll take a look?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120823/c63b9cf6/attachment.sig>

#5 lore raw

PATCH 1/1 ASoC: atmel-ssc: include linux/io.h for raw io

From: Joachim Eastwood <[email protected]>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Signed-off-by Joachim Eastwood <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>

---
Mark,

Here is a copy of the original patch by Joachim. Can you please take a look and give your acknowledgement so that I can queue it in arm-soc tree.

Thanks, bye,

 include/linux/atmel-ssc.h |    1 +
 1 file changed, 1 insertion(+)
include/linux/atmel-ssc.h +1 -0
index 0602339..4eb3175 100644
@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;
Signature · 1 line
1.7.10
#6 lore raw

PATCH 1/1 ASoC: atmel-ssc: include linux/io.h for raw io

Quoted 11 lines · Nicolas Ferre

From: Joachim Eastwood <[email protected]>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Quoted 2 lines
Signed-off-by Joachim Eastwood <[email protected]>
Signed-off-by Nicolas Ferre <[email protected]>
Acked-by Jean-Christophe PLAGNIOL-VILLARD <[email protected]>

Best Regards,
J.

Quoted 31 lines

---
Mark,

Here is a copy of the original patch by Joachim. Can you please take a look and give your acknowledgement so that I can queue it in arm-soc tree.

Thanks, bye,

 include/linux/atmel-ssc.h |    1 +
 1 file changed, 1 insertion(+)
include/linux/atmel-ssc.h +1 -0
index 0602339..4eb3175 100644
@@ -3,6 +3,7 @@
 
 #include <linux/platform_device.h>
 #include <linux/list.h>
+#include <linux/io.h>
 
 struct ssc_device {
 	struct list_head	list;
Signature · 7 lines
1.7.10


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
#7 lore raw

PATCH 1/1 ASoC: atmel-ssc: include linux/io.h for raw io

In reply to Nicolas Ferre
Quoted 10 lines · Nicolas Ferre

From: Joachim Eastwood <[email protected]>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Acked-by Mark Brown <[email protected]>

but why not just apply it to the ASoC tree?

#8 lore raw

PATCH 1/1 ASoC: atmel-ssc: include linux/io.h for raw io

On 08/25/2012 10:25 PM, Mark Brown :

Quoted 12 lines · Nicolas Ferre
Quoted 10 lines

From: Joachim Eastwood <[email protected]>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Quoted 3 lines
Acked-by Mark Brown <[email protected]>

but why not just apply it to the ASoC tree?

Fine by me then: so Mark, can you take it for a 3.6 fixes branch?

(I remove it from my at91-fixes branch that will go through arm-soc tree).

Best regards,

Signature · 1 line
Nicolas Ferre
#9 lore raw

PATCH 1/1 ASoC: atmel-ssc: include linux/io.h for raw io

On 08/27/2012 10:01 AM, Nicolas Ferre :

Quoted 13 lines

On 08/25/2012 10:25 PM, Mark Brown :

Quoted 12 lines · Nicolas Ferre
Quoted 10 lines

From: Joachim Eastwood <[email protected]>

Include linux/io.h for raw io operations in atmel-scc header.

This fixes the following build error:
CC [M] sound/soc/atmel/atmel_ssc_dai.o
sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_interrupt':
sound/soc/atmel/atmel_ssc_dai.c:171: error: implicit declaration of function '__raw_readl' sound/soc/atmel/atmel_ssc_dai.c: In function 'atmel_ssc_shutdown':
sound/soc/atmel/atmel_ssc_dai.c:249: error: implicit declaration of function '__raw_writel'

Quoted 7 lines
Quoted 3 lines
Acked-by Mark Brown <[email protected]>

but why not just apply it to the ASoC tree?

Fine by me then: so Mark, can you take it for a 3.6 fixes branch?

(I remove it from my at91-fixes branch that will go through arm-soc tree).

Hi Mark,

Ping?

Best regards,

Signature · 1 line
Nicolas Ferre
#10 lore raw

PATCH 1/1 ASoC: atmel-ssc: include linux/io.h for raw io

Quoted 1 line · Nicolas Ferre

Ping?

Pong. Don't send contentless pings... If you want me to apply the patch someone should send me a copy.