mx28evk: Convert to mxs_adjust_memory_params()

PATCH New Fabio Estevam 5 participants 7 messages Aug 28, 2012 – Sep 4, 2012

Share & tools

Fabio Estevam

author

2012-08-28 19:29 UTC #0 lore raw

PATCH 1/1 mx28evk: Convert to mxs_adjust_memory_params()

Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params missed to update mx28evk, which caused the board not to boot.

Apply the conversion so that the board can boot again.

Signed-off-by Fabio Estevam <[email protected]>

---
 board/freescale/mx28evk/iomux.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

board/freescale/mx28evk/iomux.c +1 -1

index 16a6d8a..ae6eda3 100644
@@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
 #define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \
 					ADDR_PINS << 8 | APREBIT)
 
-void mx28_adjust_memory_params(uint32_t *dram_vals)
+void mxs_adjust_memory_params(uint32_t *dram_vals)
 {
 	dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
 }

Signature · 1 line

1.7.9.5

Marek Vasut

2012-08-28 19:36 UTC #1 lore raw

PATCH 1/1 mx28evk: Convert to mxs_adjust_memory_params()

Dear Fabio Estevam,

Quoted 3 lines

Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params missed to update mx28evk, which caused the board not to boot.

Oh of course ... that's an obvious flub. I'm very unhappy about the conversion causing such trouble! Please be more careful next time.

Quoted 1 line

Apply the conversion so that the board can boot again.

Yes,

Acked-by Marek Vasut <[email protected]>

Quoted 10 lines

Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx28evk/iomux.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644

board/freescale/mx28evk/iomux.c const iomux_cfg_t iomux_setup[] = { · line 179

Quoted 8 lines

board/freescale/mx28evk/iomux.c +1 -1

@@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
 #define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \
 					ADDR_PINS << 8 | APREBIT)
 
-void mx28_adjust_memory_params(uint32_t *dram_vals)
+void mxs_adjust_memory_params(uint32_t *dram_vals)
 {
 	dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
 }

Best regards,
Marek Vasut

Marek Vasut

2012-08-28 19:39 UTC #2 lore raw

PATCH 1/1 mx28evk: Convert to mxs_adjust_memory_params()

Dear Marek Vasut,

Quoted 8 lines

Dear Fabio Estevam,
Quoted 3 lines
Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params missed to update mx28evk, which caused the board not to boot.
Oh of course ... that's an obvious flub. I'm very unhappy about the conversion causing such trouble! Please be more careful next time.

btw. Otavio, tell me if this tortured you enough ... gotta train this, I'm not good at it yet, but fear, soon I'll improve ;-)

Quoted 25 lines

Quoted 1 line
Apply the conversion so that the board can boot again.
Yes,
Acked-by Marek Vasut <[email protected]>
Quoted 19 lines
Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx28evk/iomux.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
board/freescale/mx28evk/iomux.c +1 -1
@@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
 
 #define HW_DRAM_CTL29_CONFIG	(CS_MAP << 24 | COLUMN_SIZE << 16 | \
 
 					ADDR_PINS << 8 | APREBIT)
 
-void mx28_adjust_memory_params(uint32_t *dram_vals)
+void mxs_adjust_memory_params(uint32_t *dram_vals)
 

Quoted 8 lines

Quoted 5 lines
{
dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
}
Best regards,
Marek Vasut

Best regards,
Marek Vasut

Otavio Salvador

2012-08-28 21:49 UTC #3 lore raw

PATCH 1/1 mx28evk: Convert to mxs_adjust_memory_params()

In reply to Marek Vasut

Quoted 8 lines · Marek Vasut

Dear Fabio Estevam,
Quoted 3 lines
Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params missed to update mx28evk, which caused the board not to boot.
Oh of course ... that's an obvious flub. I'm very unhappy about the conversion causing such trouble! Please be more careful next time.

This was my fault; but good that Fabio has spot it fast.

Quoted 27 lines

Quoted 1 line
Apply the conversion so that the board can boot again.
Yes,
Acked-by Marek Vasut <[email protected]>
Quoted 10 lines
Signed-off-by Fabio Estevam <[email protected]>
---
 board/freescale/mx28evk/iomux.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
(quoted diff) +0 -0
b/board/freescale/mx28evk/iomux.c index 16a6d8a..ae6eda3 100644
board/freescale/mx28evk/iomux.c const iomux_cfg_t iomux_setup[] = { · line 179
Quoted 8 lines
board/freescale/mx28evk/iomux.c +1 -1
@@ -173,7 +173,7 @@ const iomux_cfg_t iomux_setup[] = {
 #define HW_DRAM_CTL29_CONFIG (CS_MAP << 24 | COLUMN_SIZE << 16 | \
                                      ADDR_PINS << 8 | APREBIT)
 
-void mx28_adjust_memory_params(uint32_t *dram_vals)
+void mxs_adjust_memory_params(uint32_t *dram_vals)
 {
      dram_vals[HW_DRAM_CTL29] = HW_DRAM_CTL29_CONFIG;
 }
Best regards,
Marek Vasut

Signature · 3 lines

Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br

Fabio Estevam

2012-09-03 16:47 UTC #4 lore raw

PATCH 1/1 mx28evk: Convert to mxs_adjust_memory_params()

In reply to Fabio Estevam

Hi Stefano,

Quoted 6 lines · Fabio Estevam

Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params missed to update mx28evk, which caused the board not to boot.
Apply the conversion so that the board can boot again.
Signed-off-by Fabio Estevam <[email protected]>

Could this one be applied, please?

Without this patch, mx28evk does not boot.

Thanks,

Fabio Estevam

Stefano Babic

2012-09-03 17:21 UTC #5 lore raw

PATCH 1/1 mx28evk: Convert to mxs_adjust_memory_params()

Quoted 7 lines · Fabio Estevam

Hi Stefano,
Quoted 3 lines · Fabio Estevam
Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params missed to update mx28evk, which caused the board not to boot.

Quoted 7 lines

Quoted 3 lines
Apply the conversion so that the board can boot again.
Signed-off-by Fabio Estevam <[email protected]>
Could this one be applied, please?
Without this patch, mx28evk does not boot.

Sorry - I will merge it soon.

Cheers,
Stefano

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

Stefano Babic

2012-09-04 10:04 UTC #6 lore raw

PATCH 1/1 mx28evk: Convert to mxs_adjust_memory_params()

In reply to Fabio Estevam

Quoted 7 lines · Fabio Estevam

Recent conversion from mx28_adjust_memory_params to mxs_adjust_memory_params missed to update mx28evk, which caused the board not to boot.
Apply the conversion so that the board can boot again.
Signed-off-by Fabio Estevam <[email protected]>
---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic

Signature · 5 lines

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================