Skip to contentSkip to conversation

MAKEALL: fix ARM board lists

PATCH New Allen Martin 2 participants 4 messages Aug 29, 2012

lore
Share & tools
lore

Allen Martin

author
#0 lore raw

PATCH 1/1 MAKEALL: fix ARM board lists

The LIST_arm rule included the Atmel boards twice (by virtue of including both LIST_at91 and LIST_ARM9) and was missing all the arm720t, arm946es, and arm1176 boards. Change this list to use boards_by_arch() which is less error prone. After this change "./MAKEALL arm" and "./MAKEALL -a arm" build the same boards.

Also add the missing arm946es and arm1176 processors to the ARM9 and ARM11 lists respectively and add an ARM7 list for the arm720t processor.

Signed-off-by Allen Martin <[email protected]>
---
 MAKEALL |   22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)
MAKEALL +11 -11
index 6b9ff30..cdb65e7 100755
@@ -331,18 +331,27 @@ LIST_ppc="		\
 LIST_SA="$(boards_by_cpu sa1100)"
 
 #########################################################################
+## ARM7 Systems
+#########################################################################
+
+LIST_ARM7="$(boards_by_cpu arm720t)"
+
+#########################################################################
 ## ARM9 Systems
 #########################################################################
 
 LIST_ARM9="$(boards_by_cpu arm920t)	\
 	$(boards_by_cpu arm926ejs)	\
 	$(boards_by_cpu arm925t)	\
+	$(boards_by_cpu arm946es)	\
 "
 
 #########################################################################
 ## ARM11 Systems
 #########################################################################
-LIST_ARM11="$(boards_by_cpu arm1136)"
+LIST_ARM11="$(boards_by_cpu arm1136)	\
+	$(boards_by_cpu arm1176)	\
+"
 
 #########################################################################
 ## ARMV7 Systems

@@ -368,16 +377,7 @@ LIST_ixp="$(boards_by_cpu ixp)"
 ## ARM groups
 #########################################################################
 
-LIST_arm="			\
-	${LIST_SA}		\
-	${LIST_ARM9}		\
-	${LIST_ARM10}		\
-	${LIST_ARM11}		\
-	${LIST_ARMV7}	\
-	${LIST_at91}		\
-	${LIST_pxa}		\
-	${LIST_ixp}		\
-"
+LIST_arm="$(boards_by_arch arm)"
 
 #########################################################################
 ## MIPS Systems		(default = big endian)
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 MAKEALL: fix ARM board lists

Quoted 9 lines · Allen Martin

The LIST_arm rule included the Atmel boards twice (by virtue of including both LIST_at91 and LIST_ARM9) and was missing all the arm720t, arm946es, and arm1176 boards. Change this list to use boards_by_arch() which is less error prone. After this change "./MAKEALL arm" and "./MAKEALL -a arm" build the same boards.

Also add the missing arm946es and arm1176 processors to the ARM9 and ARM11 lists respectively and add an ARM7 list for the arm720t processor.

Good find! Would you mind looking quickly over the other arches to see if they have any similar but now obvious problems (where LIST_${ARCH}
doesn't use boards_by_arch)) ? Thanks!

Signature · 1 line
Tom
author
#2 lore raw

PATCH 1/1 MAKEALL: fix ARM board lists

Quoted 7 lines · Tom Rini
Quoted 6 lines · Allen Martin

The LIST_arm rule included the Atmel boards twice (by virtue of including both LIST_at91 and LIST_ARM9) and was missing all the arm720t, arm946es, and arm1176 boards. Change this list to use boards_by_arch() which is less error prone. After this change "./MAKEALL arm" and "./MAKEALL -a arm" build the same boards.

Quoted 10 lines
Quoted 3 lines

Also add the missing arm946es and arm1176 processors to the ARM9 and ARM11 lists respectively and add an ARM7 list for the arm720t processor.

Good find! Would you mind looking quickly over the other arches to see if they have any similar but now obvious problems (where LIST_${ARCH}
doesn't use boards_by_arch)) ? Thanks!

Signature · 1 line
Tom

By experiment it look like m68k and mips have problems too, I'll investigate:

$ for i in $(awk '($1 !~ /^#/) {print $2}' boards.cfg  | sort | uniq) ; do
Quoted 4 lines

echo $i
./MAKEALL -l -a $i | wc -l
./MAKEALL -l $i | wc -l
done

arm
250
250
avr32
9
9
blackfin
34
34
m68k
44
50
microblaze
1
1
mips
25
19
nds32
3
3
nios2
3
3
openrisc
1
1
powerpc
637
637
sandbox
1
1
sh
20
20
sparc
5
5
x86
3
3

-Allen

Signature · 1 line
nvpublic
author
#3 lore raw

PATCH 1/1 MAKEALL: fix ARM board lists

Quoted 12 lines · Allen Martin
Quoted 11 lines · Tom Rini
Quoted 9 lines · Allen Martin

The LIST_arm rule included the Atmel boards twice (by virtue of including both LIST_at91 and LIST_ARM9) and was missing all the arm720t, arm946es, and arm1176 boards. Change this list to use boards_by_arch() which is less error prone. After this change "./MAKEALL arm" and "./MAKEALL -a arm" build the same boards.

Also add the missing arm946es and arm1176 processors to the ARM9 and ARM11 lists respectively and add an ARM7 list for the arm720t processor.

Quoted 9 lines
Quoted 6 lines

Good find! Would you mind looking quickly over the other arches to see if they have any similar but now obvious problems (where LIST_${ARCH}
doesn't use boards_by_arch)) ? Thanks!

Signature · 1 line
Tom

By experiment it look like m68k and mips have problems too, I'll investigate:

It looks like mips splits out the little endian boards into a virtual "mips_el" architecture that doesn't actually exist in boardfs.cfg, so maybe I won't touch that. I founds some other missing/duplicate boards in mips and m68k though so I'll add those to the patch.

-Allen

Signature · 1 line
nvpublic