lp8727_charger: use IRQF_ONESHOT

PATCH Applied Fengguang Wu 5 participants 8 messages Aug 23, 2012 – Sep 20, 2012

lore

Share & tools

lore

Fengguang Wu

author

2012-08-23 11:42 UTC #0 lore raw

PATCH 1/1 lp8727_charger: use IRQF_ONESHOT

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT

Signed-off-by Fengguang Wu <[email protected]>

---

Note: I don't really know much about the situation, feel free to ignore it if it's an false warning.

 cocci-output-25411-2ae2e0-lp8727_charger.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/power/lp8727_charger.c +1 -1

@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
 	return request_threaded_irq(pchg->client->irq,
 				NULL,
 				lp8727_isr_func,
-				IRQF_TRIGGER_FALLING,
+				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 				"lp8727_irq",
 				pchg);
 }

[PATCH] lp8727_charger: fix coccinelle warnings

/c/kernel-tests/src/linux/drivers/power/lp8727_charger.c:255:8-28: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT

Signed-off-by Fengguang Wu <[email protected]>

---
 cocci-output-25411-2ae2e0-lp8727_charger.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/power/lp8727_charger.c +1 -1

@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
 	return request_threaded_irq(pchg->client->irq,
 				NULL,
 				lp8727_isr_func,
-				IRQF_TRIGGER_FALLING,
+				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 				"lp8727_irq",
 				pchg);
 }

Fengguang Wu

author

2012-08-23 11:56 UTC #1 lore raw

PATCH 1/1 twl4030_charger: use IRQF_ONESHOT

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci

Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT

Signed-off-by Fengguang Wu <[email protected]>

---

Please take the patch only if it's a positive warning. Thanks!

 drivers/power/twl4030_charger.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/power/twl4030_charger.c +2 -2

@@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru
 	}
 
 	ret = request_threaded_irq(bci->irq_chg, NULL,
-			twl4030_charger_interrupt, 0, pdev->name, bci);
+			twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "could not request irq %d, status %d\n",
 			bci->irq_chg, ret);

@@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru
 	}
 
 	ret = request_threaded_irq(bci->irq_bci, NULL,
-			twl4030_bci_interrupt, 0, pdev->name, bci);
+			twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "could not request irq %d, status %d\n",
 			bci->irq_bci, ret);

Felipe Balbi

Acked-by on v1 1/1

2012-08-23 12:04 UTC #2 lore raw

Re: [PATCH] twl4030_charger: use IRQF_ONESHOT

Quoted 5 lines · Fengguang Wu

Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by Fengguang Wu <[email protected]>

makes sense, NULL hardirq handler:

Acked-by Felipe Balbi <[email protected]>

Quoted 32 lines

---

Please take the patch only if it's a positive warning. Thanks!

 drivers/power/twl4030_charger.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

drivers/power/twl4030_charger.c +2 -3

@@ -534,7 +534,7 @@ static int __init twl4030_bci_probe(stru
 	}
 
 	ret = request_threaded_irq(bci->irq_chg, NULL,
-			twl4030_charger_interrupt, 0, pdev->name, bci);
+			twl4030_charger_interrupt, IRQF_ONESHOT, pdev->name, bci);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "could not request irq %d, status %d\n",
 			bci->irq_chg, ret);

@@ -542,7 +542,7 @@ static int __init twl4030_bci_probe(stru
 	}
 
 	ret = request_threaded_irq(bci->irq_bci, NULL,
-			twl4030_bci_interrupt, 0, pdev->name, bci);
+			twl4030_bci_interrupt, IRQF_ONESHOT, pdev->name, bci);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "could not request irq %d, status %d\n",
 			bci->irq_bci, ret);
--

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Signature · 1 line

balbi

Anton Vorontsov

2012-09-20 22:46 UTC #3 lore raw

Re: [PATCH] twl4030_charger: use IRQF_ONESHOT

Quoted 8 lines · Felipe Balbi

Quoted 5 lines · Fengguang Wu
Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by Fengguang Wu <[email protected]>
makes sense, NULL hardirq handler:

Acks per irq handler is something new to me. :-)

Quoted 1 line

Acked-by Felipe Balbi <[email protected]>

Thank you folks, this is now applied!

Kim, Milo

Acked-by on v1 1/1

2012-08-29 02:01 UTC #4 lore raw

In reply to Fengguang Wu

Quoted 18 lines

ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by Fengguang Wu <[email protected]>
---
Note: I don't really know much about the situation, feel free to ignore it if it's an false warning.
 cocci-output-25411-2ae2e0-lp8727_charger.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/power/lp8727_charger.c static int lp8727_intr_config(struct lp8 · line 261

Quoted 8 lines

drivers/power/lp8727_charger.c +1 -1

@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
 	return request_threaded_irq(pchg->client->irq,
 				NULL,
 				lp8727_isr_func,
-				IRQF_TRIGGER_FALLING,
+				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 				"lp8727_irq",
 				pchg);
 }

Thanks for the update.

Acked-by Milo(Woogyom) Kim <[email protected]>

Best Regards,
Milo

Anton Vorontsov

Applied

2012-09-20 22:46 UTC #5 lore raw

On Wed, Aug 29, 2012 at 02:00:43AM +0000, Kim, Milo wrote:
[...]

Quoted 2 lines

Quoted 2 lines
Signed-off-by Fengguang Wu <[email protected]>
---

[...]

Quoted 8 lines

drivers/power/lp8727_charger.c static int lp8727_intr_config(struct lp8 · line 261
Quoted 5 lines
drivers/power/lp8727_charger.c +1 -1
-				IRQF_TRIGGER_FALLING,
+				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 				"lp8727_irq",
 				pchg);
 }
Thanks for the update.
Acked-by Milo(Woogyom) Kim <[email protected]>

Applied, thanks!

Kim, Milo

2012-08-30 11:42 UTC #6 lore raw

In reply to Fengguang Wu

Quoted 28 lines

Quoted 18 lines
ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by Fengguang Wu <[email protected]>
---
Note: I don't really know much about the situation, feel free to ignore it if it's an false warning.
 cocci-output-25411-2ae2e0-lp8727_charger.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/lp8727_charger.c static int lp8727_intr_config(struct lp8 · line 261
Quoted 8 lines
drivers/power/lp8727_charger.c +1 -1
@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
 	return request_threaded_irq(pchg->client->irq,
 				NULL,
 				lp8727_isr_func,
-				IRQF_TRIGGER_FALLING,
+				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 				"lp8727_irq",
 				pchg);
 }
Thanks for the update.

Quoted 2 lines

Acked-by Milo(Woogyom) Kim <[email protected]>

Please refer to the patch below.
[PATCH 4/8] lp8727_charger: cleanup the interrupt handler code This includes previous Fengguang' patch.

Best Regards,
Milo

Anton Vorontsov

2012-08-30 12:09 UTC #7 lore raw

Quoted 28 lines · Milo

Quoted 28 lines
Quoted 18 lines
ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT
Make sure threaded IRQs without a primary handler are always request with IRQF_ONESHOT
Signed-off-by Fengguang Wu <[email protected]>
---
Note: I don't really know much about the situation, feel free to ignore it if it's an false warning.
 cocci-output-25411-2ae2e0-lp8727_charger.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/power/lp8727_charger.c static int lp8727_intr_config(struct lp8 · line 261
Quoted 8 lines
drivers/power/lp8727_charger.c +1 -1
@@ -255,7 +255,7 @@ static int lp8727_intr_config(struct lp8
 	return request_threaded_irq(pchg->client->irq,
 				NULL,
 				lp8727_isr_func,
-				IRQF_TRIGGER_FALLING,
+				IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
 				"lp8727_irq",
 				pchg);
 }
Thanks for the update.

Quoted 6 lines

Quoted 2 lines
Acked-by Milo(Woogyom) Kim <[email protected]>
Please refer to the patch below.
[PATCH 4/8] lp8727_charger: cleanup the interrupt handler code This includes previous Fengguang' patch.

Nope, I'll include Fengguang's patch (he posted it first), and then will try to apply the rest of your cleanups on top of it. If it helps, your can incorporate the fix in your series, preserving the authorship.

Thanks.