usb: ehci: don't print debug output

PATCH New Lucas Stach 2 participants 3 messages Aug 30, 2012 – Sep 27, 2012

Subsystems (2)

USB USB ehci driver

lore

Share & tools

lore

Lucas Stach

author

2012-08-30 15:38 UTC #0 lore raw

PATCH 1/1 usb: ehci: don't print debug output

This is clearly some sort of debug output and should not be printed during normal operation.

Signed-off-by Lucas Stach <[email protected]>

---
 drivers/usb/host/ehci-hcd.c | 2 +-

1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)

drivers/usb/host/ehci-hcd.c +1 -1

index 2f4fa5e..eb9e323 100644
@@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
 
 	reg = ehci_readl(&hccr->cr_hcsparams);
 	descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
-	printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
+	debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
 	/* Port Indicators */
 	if (HCS_INDICATOR(reg))
 		descriptor.hub.wHubCharacteristics |= 0x80;

Signature · 1 line

1.7.11.4

Marek Vasut

2012-08-30 15:47 UTC #1 lore raw

PATCH 1/1 usb: ehci: don't print debug output

Dear Lucas Stach,

Quoted 4 lines

This is clearly some sort of debug output and should not be printed during normal operation.
Signed-off-by Lucas Stach <[email protected]>

I think we should apply this ... yet it's been in uboot for so long, so I'd like to hear other people opinion :)

Quoted 9 lines

---
 drivers/usb/host/ehci-hcd.c | 2 +-
1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)
drivers/usb/host/ehci-hcd.c +0 -0
index 2f4fa5e..eb9e323 100644

drivers/usb/host/ehci-hcd.c int usb_lowlevel_init(void) · line 869

Quoted 8 lines

drivers/usb/host/ehci-hcd.c +1 -1

@@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
 
 	reg = ehci_readl(&hccr->cr_hcsparams);
 	descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
-	printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
+	debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
 	/* Port Indicators */
 	if (HCS_INDICATOR(reg))
 		descriptor.hub.wHubCharacteristics |= 0x80;

Best regards,
Marek Vasut

Lucas Stach

author

2012-09-27 20:02 UTC #2 lore raw

PATCH 1/1 usb: ehci: don't print debug output

Hi Marek,

Am Donnerstag, den 30.08.2012, 17:47 +0200 schrieb Marek Vasut:

Quoted 10 lines

Dear Lucas Stach,
Quoted 4 lines
This is clearly some sort of debug output and should not be printed during normal operation.
Signed-off-by Lucas Stach <[email protected]>
I think we should apply this ... yet it's been in uboot for so long, so I'd like to hear other people opinion :)

Any updates on this one? Seems nobody really cares and it uglyfies output in the multi controller case a lot, so I really wish to see this gone.

Quoted 10 lines

Quoted 10 lines
---
 drivers/usb/host/ehci-hcd.c | 2 +-
1 Datei ge?ndert, 1 Zeile hinzugef?gt(+), 1 Zeile entfernt(-)
drivers/usb/host/ehci-hcd.c +0 -0
index 2f4fa5e..eb9e323 100644
@@ -863,7 +863,7 @@ int usb_lowlevel_init(void)
 

Quoted 11 lines

drivers/usb/host/ehci-hcd.c int usb_lowlevel_init(void) · line 869

Quoted 7 lines

drivers/usb/host/ehci-hcd.c +1 -1

 	reg = ehci_readl(&hccr->cr_hcsparams);
 	descriptor.hub.bNbrPorts = HCS_N_PORTS(reg);
-	printf("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
+	debug("Register %x NbrPorts %d\n", reg, descriptor.hub.bNbrPorts);
 	/* Port Indicators */
 	if (HCS_INDICATOR(reg))
 		descriptor.hub.wHubCharacteristics |= 0x80;

Best regards,
Marek Vasut

Thanks,
Lucas