Skip to contentSkip to conversation

hid: Remove "default m" from HID_LOGITECH_DJ

PATCH In review Josh Triplett 2 participants 2 messages Sep 3, 2012 HID

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 hid: Remove "default m" from HID_LOGITECH_DJ

HID_LOGITECH_DJ uses "default m", which enables it in default kernel builds. Since this module just enables extra, non-critical functionality for one particular piece of hardware (specifically, differentiating multiple wireless keyboards and mice as separate input devices rather than treating them as one device), and the hardware works just fine with the default USB HID support, drop the "default m".

---
 drivers/hid/Kconfig |    1 -
 1 file changed, 1 deletion(-)
drivers/hid/Kconfig +0 -1
index fbf4950..d004528 100644
@@ -307,7 +307,6 @@ config HID_LOGITECH
 config HID_LOGITECH_DJ
 	tristate "Logitech Unifying receivers full support"
 	depends on HID_LOGITECH
-	default m
 	---help---
 	Say Y if you want support for Logitech Unifying receivers and devices.
 	Unifying receivers are capable of pairing up to 6 Logitech compliant
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 17 lines · Josh Triplett

HID_LOGITECH_DJ uses "default m", which enables it in default kernel builds. Since this module just enables extra, non-critical functionality for one particular piece of hardware (specifically, differentiating multiple wireless keyboards and mice as separate input devices rather than treating them as one device), and the hardware works just fine with the default USB HID support, drop the "default m".

---
 drivers/hid/Kconfig |    1 -
 1 file changed, 1 deletion(-)
drivers/hid/Kconfig +0 -0
index fbf4950..d004528 100644

drivers/hid/Kconfig config HID_LOGITECH · line 312

Quoted 7 lines
drivers/hid/Kconfig +0 -1
@@ -307,7 +307,6 @@ config HID_LOGITECH
 config HID_LOGITECH_DJ
 	tristate "Logitech Unifying receivers full support"
 	depends on HID_LOGITECH
-	default m
 	---help---
 	Say Y if you want support for Logitech Unifying receivers and devices.
 	Unifying receivers are capable of pairing up to 6 Logitech compliant

That was an overlook on my side when merging the driver. Applied, thanks.

Signature · 2 lines
Jiri Kosina
SUSE Labs