sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

850 ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,

[PATCH] wm0010: fix coccinelle warnings

/c/kernel-tests/src/linux/sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Quoted 3 lines · Fengguang Wu

[PATCH] wm0010: fix coccinelle warnings

/c/kernel-tests/src/linux/sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT

Gah, just noticed the patch buried in here. If you're generating stuff like this I'd suggest restructuring the submission so it comes out as an normal patch, it's not at all obvious that there's a patch in the mail and even if one notices. In this case I'd mostly ignored your mail as I expected Dimitris to fix it, will apply now.

Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?

Quoted 4 lines · Mark Brown

On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:

Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?

Julia Lawall? Added CC to her.

Quoted 7 lines · Fengguang Wu

Quoted 4 lines · Mark Brown

On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:

Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?

Julia Lawall? Added CC to her.

Yes.

Quoted 4 lines · Mark Brown

Quoted 2 lines · Fengguang Wu

Quoted 1 line · Mark Brown

On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:

Quoted 6 lines

Quoted 4 lines

Quoted 2 lines

Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?

Julia Lawall? Added CC to her.

Yes.

I'm missing some context...

Quoted 11 lines · Julia Lawall

Quoted 9 lines · Mark Brown

Quoted 7 lines · Fengguang Wu

Quoted 4 lines · Mark Brown

On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:

Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?

Julia Lawall? Added CC to her.

Quoted 3 lines

Quoted 1 line

Yes.

I'm missing some context...

Julia, you've posted some pretty neat (coccinelle generated?) patches to the list. So we wonder whether you have some scripts for formatting patches based on the coccinelle output?

Quoted 12 lines · Fengguang Wu

Quoted 11 lines · Julia Lawall

Quoted 9 lines · Mark Brown

Quoted 7 lines · Fengguang Wu

Quoted 4 lines · Mark Brown

On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:

Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?

Julia Lawall? Added CC to her.

Quoted 7 lines

Quoted 3 lines

Quoted 1 line

Yes.

I'm missing some context...

Julia, you've posted some pretty neat (coccinelle generated?) patches to the list. So we wonder whether you have some scripts for formatting patches based on the coccinelle output?

I do have a tool, but it doesn't exactly take the output produced by coccicheck. I can look into how this could be done.

The input desired would be the text printed by Coccinelle and a patch generated by git?

Quoted 22 lines · Julia Lawall

Quoted 12 lines · Fengguang Wu

Quoted 11 lines · Julia Lawall

Quoted 9 lines · Mark Brown

Quoted 7 lines · Fengguang Wu

Quoted 4 lines · Mark Brown

On Thu, Aug 30, 2012 at 08:16:52AM -0700, Fengguang Wu wrote:

Julia generally does a pretty good job of formatting her mails, perhaps there's some scripts she uses whcih would help?

Julia Lawall? Added CC to her.

Quoted 7 lines

Quoted 3 lines

Quoted 1 line

Yes.

I'm missing some context...

Julia, you've posted some pretty neat (coccinelle generated?) patches to the list. So we wonder whether you have some scripts for formatting patches based on the coccinelle output?

Quoted 5 lines

I do have a tool, but it doesn't exactly take the output produced by coccicheck. I can look into how this could be done.

The input desired would be the text printed by Coccinelle and a patch generated by git?

I'm just adapting the coccinelle generated diff into a mechanically formated patch.

Here is the discussed patch, generated by a simple script. It mainly serves as a good start point for patch submission.

: [PATCH] wm0010: fix coccinelle warnings
:
: sound/soc/codecs/wm0010.c:850:7-27: ERROR: Threaded IRQ with no primary handler requested without IRQF_ONESHOT :
: Make sure threaded IRQs without a primary handler are always request with
: IRQF_ONESHOT
:
: Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci
:
: Signed-off-by: Fengguang Wu <[email protected]>
: ---
:
: Please take the patch only if it's a positive warning. Thanks!
:
: cocci-output-17570-fcfaec-wm0010.c | 2 +-
: 1 file changed, 1 insertion(+), 1 deletion(-)
:
: --- a/sound/soc/codecs/wm0010.c
: +++ b/sound/soc/codecs/wm0010.c
: @@ -847,7 +847,7 @@ static int wm0010_probe(struct snd_soc_c
: trigger = IRQF_TRIGGER_FALLING;

: trigger |= IRQF_ONESHOT;
:
: - ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger,
: + ret = request_threaded_irq(irq, NULL, wm0010_irq, trigger | IRQF_ONESHOT,
: "wm0010", wm0010);
: if (ret)
: dev_err(wm0010->dev, "Failed to request IRQ %d: %d\n",
:

I'm not sure what could be done better...

Quoted 1 line · Julia Lawall

I'm not sure what could be done better...

The patch itself was fine but it was buried as an attachment to a mail that didn't have anything like a [PATCH] tag or anything so it was very hidden when it turned up in e-mail.