arm: mxs: Fix MMC WP pin being inverted
Subsystems (2)
PATCH 1/1 arm: mxs: Fix MMC WP pin being inverted
The MMC WP is active high on the m28evk, fix this.
--- arch/arm/boot/dts/imx28-m28evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/imx28-m28evk.dts +1 -1
@@ -63,7 +63,7 @@ &mmc0_cd_cfg &mmc0_sck_cfg>; bus-width = <8>; - wp-gpios = <&gpio3 10 1>; + wp-gpios = <&gpio3 10 0>; vmmc-supply = <®_vddio_sd0>; status = "okay"; };
Signature · 1 line
1.7.10.4
PATCH 1/1 arm: mxs: Fix MMC WP pin being inverted
Please resend with subject "arm: " changing to "ARM: ", or even better the one below.
ARM: dts: m28evk: ...
Quoted 25 lines · Marek Vasut
The MMC WP is active high on the m28evk, fix this.
Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Shawn Guo <[email protected]>--- arch/arm/boot/dts/imx28-m28evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/arm/boot/dts/imx28-m28evk.dts +1
-1@@ -63,7 +63,7 @@ &mmc0_cd_cfg &mmc0_sck_cfg>; bus-width = <8>; - wp-gpios = <&gpio3 10 1>; + wp-gpios = <&gpio3 10 0>; vmmc-supply = <®_vddio_sd0>; status = "okay"; };Signature · 1 line
1.7.10.4
Signature · 2 lines
Regards, Shawn
PATCH 1/1 arm: mxs: Fix MMC WP pin being inverted
Dear Shawn Guo,
Quoted 4 lines
Please resend with subject "arm: " changing to "ARM: ", or even better the one below.
ARM: dts: m28evk: ...
I really don't like this game ...
Quoted 23 lines · Marek Vasut
Quoted 21 lines
The MMC WP is active high on the m28evk, fix this.
Signed-off-by Marek Vasut <[email protected]>Cc Fabio Estevam <[email protected]>Cc Shawn Guo <[email protected]>---
arch/arm/boot/dts/imx28-m28evk.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)(quoted diff) +0
-0
b/arch/arm/boot/dts/imx28-m28evk.dtsindex 845bb42..10868f1 100644arch/arm/boot/dts/imx28-m28evk.dts +0
-0@@ -63,7 +63,7 @@ &mmc0_cd_cfg &mmc0_sck_cfg>; bus-width = <8>;
Quoted 7 lines
arch/arm/boot/dts/imx28-m28evk.dts line 69
Quoted 7 lines
arch/arm/boot/dts/imx28-m28evk.dts +1
-1- wp-gpios = <&gpio3 10 1>; + wp-gpios = <&gpio3 10 0>;arch/arm/boot/dts/imx28-m28evk.dts +0
-0vmmc-supply = <®_vddio_sd0>; status = "okay"; };
Best regards,
Marek Vasut
PATCH 1/1 arm: mxs: Fix MMC WP pin being inverted
Quoted 9 lines · Marek Vasut
Dear Shawn Guo,
Quoted 4 lines
Please resend with subject "arm: " changing to "ARM: ", or even better the one below.
ARM: dts: m28evk: ...
I really don't like this game ...
You either stay out of the game or play it well.
Signature · 2 lines
Regards, Shawn
PATCH 1/1 arm: mxs: Fix MMC WP pin being inverted
Dear Shawn Guo,
Quoted 11 lines · Marek Vasut
Quoted 8 lines
Dear Shawn Guo,
Quoted 4 lines
Please resend with subject "arm: " changing to "ARM: ", or even better the one below.
ARM: dts: m28evk: ...
I really don't like this game ...
You either stay out of the game or play it well.
You know, as I already complained, well defined rules would be welcome.
All these tags seem to me just as a tool for maintainers to unnecesarily torture people. I'd be much happier if we had a tool or something that'd either check them or generate them -- that'd make my life much easier. I think I'm not alone here.
Maybe a checkpatch-alike tool? But we have no list of valid tags, so, there're no well-defined rules, only some unspoken agreement :-(
Best regards,
Marek Vasut
PATCH 1/1 arm: mxs: Fix MMC WP pin being inverted
Quoted 10 lines · Marek Vasut
You know, as I already complained, well defined rules would be welcome.
All these tags seem to me just as a tool for maintainers to unnecesarily torture people. I'd be much happier if we had a tool or something that'd either check them or generate them -- that'd make my life much easier. I think I'm not alone here.
Maybe a checkpatch-alike tool? But we have no list of valid tags, so, there're no well-defined rules, only some unspoken agreement :-(
I'm pretty sure you know the rule, since I have been told you time and time again.
It's not about rule but attitude, really.
Signature · 2 lines
Regards, Shawn
PATCH 1/1 arm: mxs: Fix MMC WP pin being inverted
Dear Shawn Guo,
Quoted 8 lines · Marek Vasut
Quoted 7 lines
You know, as I already complained, well defined rules would be welcome.
All these tags seem to me just as a tool for maintainers to unnecesarily torture people. I'd be much happier if we had a tool or something that'd either check them or generate them -- that'd make my life much easier. I think I'm not alone here.
Quoted 5 lines
Quoted 2 lines
Maybe a checkpatch-alike tool? But we have no list of valid tags, so, there're no well-defined rules, only some unspoken agreement :-(
I'm pretty sure you know the rule, since I have been told you time and time again.
It takes practice ... still, I have a feeling some of the tags emerge at random.
Quoted 1 line
It's not about rule but attitude, really.
Hihihi, I think we can agree on that :-D
Best regards,
Marek Vasut