Skip to contentSkip to conversation

aoe: cleanup an allocation a bit

PATCH In review Dan Carpenter 2 participants 2 messages Sep 8, 2012 – Sep 9, 2012

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 aoe: cleanup an allocation a bit

We changed this recently so we can just use kzalloc() here instead of kcalloc(1, ...). Kernel style prefers sizeof(*t) over sizeof *t. The kfree(t) is a no-op now as well so that can be removed.

---
Only applies to linux-next.

drivers/block/aoe/aoecmd.c +1 -2
index 5461faa..c0adbbd 100644
@@ -1255,9 +1255,8 @@ addtgt(struct aoedev *d, char *addr, ulong nframes)
 			"aoe: device addtgt failure; too many targets\n");
 		return NULL;
 	}
-	t = kcalloc(1, sizeof *t, GFP_ATOMIC);
+	t = kzalloc(sizeof(*t), GFP_ATOMIC);
 	if (!t) {
-		kfree(t);
 		printk(KERN_INFO "aoe: cannot allocate memory to add target\n");
 		return NULL;
 	}
#1 lore raw

Looks OK to me, thanks.

Quoted 23 lines · Dan Carpenter

We changed this recently so we can just use kzalloc() here instead of kcalloc(1, ...). Kernel style prefers sizeof(*t) over sizeof *t. The kfree(t) is a no-op now as well so that can be removed.

---
Only applies to linux-next.

drivers/block/aoe/aoecmd.c +1 -2
index 5461faa..c0adbbd 100644
@@ -1255,9 +1255,8 @@ addtgt(struct aoedev *d, char *addr, ulong nframes)
           "aoe: device addtgt failure; too many targets\n");
       return NULL;
   }
-    t = kcalloc(1, sizeof *t, GFP_ATOMIC);
+    t = kzalloc(sizeof(*t), GFP_ATOMIC);
   if (!t) {
-        kfree(t);
       printk(KERN_INFO "aoe: cannot allocate memory to add target\n");
       return NULL;
   }