Skip to contentSkip to conversation

virtio-spec: fix thinko in multiport documentation

PATCH In review Michael S. Tsirkin 3 participants 7 messages Sep 9, 2012 – Dec 14, 2012 virtio core

lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

PATCH 1/1 virtio-spec: fix thinko in multiport documentation

spec numbers ports port0, port 1 etc, then goes on to say "ports 2 onwards only if MULTIPORT is set".
An obvious thinko, should be port 1 onwards.

Signed-off-by Michael S. Tsirkin <[email protected]>
---
 virtio-spec.lyx | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
virtio-spec.lyx +7 -1
index a713807..d801aa6 100644
@@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0).
 status open
 
 \begin_layout Plain Layout
-Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
+Ports 
+\change_inserted 1986246365 1347188327
+1
+\change_deleted 1986246365 1347188327
+2
+\change_unchanged
+ onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
 \end_layout
 
 \end_inset
Signature · 1 line
MST
author maintainer
#2 lore raw
In reply to Michael S. Tsirkin
Quoted 5 lines · Michael S. Tsirkin

spec numbers ports port0, port 1 etc, then goes on to say "ports 2 onwards only if MULTIPORT is set".
An obvious thinko, should be port 1 onwards.

Signed-off-by Michael S. Tsirkin <[email protected]>

Ping.

Quoted 25 lines
---
 virtio-spec.lyx | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
virtio-spec.lyx +7 -1
index a713807..d801aa6 100644
@@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0).
 status open
 
 \begin_layout Plain Layout
-Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
+Ports 
+\change_inserted 1986246365 1347188327
+1
+\change_deleted 1986246365 1347188327
+2
+\change_unchanged
+ onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
 \end_layout
 
 \end_inset
Signature · 1 line
MST
author maintainer
#3 lore raw
In reply to Michael S. Tsirkin
Quoted 5 lines · Michael S. Tsirkin

spec numbers ports port0, port 1 etc, then goes on to say "ports 2 onwards only if MULTIPORT is set".
An obvious thinko, should be port 1 onwards.

Signed-off-by Michael S. Tsirkin <[email protected]>

Rusty, Amit, any feedback?

Quoted 25 lines
---
 virtio-spec.lyx | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
virtio-spec.lyx +7 -1
index a713807..d801aa6 100644
@@ -6298,7 +6298,13 @@ Virtqueues 0:receiveq(port0).
 status open
 
 \begin_layout Plain Layout
-Ports 2 onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
+Ports 
+\change_inserted 1986246365 1347188327
+1
+\change_deleted 1986246365 1347188327
+2
+\change_unchanged
+ onwards only if VIRTIO_CONSOLE_F_MULTIPORT is set
 \end_layout
 
 \end_inset
Signature · 1 line
MST
author maintainer
#5 lore raw
Quoted 6 lines · Amit Shah
Quoted 5 lines · Michael S. Tsirkin
Quoted 4 lines · Michael S. Tsirkin

spec numbers ports port0, port 1 etc, then goes on to say "ports 2 onwards only if MULTIPORT is set".
An obvious thinko, should be port 1 onwards.

Quoted 7 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Michael S. Tsirkin <[email protected]>

Rusty, Amit, any feedback?

http://thread.gmane.org/gmane.linux.kernel.virtualization/16973/focus=16980

Amit

Ah you acked.
Rusty can you pick this up please?

#6 lore raw
Quoted 9 lines · Michael S. Tsirkin
Quoted 8 lines · Amit Shah
Quoted 7 lines · Michael S. Tsirkin
Quoted 5 lines · Michael S. Tsirkin

spec numbers ports port0, port 1 etc, then goes on to say "ports 2 onwards only if MULTIPORT is set".
An obvious thinko, should be port 1 onwards.

Signed-off-by Michael S. Tsirkin <[email protected]>
Quoted 8 lines
Quoted 5 lines
Quoted 1 line

Rusty, Amit, any feedback?

http://thread.gmane.org/gmane.linux.kernel.virtualization/16973/focus=16980

Amit

Ah you acked.
Rusty can you pick this up please?

Thanks, done.

Cheers,
Rusty.