Skip to contentSkip to conversation

ARM: kirkwood: Trim excess #includes in board-dnskw.c

PATCH New Jamie Lentin 2 participants 2 messages Sep 10, 2012 – Sep 11, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: kirkwood: Trim excess #includes in board-dnskw.c

Lots of code has now moved into the devicetree, leaving a collection of useless header files. Tidy them up.

This applies cleanly atop of my previous patch, "[PATCH V2 2/2] ARM:
kirkwood: Use devicetree to define DNS-32[05] fan", which also removes gpio-fan.h

---
 arch/arm/mach-kirkwood/board-dnskw.c |    9 ---------
 1 file changed, 9 deletions(-)
arch/arm/mach-kirkwood/board-dnskw.c +0 -9
index 6ac7a8d..43d16d6 100644
@@ -14,17 +14,8 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>
-#include <linux/ata_platform.h>
 #include <linux/mv643xx_eth.h>
-#include <linux/of.h>
 #include <linux/gpio.h>
-#include <linux/input.h>
-#include <linux/leds.h>
-#include <asm/mach-types.h>
-#include <asm/mach/arch.h>
-#include <asm/mach/map.h>
-#include <mach/kirkwood.h>
-#include <mach/bridge-regs.h>
 #include "common.h"
 #include "mpp.h"
 
Signature · 1 line
1.7.10.4
#1 lore raw

PATCH 1/1 ARM: kirkwood: Trim excess #includes in board-dnskw.c

Quoted 23 lines · Jamie Lentin

Lots of code has now moved into the devicetree, leaving a collection of useless header files. Tidy them up.

This applies cleanly atop of my previous patch, "[PATCH V2 2/2] ARM:
kirkwood: Use devicetree to define DNS-32[05] fan", which also removes gpio-fan.h

---
 arch/arm/mach-kirkwood/board-dnskw.c |    9 ---------
 1 file changed, 9 deletions(-)
arch/arm/mach-kirkwood/board-dnskw.c +0 -2
index 6ac7a8d..43d16d6 100644
@@ -14,17 +14,8 @@
 #include <linux/kernel.h>
 #include <linux/init.h>
 #include <linux/platform_device.h>
-#include <linux/ata_platform.h>
 #include <linux/mv643xx_eth.h>
-#include <linux/of.h>

arch/arm/mach-kirkwood/board-dnskw.c line 20

Quoted 10 lines
arch/arm/mach-kirkwood/board-dnskw.c +0 -7
 #include <linux/gpio.h>
-#include <linux/input.h>
-#include <linux/leds.h>
-#include <asm/mach-types.h>
-#include <asm/mach/arch.h>
-#include <asm/mach/map.h>
-#include <mach/kirkwood.h>
-#include <mach/bridge-regs.h>
 #include "common.h"
 #include "mpp.h"

Hi Jamie

A minor point. I personally would of based this patch on top of a plain -rc tag and not on top of the gpio-fan code. The gpio-fan code might need more revisions before its acceptable, where as this change is very likely to be accepted first time and is not controversial in any way. So Jason is likely to apply this now, before the gpio-fan code hits.

Andrew