Skip to contentSkip to conversation

drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987

PATCH In review Fengguang Wu 2 participants 4 messages Sep 11, 2012 Kernel janitors

lore
Share & tools
lore
#0 lore raw

PATCH 39/40 drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/linville/wireless.git master
head:   4abd044af91057f7ea661a0f10c00a9673beef6b
commit: 74673db99ca3c09d34ea479f684522ceedb65eb9 [39/40] ath9k: make PA linearization optional, disabled by default and fix checks

All smatch warnings:

+ drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2987 ath9k_hw_ar9300_get_eeprom() warn: if();
+ drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2989 ath9k_hw_ar9300_get_eeprom() info: ignoring unreachable code.
+ drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:2989 ath9k_hw_ar9300_get_eeprom() info: ignoring unreachable code. drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:3372 ath9k_hw_ar9300_fill_eeprom() Error invalid range 4096 to -1

vim +2987 drivers/net/wireless/ath/ath9k/ar9003_eeprom.c

2984 case EEP_PAPRD:
2985 if (AR_SREV_9462(ah))
2986 return false;

Quoted 1 line

2987 if (!ah->config.enable_paprd);

2988 return false;
2989 return !!(pBase->featureEnable & BIT(5));

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#1 lore raw
Quoted 1 line · Fengguang Wu

drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:3372 ath9k_hw_ar9300_fill_eeprom() Error invalid range 4096 to -1

Sorry for this false positive. I had it fixed in my tree but didn't push. It's pushed now.

regards,
dan carpenter

#2 lore raw
In reply to Fengguang Wu
Quoted 5 lines · Dan Carpenter
Quoted 1 line · Fengguang Wu

drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:3372 ath9k_hw_ar9300_fill_eeprom() Error invalid range 4096 to -1

Sorry for this false positive. I had it fixed in my tree but didn't push. It's pushed now.

Great! I do see many "invalid range 4096 to -1" warnings.

Thanks,
Fengguang

#3 lore raw
In reply to Fengguang Wu
Quoted 9 lines · Fengguang Wu
Quoted 5 lines · Dan Carpenter
Quoted 1 line · Fengguang Wu

drivers/net/wireless/ath/ath9k/ar9003_eeprom.c:3372 ath9k_hw_ar9300_fill_eeprom() Error invalid range 4096 to -1

Sorry for this false positive. I had it fixed in my tree but didn't push. It's pushed now.

Great! I do see many "invalid range 4096 to -1" warnings.

Could you send me a complete list of the warnings you have? I could look over them.

regards,
dan carpenter