ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T

Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected.
Adding a string description in the Kconfig resolves this.

But not sure if this is the right way to fix this.

Signed-off-by R Sricharan <[email protected]>

Cc Catalin Marinas <[email protected]>

---
  arch/arm/mm/Kconfig |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

arch/arm/mm/Kconfig +1 -1

index 101b968..90c5ea4 100644
@@ -601,7 +601,7 @@ config ARCH_PHYS_ADDR_T_64BIT
  	def_bool ARM_LPAE
 
  config ARCH_DMA_ADDR_T_64BIT
-	bool
+	bool "64bit capable DMA device"
 
  config ARM_THUMB
  	bool "Support Thumb user binaries"

Quoted 5 lines · R Sricharan

Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected.
Adding a string description in the Kconfig resolves this.

But not sure if this is the right way to fix this.

Shouldn't you be selecting this in your 64-bit dma address capable arch instead?

Quoted 5 lines · R Sricharan

Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected.
Adding a string description in the Kconfig resolves this.

Quoted 2 lines

But not sure if this is the right way to fix this.

Shouldn't you be selecting this in your 64-bit dma address capable arch instead?

Quoted 10 lines · Cyril Chemparathy

Quoted 7 lines · R Sricharan

Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected.
Adding a string description in the Kconfig resolves this.

But not sure if this is the right way to fix this.

Quoted 3 lines

Shouldn't you be selecting this in your 64-bit dma address capable arch instead?

Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens in the arch which needs it. Since this option was made as simple bool, looks like because of some KCONFIG magic, it was not getting selected. Adding some help text does fix the issue and thats is the patch all about.

Quoted 14 lines · Santosh

Quoted 13 lines · Cyril Chemparathy

Quoted 7 lines · R Sricharan

Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected.
Adding a string description in the Kconfig resolves this.

But not sure if this is the right way to fix this.

Shouldn't you be selecting this in your 64-bit dma address capable arch instead?

Quoted 4 lines

Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens in the arch which needs it. Since this option was made as simple bool, looks like because of some KCONFIG magic, it was not getting selected. Adding some help text does fix the issue and thats is the patch all about.

Are you sure you select this explicitly in Kconfig? It should not depend on a description.

What I understood from the initial email was that this option was only added to the defconfig but ignored by the kernel as it's not a user selectable option (unless you add some text).

Quoted 15 lines · Catalin Marinas

Quoted 14 lines · Santosh

Quoted 13 lines · Cyril Chemparathy

Quoted 7 lines · R Sricharan

Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected.
Adding a string description in the Kconfig resolves this.

But not sure if this is the right way to fix this.

Shouldn't you be selecting this in your 64-bit dma address capable arch instead?

Quoted 8 lines

Quoted 4 lines

Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens in the arch which needs it. Since this option was made as simple bool, looks like because of some KCONFIG magic, it was not getting selected. Adding some help text does fix the issue and thats is the patch all about.

Are you sure you select this explicitly in Kconfig? It should not depend on a description.

You are right.

Quoted 4 lines

What I understood from the initial email was that this option was only added to the defconfig but ignored by the kernel as it's not a user selectable option (unless you add some text).

That's right. Explicit KCONFIG select should work.

Quoted 10 lines · Cyril Chemparathy

Quoted 7 lines · R Sricharan

Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected.
Adding a string description in the Kconfig resolves this.

But not sure if this is the right way to fix this.

Quoted 3 lines

Shouldn't you be selecting this in your 64-bit dma address capable arch instead?

Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens in the arch which needs it. Since this option was made as simple bool, looks like because of some KCONFIG magic, it was not getting selected. Adding some help text does fix the issue and thats is the patch all about.

Hi,

Quoted 14 lines · Santosh

Quoted 13 lines · Cyril Chemparathy

Quoted 7 lines · R Sricharan

Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, the feature is not getting selected.
Adding a string description in the Kconfig resolves this.

But not sure if this is the right way to fix this.

Shouldn't you be selecting this in your 64-bit dma address capable arch instead?

Quoted 5 lines

Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens in the arch which needs it. Since this option was made as simple bool, looks like because of some KCONFIG magic, it was not getting selected. Adding some help text does fix the issue and thats is the patch all about.

Correct. So even if you select this in the arch/defconfig,