Skip to contentSkip to conversation

ptmx_open() error: double unlock 'mutex:&devpts_mutex'

DISCUSSION Fengguang Wu 4 participants 4 messages Sep 12, 2012 Kernel janitors

lore
Share & tools
lore
#0 lore raw

Hi Alan,

FYI, there are new smatch warnings show up in commit 89c8d91e31f267703e365593f6bfebb9f6d2ad01

drivers/tty/pty.c:670 ptmx_open() error: double unlock 'mutex:&devpts_mutex'

vim +670 drivers/tty/pty.c

666 out:
667 mutex_unlock(&tty_mutex);
668 devpts_kill_index(inode, index);
669 err_file:

Quoted 1 line

670 mutex_unlock(&devpts_mutex);

671 tty_free_file(filp);
672 return retval;
673 }
674

---
0-DAY kernel build testing backend Open Source Technology Centre
Fengguang Wu <[email protected]> Intel Corporation

#2 lore raw
In reply to Fengguang Wu

I sent a patch for this on "Wed, 11 Jul 2012 09:40:40 +0300" but I don't know what happened to it. The @linux.intel.com has been rejecting emails from @oracle.com for the past few months but I thought it was working in July.

----- The following addresses had permanent fatal errors -----
<[email protected]>

----- Transcript of session follows -----
403 4.7.0 encryption too weak 0 less than 128
<[email protected]>... Deferred
... while talking to mtab.intel.com.:

Quoted 1 line
Quoted 1 line
Quoted 1 line

DATA

<<< 503 #5.5.1 RCPT first
Message could not be delivered for 3 days
Message will be deleted from queue

regards,
dan carpenter

#3 lore raw
In reply to Fengguang Wu
Quoted 4 lines · On Wed, 12 Sep 2012 18:50:54 +0300 Dan Carpenter <[email protected]>…

I sent a patch for this on "Wed, 11 Jul 2012 09:40:40 +0300" but I don't know what happened to it. The @linux.intel.com has been rejecting emails from @oracle.com for the past few months but I thought it was working in July.

If it's important cc my lxorguk account.

Alan